Merge pull request #96 from Sea-Haven-Industries/fix/user-list-full-display-name

fix(users): compose full Name on user list
This commit is contained in:
Arthur Bassi 2026-08-31 13:13:48 -03:00 • committed by GitHub
commit 58dd5ec6ae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 41 additions and 1 deletions

View file

@ -0,0 +1,40 @@
using Data.SeaHavenIndustries;
using FluentAssertions;
using Microsoft.EntityFrameworkCore;
using SeaHaven.DataServices.Implementation;
using Xunit;
namespace Api.SeaHavenIndustries.Tests;
public class UserDataServiceTests
{
private static ApplicationDbContext NewContext()
{
var options = new DbContextOptionsBuilder<ApplicationDbContext>()
.UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString())
.Options;
return new ApplicationDbContext(options);
}
[Fact]
public async Task GetAllForListAsync_ComposesFullDisplayName()
{
await using var context = NewContext();
context.Users.Add(new ApplicationUser
{
Id = "s1",
UserName = "alex.smith",
Email = "alex.smith@example.com",
FirstName = "Alex",
LastName = "Smith"
});
await context.SaveChangesAsync();
var service = new UserDataService(context);
var rows = await service.GetAllForListAsync(CancellationToken.None);
rows.Should().ContainSingle();
rows[0].Id.Should().Be("s1");
rows[0].Name.Should().Be("Alex Smith");
}
}

View file

@ -44,7 +44,7 @@ namespace SeaHaven.DataServices.Implementation
Id = user.Id,
RoleName = user.PhoneNumber,
Email = user.Email,
Name = user.FirstName,
Name = ((user.FirstName ?? "") + " " + (user.LastName ?? "")).Trim(),
CreatedDate = user.CreatedDate,
Status = user.UniqueName
})