shoc-backend/SeaHaven.Services/Implementation/DropdownOptionsService.cs

89 lines
3.3 KiB
C#
Raw Permalink Normal View History

refactor: enforce backend boundaries and optimize dispatch (#30) * refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
2026-07-24 17:35:34 -03:00
using Data.SeaHavenIndustries;
using SeaHaven.DataServices.Interfaces;
using SeaHaven.Services.DTOs;
using SeaHaven.Services.Interfaces;
namespace SeaHaven.Services.Implementation
{
public class DropdownOptionsService : IDropdownOptionsService
{
private readonly IDropdownOptionsDataService _dataService;
public DropdownOptionsService(IDropdownOptionsDataService dataService)
{
_dataService = dataService;
}
public async Task<IEnumerable<DropdownOptionDTO>> GetAllAsync(string? category, CancellationToken cancellationToken)
{
var data = await _dataService.GetAllActiveAsync(category, cancellationToken);
return data.Select(MapToDTO);
}
public async Task<IEnumerable<DropdownOptionDTO>> GetByCategoryAsync(string category, string? parent, CancellationToken cancellationToken)
{
var data = await _dataService.GetByCategoryAsync(category, parent, cancellationToken);
return data.Select(MapToDTO);
}
public async Task<DropdownOptionDTO> CreateAsync(DropdownOptionDTO option, CancellationToken cancellationToken)
{
if (string.IsNullOrWhiteSpace(option.Category) || string.IsNullOrWhiteSpace(option.Value))
throw new InvalidOperationException("Category and Value are required");
if (await _dataService.ExistsAsync(option.Category, option.Value, option.ParentValue, cancellationToken))
throw new InvalidOperationException("This option already exists");
var entity = new DropdownOption
{
Id = 0,
Category = option.Category,
Value = option.Value,
ParentValue = option.ParentValue,
SortOrder = option.SortOrder,
IsActive = true
};
var created = await _dataService.AddAsync(entity, cancellationToken);
return MapToDTO(created);
}
public async Task<DropdownOptionDTO> UpdateAsync(int id, DropdownOptionDTO option, CancellationToken cancellationToken)
{
var item = await _dataService.GetByIdAsync(id, cancellationToken);
if (item == null)
throw new KeyNotFoundException("Option not found");
item.Value = option.Value;
item.ParentValue = option.ParentValue;
item.SortOrder = option.SortOrder;
item.IsActive = option.IsActive;
await _dataService.UpdateAsync(item, cancellationToken);
return MapToDTO(item);
}
public async Task DeleteAsync(int id, CancellationToken cancellationToken)
{
var item = await _dataService.GetByIdAsync(id, cancellationToken);
if (item == null)
throw new KeyNotFoundException("Option not found");
await _dataService.RemoveAsync(item, cancellationToken);
}
private static DropdownOptionDTO MapToDTO(DropdownOption option)
{
return new DropdownOptionDTO
{
Id = option.Id,
Category = option.Category,
Value = option.Value,
ParentValue = option.ParentValue,
SortOrder = option.SortOrder,
IsActive = option.IsActive
};
}
}
}