shoc-backend/SeaHaven.DataServices/Interfaces/ISyncDataService.cs

26 lines
1.4 KiB
C#
Raw Permalink Normal View History

refactor: enforce backend boundaries and optimize dispatch (#30) * refactor(api): enforce service and data-service boundaries * refactor(api): complete feature service boundaries * refactor(identity): enforce service and data boundaries * refactor(vendors): enforce service and data boundaries * refactor(workorders): enforce service and data boundaries * refactor(backend): enforce architecture and optimize dispatch * style(backend): format changed architecture files * fix(architecture): address backend review follow-ups * fix(backend): sanitize exception disclosure in changed API endpoints Replace raw exception-message disclosure (ex.Message) returned to API callers with a stable sanitized public message plus correlated structured internal logging, across the endpoints changed in this PR. - Add SanitizedErrors helper: logs the original exception at Error with a generated correlation id and returns a stable public message referencing it so support can trace without exposing internals. - Inject ILogger<T> into the 14 changed controllers and route every ex.Message/dbex.Message disclosure through the helper, preserving status codes, response shapes, and business data (e.g. OpenWorkOrders). - Leave FluentValidation (vex.Errors) and existing fixed-message catches untouched; out-of-scope controllers (Account/Contact/Employee/Asset/ PMSchedule) are unchanged. - Add focused tests proving internal exception text is not returned and that Error logging carrying the original exception is invoked. * fix(architecture): abstract job run state access * style: format board update service * test: use collection assertion idiom
2026-07-24 17:35:34 -03:00
using Data.SeaHavenIndustries;
namespace SeaHaven.DataServices.Interfaces
{
public interface ISyncDataService
{
Task<string?> GetLastInternalWONumberAsync(CancellationToken cancellationToken);
Task<WorkOrder?> GetWorkOrderByExternalIdAsync(string externalId, CancellationToken cancellationToken);
void EnqueueWorkOrder(WorkOrder workOrder);
void EnqueueComment(Comments comment);
Task SaveChangesAsync(CancellationToken cancellationToken);
Task<int?> ResolveLocationAsync(string? siteCode, string? building, string? address, CancellationToken cancellationToken);
Task<int> GetLocationCountAsync(CancellationToken cancellationToken);
Task<bool> CommentExistsByExternalIdAsync(string externalId, CancellationToken cancellationToken);
Task<WorkOrder?> GetWorkOrderByInternalNumberAsync(string internalNumber, CancellationToken cancellationToken);
Task<Dispatch?> GetDispatchByNumberAndWorkOrderIdAsync(string dispatchNumber, int workOrderId, CancellationToken cancellationToken);
Task<List<WorkOrder>> GetWorkOrdersMissingInternalNumberAsync(CancellationToken cancellationToken);
Task<List<Dispatch>> GetDispatchesMissingNumberAsync(CancellationToken cancellationToken);
Task<int> ExecuteBackfillCommentTypesAsync(CancellationToken cancellationToken);
Task<string?> GetLastDispatchNumberAsync(CancellationToken cancellationToken);
}
}