fix: address review comments

This commit is contained in:
Adam Moussa 2026-09-28 14:07:47 -04:00
parent 4b6425f568
commit e178d168a7
No known key found for this signature in database

View file

@ -15,7 +15,7 @@ No Jira keys in branch names.
## Pull Requests
**Title:** `type(scope): description (DEV-123)` when a Jira ticket already exists. Minor, docs, hygiene, and dependency changes omit the suffix. Do not create a ticket only to fill a title.
**Title:** `type(scope): description (DEV-123)` — every non-exempt PR ends with its Jira key.
**Body sections (in order):** Summary · Validation · Tests · Notes — use "None." when a section is empty.
State verifiable facts only. Do not cite the handbook to justify changes.
@ -49,4 +49,4 @@ nvm use 24
export PATH="$(dirname "$(nvm which 24)"):$PATH"
```
Canonical checks: `npm ci`, `npm run build`, `npx cdk synth`. Also run `cdk diff` for every stack this change touches and review the output before opening the PR, whenever this VM can read those accounts. If credentials cannot reach an account, say that in Validation and leave the diff for a human reviewer. Do not `cdk deploy` from this environment.
Canonical checks: `npm ci`, `npm run build`, `npx cdk synth`. Also run `cdk diff` for every stack this change touches and review the output before opening the PR. Do not `cdk deploy` from this environment.