mirror of
https://github.com/Sea-Haven-Industries/seahaven-org-baseline.git
synced 2026-10-03 20:03:13 +00:00
docs(agents): keep cdk diff required and exempt docs titles
Cloud agents still review cdk diff when the VM can read the accounts. Docs, hygiene, and dependency pull requests omit a Jira suffix instead of opening a ticket only to fill the title. Co-authored-by: Adam Moussa <amoussa1229@users.noreply.github.com>
This commit is contained in:
parent
900f2a6297
commit
df4188ab83
1 changed files with 2 additions and 2 deletions
|
|
@ -15,7 +15,7 @@ No Jira keys in branch names.
|
|||
|
||||
## Pull Requests
|
||||
|
||||
**Title:** `type(scope): description (DEV-123)` — every non-exempt PR ends with its Jira key.
|
||||
**Title:** `type(scope): description (DEV-123)` when a Jira ticket already exists. Minor, docs, hygiene, and dependency changes omit the suffix. Do not create a ticket only to fill a title.
|
||||
|
||||
**Body sections (in order):** Summary · Validation · Tests · Notes — use "None." when a section is empty.
|
||||
State verifiable facts only. Do not cite the handbook to justify changes.
|
||||
|
|
@ -49,4 +49,4 @@ nvm use 24
|
|||
export PATH="$(dirname "$(nvm which 24)"):$PATH"
|
||||
```
|
||||
|
||||
Canonical checks: `npm ci`, `npm run build`, `npx cdk synth`. `cdk diff` and `cdk deploy` talk to live AWS accounts and are not part of this environment.
|
||||
Canonical checks: `npm ci`, `npm run build`, `npx cdk synth`. Also run `cdk diff` for every stack this change touches and review the output before opening the PR, whenever this VM can read those accounts. If credentials cannot reach an account, say that in Validation and leave the diff for a human reviewer. Do not `cdk deploy` from this environment.
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue