chore(backup): drop the file-share rollback volume from phase 2 (PLAT-77) (#168)
Some checks are pending
Deploy / deploy-management (push) Waiting to run
Deploy / deploy-external-dev (push) Waiting to run
Deploy / deploy-security (push) Waiting to run
Deploy / deploy-dev (push) Waiting to run
Deploy / deploy-prod (push) Waiting to run

* chore(backup): drop the file-share rollback volume from phase 2 (PLAT-77)

The rollback hold is being deleted now, so the selection must not keep an ARN that will not exist.

* docs(backup): state why the file-share volume leaves phase 2 (PLAT-77)

The comment now matches the cleanup: the missing volume is already gone, and the rollback volume leaves because the hold ended.
This commit is contained in:
Adam Moussa 2026-09-29 20:23:47 -04:00 • committed by GitHub
parent 78e4bcf128
commit 1e10c40e52
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -255,10 +255,10 @@ export class BackupStack extends cdk.Stack {
//
// Still EXPLICIT-ARN (not tag-based) on purpose: the DynamoDB tables are
// owned by other stacks, so tagging them here would drift those stacks.
// vol-054cf918f227d88f6 (file-share, 20 GiB) no longer exists and is out of
// this selection. vol-04d951cccacc435b5 stays through the PLAT-77 rollback
// hold (RetainUntil 2026-10-06) so that disk keeps its offsite copy. Remove
// it when the hold ends. Tradeoff: if a volume is replaced (new vol-id) it
// File-share left this account (PLAT-77). vol-054cf918f227d88f6 does not
// exist. vol-04d951cccacc435b5 is out of this selection because the
// rollback hold ended and that volume is deleted. Tradeoff: if a volume
// is replaced (new vol-id) it
// silently drops from this selection; scheduled drift detection and the
// audit re-run are the backstop. Identifiers verified against the live
// account 2026-06-03.
@ -293,7 +293,6 @@ export class BackupStack extends cdk.Stack {
...[
"vol-05cb0eb5c145d799b", // SeaHavenIndustries-dev
"vol-00f05a5a809697ce5", // forgejo
"vol-04d951cccacc435b5", // file-share NAS rollback hold until 2026-10-06
"vol-07094902194638fff", // syslog-server
"vol-0c2cbe9e71517a517", // Mutual Aid Data
"vol-0fe224f13812f47e7", // jump box