Merge branch 'feature/invoice-filter-toolbar' into feature/columns-slideover

e2e/dashboard-grids.spec.ts

@@ -53,6 +53,19 @@ test.describe("dashboard grids", () => {
       /Pay run stub: [2-9]\d* invoice\(s\) selected/,
     );
 
+    await page.getByTestId("columns-toggle").click();
+    const drawer = page.getByTestId("columns-drawer");
+    await drawer.getByTestId("columns-hidden-search").fill("Payment Date");
+    await drawer
+      .getByTestId("columns-hidden-paymentDate")
+      .locator('input[type="checkbox"]')
+      .evaluate((el: HTMLInputElement) => {
+        el.click();
+      });
+    await expect(
+      readyGrid.locator('.MuiDataGrid-columnHeader[data-field="payDate"]'),
+    ).toBeVisible();
+
     const payDateCell = readyGrid.locator('[data-field="payDate"]').nth(1);
     await payDateCell.dblclick();
     const editor = readyGrid

e2e/invoice-columns.spec.ts

@@ -34,14 +34,22 @@ test.describe("Invoice Processing columns drawer (AP-45)", () => {
     await page.goto("/");
     await page.getByTestId("columns-toggle").click();
     const drawer = page.getByTestId("columns-drawer");
-    const vendorBox = drawer.getByTestId("columns-visible-vendor").locator('input[type="checkbox"]');
+    const vendorBox = drawer
+      .getByTestId("columns-visible-vendor")
+      .locator('input[type="checkbox"]');
     await expect(vendorBox).toBeDisabled();
     await vendorBox.evaluate((el: HTMLInputElement) => {
       el.disabled = false;
       el.click();
     });
     await expect(
-      page.getByTestId("grid-pending").locator('.MuiDataGrid-columnHeader[data-field="vendor"]'),
+      page
+        .getByTestId("grid-pending")
+        .locator('.MuiDataGrid-columnHeader[data-field="vendorName"]'),
+    ).toBeVisible();
+    await page.getByTestId("tab-ready").click();
+    await expect(
+      page.getByTestId("grid-ready").locator('.MuiDataGrid-columnHeader[data-field="vendorName"]'),
     ).toBeVisible();
 
     const search = drawer.getByTestId("columns-hidden-search");

e2e/invoice-filters.spec.ts

@@ -16,6 +16,9 @@ test.describe("Invoice Processing filters (AP-43)", () => {
     await page.getByTestId("vendor-filter").fill("Harbor");
     await expect(page.getByTestId("filter-toggle").locator(".MuiBadge-badge")).toHaveText("2");
     await expect(grid.locator(".MuiDataGrid-row")).toHaveCount(1);
-    await expect(page.getByTestId("attention-banner")).toContainText("1 invoices require approval");
+    await expect(page.getByTestId("tab-pending").locator("span").last()).toHaveText("1");
+    await expect(page.getByTestId("attention-banner")).toContainText(
+      "1 invoices require approval. Show invoices ready to approve.",
+    );
   });
 });

src/dashboard/DashboardGrids.tsx

@@ -5,7 +5,7 @@ import { ColumnsDrawer } from "@/dashboard/ColumnsDrawer";
 import { InvoiceFilterToolbar } from "@/dashboard/InvoiceFilterToolbar";
 import { CreatePayRunButton } from "@/dashboard/CreatePayRunButton";
 import { InvoiceDataGrid } from "@/dashboard/InvoiceDataGrid";
-import { columnsFromCatalogKeys } from "@/dashboard/columns";
+import { columnsForApprovedGrid, columnsFromCatalogKeys } from "@/dashboard/columns";
 import {
   loadColumnPrefs,
   resetColumnPrefs,
@@ -85,6 +85,10 @@ export function DashboardGrids() {
     () => columnsFromCatalogKeys(columnPrefs.visibleOrder),
     [columnPrefs.visibleOrder],
   );
+  const approvedColumns = useMemo(
+    () => columnsForApprovedGrid(columnPrefs.visibleOrder),
+    [columnPrefs.visibleOrder],
+  );
 
   const openInvoice = (params: GridRowParams<MockInvoice>) => {
     navigate("/invoices/:id", { params: { id: params.row.id } });
@@ -176,7 +180,7 @@ export function DashboardGrids() {
             label={
               <InvoiceTabLabel
                 title="For My Attention"
-                count={attentionRows.length}
+                count={filteredAttention.length}
                 active={tab === "attention"}
               />
             }
@@ -187,7 +191,7 @@ export function DashboardGrids() {
             label={
               <InvoiceTabLabel
                 title="New Invoices"
-                count={invoices.length}
+                count={filteredAll.length}
                 active={tab === "all"}
               />
             }
@@ -198,7 +202,7 @@ export function DashboardGrids() {
             label={
               <InvoiceTabLabel
                 title="Approved Invoices"
-                count={approvedRows.length}
+                count={filteredApproved.length}
                 active={tab === "approved"}
               />
             }
@@ -209,7 +213,7 @@ export function DashboardGrids() {
             label={
               <InvoiceTabLabel
                 title="Rejected Invoices"
-                count={rejectedRows.length}
+                count={filteredRejected.length}
                 active={tab === "rejected"}
               />
             }
@@ -220,7 +224,7 @@ export function DashboardGrids() {
             label={
               <InvoiceTabLabel
                 title="Late Invoices"
-                count={lateRows.length}
+                count={filteredLate.length}
                 active={tab === "late"}
                 urgency
               />
@@ -234,22 +238,14 @@ export function DashboardGrids() {
       <Box sx={{ bgcolor: "background.paper", p: 2 }}>
         {filteredAttention.length > 0 && tab === "attention" ? (
           <Typography
-            component="button"
-            type="button"
             data-testid="attention-banner"
-            sx={{
-              display: "block",
-              mb: 1.5,
-              p: 0,
-              border: 0,
-              background: "none",
-              cursor: "pointer",
-              color: "primary.main",
-              typography: "body2",
-              textAlign: "left",
-            }}
+            variant="body2"
+            sx={{ display: "block", mb: 1.5, color: "primary.main", textAlign: "left" }}
           >
-            {filteredAttention.length} invoices require approval. Show invoices ready to approve.
+            {filteredAttention.length} invoices require approval.{" "}
+            <Box component="span" sx={{ textDecoration: "underline" }}>
+              Show invoices ready to approve.
+            </Box>
           </Typography>
         ) : null}
 
@@ -287,7 +283,7 @@ export function DashboardGrids() {
           <InvoiceDataGrid
             data-testid="grid-ready"
             rows={filteredApproved}
-            columns={catalogColumns}
+            columns={approvedColumns}
             checkboxSelection
             rowSelectionModel={selection}
             onRowSelectionModelChange={(model) => setSelection(model)}

src/dashboard/approved-columns.ts

@@ -0,0 +1,9 @@
+import type { GridColDef } from "@mui/x-data-grid";
+import type { MockInvoice } from "@/mocks";
+
+/** Mark a visible pay-date column editable. A hidden Payment Date stays omitted. */
+export function withEditablePayDate(columns: GridColDef<MockInvoice>[]): GridColDef<MockInvoice>[] {
+  return columns.map((column) =>
+    column.field === "payDate" ? { ...column, editable: true } : column,
+  );
+}

src/dashboard/columns.test.ts

@@ -1,4 +1,7 @@
+import type { GridColDef } from "@mui/x-data-grid";
 import { describe, expect, it } from "vitest";
+import { withEditablePayDate } from "@/dashboard/approved-columns";
+import type { MockInvoice } from "@/mocks";
 import { formatRelativeFromIsoDate, formatSlashDate } from "@/dashboard/invoice-date-format";
 
 describe("invoice column date helpers (AP-47)", () => {
@@ -26,3 +29,20 @@ describe("invoice column date helpers (AP-47)", () => {
     expect(formatRelativeFromIsoDate("2026-10-11", now)).toBe("in 2 months");
   });
 });
+
+describe("withEditablePayDate", () => {
+  const hidden: GridColDef<MockInvoice> = { field: "vendorName", headerName: "Vendor" };
+  const payDate: GridColDef<MockInvoice> = { field: "payDate", headerName: "Payment Date" };
+
+  it("leaves Payment Date hidden when the catalog omits it", () => {
+    const columns = withEditablePayDate([hidden]);
+    expect(columns.some((column) => column.field === "payDate")).toBe(false);
+  });
+
+  it("keeps a single editable pay date when Payment Date is already visible", () => {
+    const columns = withEditablePayDate([hidden, { ...payDate, editable: false }]);
+    const matches = columns.filter((column) => column.field === "payDate");
+    expect(matches).toHaveLength(1);
+    expect(matches[0]?.editable).toBe(true);
+  });
+});

src/dashboard/columns.tsx

@@ -4,6 +4,7 @@ import NotificationsNoneOutlinedIcon from "@mui/icons-material/NotificationsNone
 import VisibilityOutlinedIcon from "@mui/icons-material/VisibilityOutlined";
 import { Box, Link as MuiLink, Stack, Typography } from "@mui/material";
 import type { GridColDef, GridRenderCellParams } from "@mui/x-data-grid";
+import { withEditablePayDate } from "@/dashboard/approved-columns";
 import type { InvoiceColumnKey } from "@/dashboard/column-catalog";
 import { formatRelativeFromIsoDate, formatSlashDate } from "@/dashboard/invoice-date-format";
 import type { MockInvoice } from "@/mocks";
@@ -250,6 +251,11 @@ export function columnsFromCatalogKeys(keys: InvoiceColumnKey[]): GridColDef<Moc
   return keys.map((key) => catalogColumnDefs[key]);
 }
 
+/** Approved tab keeps pay date editable when the drawer shows Payment Date. */
+export function columnsForApprovedGrid(keys: InvoiceColumnKey[]): GridColDef<MockInvoice>[] {
+  return withEditablePayDate(columnsFromCatalogKeys(keys));
+}
+
 export const readyToPayColumns: GridColDef<MockInvoice>[] = [
   {
     field: "invoiceNumber",

src/mocks/index.test.ts

@@ -67,6 +67,7 @@ describe("mocks module", () => {
       expect(invoice.lastUpdateActorName.length).toBeGreaterThan(0);
       expect(invoice.lastUpdateAt.length).toBeGreaterThan(0);
       expect(invoice.invoiceDate).toMatch(/^\d{4}-\d{2}-\d{2}$/);
+      expect(invoice.invoiceDate).not.toBe(invoice.dueDate);
       expect(invoice.processingBegan).toMatch(/^\d{4}-\d{2}-\d{2}$/);
       expect(typeof invoice.tagging).toBe("string");
       expect(typeof invoice.fs).toBe("string");
@@ -83,6 +84,26 @@ describe("mocks module", () => {
     expect(pending.every((invoice) => invoice.actionLabel === "Approve invoice")).toBe(true);
     const nonPending = invoices.filter((invoice) => invoice.status !== "pending_approval");
     expect(nonPending.every((invoice) => invoice.actionLabel !== "Approve invoice")).toBe(true);
+    expect(
+      invoices
+        .filter((invoice) => invoice.status === "approved")
+        .every((invoice) => invoice.actionLabel === "Approved"),
+    ).toBe(true);
+    expect(
+      invoices
+        .filter((invoice) => invoice.status === "paid")
+        .every((invoice) => invoice.actionLabel === "Paid"),
+    ).toBe(true);
+    expect(
+      invoices
+        .filter((invoice) => invoice.status === "scheduled")
+        .every((invoice) => invoice.actionLabel === "Scheduled"),
+    ).toBe(true);
+    expect(
+      invoices
+        .filter((invoice) => invoice.status === "rejected")
+        .every((invoice) => invoice.actionLabel === "Rejected"),
+    ).toBe(true);
   });
 
   it("seeds at least two invoices per dashboard tab", () => {
@@ -101,6 +122,8 @@ describe("mocks module", () => {
 
     const updated = updateMockInvoicePayDate("inv-1", "2026-08-18");
     expect(updated.payDate).toBe("2026-08-18");
+    expect(updated.lastUpdateMessage).toBe("Pay date updated");
+    expect(updated.lastUpdateAt).not.toBe(before?.lastUpdateAt);
 
     const after = getMockInvoices().find((invoice) => invoice.id === "inv-1");
     expect(after?.payDate).toBe("2026-08-18");
@@ -148,6 +171,7 @@ describe("mocks module", () => {
       authorUserId: "user-1",
       authorName: "Alex Rivera",
       body: "Need another look",
+      createdAt: "2026-08-11T09:00:00.000Z",
     });
     expect(withComment.comments.some((comment) => comment.body === "Need another look")).toBe(true);
 
@@ -168,6 +192,23 @@ describe("mocks module", () => {
     expect(getMockApprovals().find((item) => item.invoiceId === "inv-2")?.status).toBe("approved");
   });
 
+  it("refreshes last update from a comment and payment account from the method", () => {
+    const commented = addMockInvoiceComment("inv-1", {
+      authorUserId: "user-1",
+      authorName: "Alex Rivera",
+      body: "Checked the total",
+      createdAt: "2026-09-01T15:00:00.000Z",
+    });
+    expect(commented.lastUpdateAt).toBe("2026-09-01T15:00:00.000Z");
+    expect(commented.lastUpdate).toBe("2026-09-01");
+    expect(commented.lastUpdateMessage).toBe("Checked the total");
+    expect(commented.lastUpdateActorName).toBe("Alex Rivera");
+
+    const method = updateMockInvoiceHeader("inv-1", { paymentMethod: "ach" });
+    expect(method.paymentAccount).toBe("Operating ACH");
+    expect(getMockInvoice("inv-1")?.paymentAccount).toBe("Operating ACH");
+  });
+
   it("refreshes description and rowCount when header or lines change", () => {
     const before = getMockInvoice("inv-1");
     expect(before?.rowCount).toBe(2);

src/mocks/invoices.ts

@@ -1,4 +1,3 @@
-import { INVOICE_ACTION_OPTIONS } from "@/dashboard/column-catalog";
 import { syncMockApprovalsForInvoice } from "@/mocks/approvals";
 import { areMocksEnabled } from "@/mocks/env";
 
@@ -104,65 +103,92 @@ type MockInvoiceCore = Omit<
   | "rowCount"
 >;
 
-/** Non-pending rows never show the pending-only "Approve invoice" action. */
-const NON_PENDING_ACTION_OPTIONS = INVOICE_ACTION_OPTIONS.filter(
-  (option) => option !== "Approve invoice",
-);
+const ACTION_LABEL_BY_STATUS: Record<MockInvoiceStatus, string> = {
+  pending_approval: "Approve invoice",
+  approved: "Approved",
+  scheduled: "Scheduled",
+  paid: "Paid",
+  rejected: "Rejected",
+};
 
-function actionLabelForStatus(status: MockInvoiceStatus, index: number): string {
-  if (status === "pending_approval") {
-    return "Approve invoice";
-  }
-  return NON_PENDING_ACTION_OPTIONS[index % NON_PENDING_ACTION_OPTIONS.length];
+function actionLabelForStatus(status: MockInvoiceStatus): string {
+  return ACTION_LABEL_BY_STATUS[status];
 }
 
-function derivedActivityFields(invoice: Pick<MockInvoice, "activity" | "dueDate">) {
-  const latestActivity = invoice.activity[invoice.activity.length - 1];
-  const lastUpdateAt = latestActivity?.createdAt ?? `${invoice.dueDate}T12:00:00.000Z`;
+function derivedActivityFields(invoice: Pick<MockInvoice, "activity" | "comments" | "dueDate">) {
+  const events = [
+    ...invoice.activity.map((entry) => ({
+      at: entry.createdAt,
+      message: entry.message,
+      actor: entry.actorName,
+    })),
+    ...invoice.comments.map((comment) => ({
+      at: comment.createdAt,
+      message: comment.body,
+      actor: comment.authorName,
+    })),
+  ];
+  const latest = events.reduce<(typeof events)[number] | undefined>((current, event) => {
+    if (!current || event.at > current.at) {
+      return event;
+    }
+    return current;
+  }, undefined);
+  const lastUpdateAt = latest?.at ?? `${invoice.dueDate}T12:00:00.000Z`;
   return {
     lastUpdate: lastUpdateAt.slice(0, 10),
-    lastUpdateMessage: latestActivity?.message ?? "Invoice updated",
-    lastUpdateActorName: latestActivity?.actorName ?? "System",
+    lastUpdateMessage: latest?.message ?? "Invoice updated",
+    lastUpdateActorName: latest?.actor ?? "System",
     lastUpdateAt,
   };
 }
 
+function paymentAccountFor(paymentMethod: MockInvoice["paymentMethod"]): string {
+  return paymentMethod === "ach" ? "Operating ACH" : "Operating Check";
+}
+
+/** Invoice date is independent of the due date. Offset varies per seed. */
+function invoiceDateBeforeDue(dueDate: string, index: number): string {
+  const [year, month, day] = dueDate.split("-").map(Number);
+  const date = new Date(Date.UTC(year, month - 1, day));
+  date.setUTCDate(date.getUTCDate() - (14 + index));
+  return date.toISOString().slice(0, 10);
+}
+
 /** Keep catalog-derived fields in sync after mock mutations. */
-function withRefreshedCatalogFields(invoice: MockInvoice, index: number): MockInvoice {
+function withRefreshedCatalogFields(invoice: MockInvoice): MockInvoice {
   return {
     ...invoice,
-    actionLabel: actionLabelForStatus(invoice.status, index),
+    actionLabel: actionLabelForStatus(invoice.status),
     ...derivedActivityFields(invoice),
     description: invoice.memo,
+    paymentAccount: paymentAccountFor(invoice.paymentMethod),
     rowCount: invoice.lines.length,
   };
 }
 
 function enrichInvoice(core: MockInvoiceCore, index: number): MockInvoice {
-  return withRefreshedCatalogFields(
-    {
-      ...core,
-      hasBolt: index % 3 === 0,
-      hasBell: index % 2 === 0,
-      hasEye: true,
-      actionLabel: actionLabelForStatus(core.status, index),
-      lastUpdate: "",
-      lastUpdateMessage: "",
-      lastUpdateActorName: "",
-      lastUpdateAt: "",
-      invoiceDate: core.dueDate,
-      processingBegan: core.activity[0]?.createdAt?.slice(0, 10) ?? core.dueDate,
-      tagging: index % 2 === 0 ? "Ops" : "",
-      fs: index % 2 === 0 ? "synced" : "",
-      description: core.memo,
-      invoiceType: "Standard",
-      location: "Ronkonkoma",
-      paymentAccount: core.paymentMethod === "ach" ? "Operating ACH" : "Operating Check",
-      relatedInvoice: null,
-      rowCount: core.lines.length,
-    },
-    index,
-  );
+  return withRefreshedCatalogFields({
+    ...core,
+    hasBolt: index % 3 === 0,
+    hasBell: index % 2 === 0,
+    hasEye: true,
+    actionLabel: actionLabelForStatus(core.status),
+    lastUpdate: "",
+    lastUpdateMessage: "",
+    lastUpdateActorName: "",
+    lastUpdateAt: "",
+    invoiceDate: invoiceDateBeforeDue(core.dueDate, index),
+    processingBegan: core.activity[0]?.createdAt?.slice(0, 10) ?? core.dueDate,
+    tagging: index % 2 === 0 ? "Ops" : "",
+    fs: index % 2 === 0 ? "synced" : "",
+    description: core.memo,
+    invoiceType: "Standard",
+    location: "Ronkonkoma",
+    paymentAccount: paymentAccountFor(core.paymentMethod),
+    relatedInvoice: null,
+    rowCount: core.lines.length,
+  });
 }
 
 function cloneInvoice(invoice: MockInvoice): MockInvoice {
@@ -549,7 +575,24 @@ export function updateMockInvoicePayDate(id: string, payDate: string | null): Mo
     throw new Error(`Mock invoice not found: ${id}`);
   }
 
-  return replaceInvoice(index, { ...invoiceStore[index], payDate });
+  const current = invoiceStore[index];
+  return replaceInvoice(
+    index,
+    withRefreshedCatalogFields({
+      ...current,
+      payDate,
+      activity: [
+        ...current.activity,
+        {
+          id: `activity-pay-date-${Date.now()}`,
+          actorUserId: "user-1",
+          actorName: "System",
+          message: "Pay date updated",
+          createdAt: new Date().toISOString(),
+        },
+      ],
+    }),
+  );
 }
 
 export function updateMockInvoiceHeader(id: string, patch: MockInvoiceHeaderPatch): MockInvoice {
@@ -558,10 +601,7 @@ export function updateMockInvoiceHeader(id: string, patch: MockInvoiceHeaderPatc
     throw new Error(`Mock invoice not found: ${id}`);
   }
 
-  return replaceInvoice(
-    index,
-    withRefreshedCatalogFields({ ...invoiceStore[index], ...patch }, index),
-  );
+  return replaceInvoice(index, withRefreshedCatalogFields({ ...invoiceStore[index], ...patch }));
 }
 
 export function updateMockInvoiceLines(id: string, lines: MockInvoiceLine[]): MockInvoice {
@@ -572,13 +612,10 @@ export function updateMockInvoiceLines(id: string, lines: MockInvoiceLine[]): Mo
 
   return replaceInvoice(
     index,
-    withRefreshedCatalogFields(
-      {
-        ...invoiceStore[index],
-        lines: lines.map((line) => ({ ...line })),
-      },
-      index,
-    ),
+    withRefreshedCatalogFields({
+      ...invoiceStore[index],
+      lines: lines.map((line) => ({ ...line })),
+    }),
   );
 }
 
@@ -603,10 +640,13 @@ export function addMockInvoiceComment(
     createdAt: comment.createdAt ?? new Date().toISOString(),
   };
 
-  return replaceInvoice(index, {
-    ...current,
-    comments: [...current.comments, nextComment],
-  });
+  return replaceInvoice(
+    index,
+    withRefreshedCatalogFields({
+      ...current,
+      comments: [...current.comments, nextComment],
+    }),
+  );
 }
 
 export function transitionMockInvoiceStatus(
@@ -633,14 +673,11 @@ export function transitionMockInvoiceStatus(
 
   const updated = replaceInvoice(
     index,
-    withRefreshedCatalogFields(
-      {
-        ...current,
-        status,
-        activity: [...current.activity, nextActivity],
-      },
-      index,
-    ),
+    withRefreshedCatalogFields({
+      ...current,
+      status,
+      activity: [...current.activity, nextActivity],
+    }),
   );
 
   if (status === "approved" || status === "rejected") {