mirror of
https://github.com/Sea-Haven-Industries/proposal-system.git
synced 2026-10-03 12:43:17 +00:00
4f1271eb50
6-domain audit (API, web, mobile, lambdas, infra, QA) with fixes: API security: scope internal API key middleware to allowed paths only, return 401 on invalid key instead of falling through, remove unvalidated JWT code path, sanitize error messages, add UpdateProposal validator, remove status field from UpdateProposalRequest to prevent over-posting, log swallowed exceptions in ProposalService. Infrastructure: enforce SSL on all S3 buckets, encrypt SQS queues, enable optional MFA on Cognito, add API Gateway access logging. Lambdas: fix _retry_request undefined variable across all 4 Lambdas, re-raise exceptions in pdf-extract/pdf-generate instead of swallowing, add idempotency guard to suggestions Lambda. Web: add ErrorBoundary, add auth loading state to ProtectedRoute, add mutation error toasts in AdminWorkspace, fix dead Cognito link. Mobile: add mutex to offline queue processing, distinguish permanent vs retryable failures, register all screens for both roles, log sync errors. Swagger/OpenAPI: add Swashbuckle with JWT bearer security definition, add ProducesResponseType attributes to key endpoints. Includes AUDIT-REPORT.md with complete findings and CLAUDE.md project instructions.
69 lines
2.6 KiB
C#
69 lines
2.6 KiB
C#
using System.Security.Claims;
|
|
using System.Security.Cryptography;
|
|
using System.Text;
|
|
|
|
namespace ProposalSystem.Api.Middleware;
|
|
|
|
public class InternalApiKeyMiddleware
|
|
{
|
|
private static readonly string[] AllowedPathPrefixes =
|
|
[
|
|
"/api/proposals",
|
|
"/api/vendor-proposals",
|
|
"/api/generated-pdfs",
|
|
"/api/files",
|
|
];
|
|
|
|
private readonly RequestDelegate _next;
|
|
private readonly byte[] _apiKeyBytes;
|
|
private readonly ILogger<InternalApiKeyMiddleware> _logger;
|
|
|
|
public InternalApiKeyMiddleware(RequestDelegate next, IConfiguration configuration, ILogger<InternalApiKeyMiddleware> logger)
|
|
{
|
|
_next = next;
|
|
_logger = logger;
|
|
var key = configuration["INTERNAL_API_KEY"] ?? "";
|
|
_apiKeyBytes = Encoding.UTF8.GetBytes(key);
|
|
}
|
|
|
|
public async Task InvokeAsync(HttpContext context)
|
|
{
|
|
if (_apiKeyBytes.Length > 0 &&
|
|
context.Request.Headers.TryGetValue("X-Internal-Api-Key", out var providedKey) &&
|
|
!string.IsNullOrEmpty(providedKey.ToString()))
|
|
{
|
|
var providedBytes = Encoding.UTF8.GetBytes(providedKey.ToString());
|
|
if (!CryptographicOperations.FixedTimeEquals(providedBytes, _apiKeyBytes))
|
|
{
|
|
_logger.LogWarning("Invalid internal API key from {RemoteIp} on {Path}",
|
|
context.Connection.RemoteIpAddress, context.Request.Path);
|
|
context.Response.StatusCode = 401;
|
|
return;
|
|
}
|
|
|
|
var path = context.Request.Path.Value ?? "";
|
|
if (!AllowedPathPrefixes.Any(prefix => path.StartsWith(prefix, StringComparison.OrdinalIgnoreCase)))
|
|
{
|
|
_logger.LogWarning("Internal API key used on disallowed path {Path} from {RemoteIp}",
|
|
context.Request.Path, context.Connection.RemoteIpAddress);
|
|
context.Response.StatusCode = 403;
|
|
return;
|
|
}
|
|
|
|
var claims = new[]
|
|
{
|
|
new Claim(ClaimTypes.NameIdentifier, "system"),
|
|
new Claim("sub", "system-lambda-caller"),
|
|
new Claim(ClaimTypes.Email, "system@proposal-system.internal"),
|
|
new Claim("email", "system@proposal-system.internal"),
|
|
new Claim("name", "System"),
|
|
new Claim(ClaimTypes.Role, "admins"),
|
|
new Claim("cognito:groups", "admins"),
|
|
};
|
|
var identity = new ClaimsIdentity(claims, "InternalApiKey");
|
|
context.User = new ClaimsPrincipal(identity);
|
|
}
|
|
|
|
await _next(context);
|
|
}
|
|
}
|