mirror of
https://github.com/Sea-Haven-Industries/proposal-system.git
synced 2026-10-01 14:03:13 +00:00
Some checks failed
Deploy / Deploy to AWS (push) Has been cancelled
## Summary Implements Phase 3 of the AUDIT-2026-05-20 findings: - 29 FIX-severity items across API, web, infra, and lambdas - 7 accessibility NITs (aria-labels, document titles) - 4 code quality NITs (deduplication, constants extraction) Key changes: - API: N+1 fix, pagination clamping, idempotent transitions, upload confirm endpoint, revision TotalBidAmount carry-forward - Web: confirmation dialogs, currency formatting, error states, date range filters, document titles - Infra: S3 CORS lockdown, API Gateway throttling, AOSS network policy fix, CI concurrency - Lambdas: skip empty suggestions, remove status side-effect - Scripts: post-deploy health check ## Test plan - [x] tsc --noEmit (web + infra) - [x] dotnet build (api) - [x] ruff check + format (lambdas) - [x] Cross-review via orchestrator (no blockers) [skip deploy]
161 lines
5.4 KiB
C#
161 lines
5.4 KiB
C#
using System.Text.Json;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using ProposalSystem.Application.DTOs;
|
|
using ProposalSystem.Application.Interfaces;
|
|
using ProposalSystem.Domain.Entities;
|
|
using ProposalSystem.Infrastructure.Data;
|
|
|
|
namespace ProposalSystem.Api.Controllers;
|
|
|
|
[ApiController]
|
|
[Route("api/proposals/{proposalId:guid}")]
|
|
[Authorize]
|
|
public class FilesController : ControllerBase
|
|
{
|
|
private readonly ProposalDbContext _db;
|
|
private readonly IS3Service _s3;
|
|
private readonly IJobPublisher _jobPublisher;
|
|
private readonly IAuditService _audit;
|
|
private readonly IConfiguration _config;
|
|
|
|
public FilesController(
|
|
ProposalDbContext db,
|
|
IS3Service s3,
|
|
IJobPublisher jobPublisher,
|
|
IAuditService audit,
|
|
IConfiguration config)
|
|
{
|
|
_db = db;
|
|
_s3 = s3;
|
|
_jobPublisher = jobPublisher;
|
|
_audit = audit;
|
|
_config = config;
|
|
}
|
|
|
|
[HttpPost("attachments")]
|
|
public async Task<ActionResult<PresignedUploadResponse>> UploadAttachment(
|
|
Guid proposalId,
|
|
[FromQuery] string fileName,
|
|
[FromQuery] string? vendorName,
|
|
CancellationToken ct)
|
|
{
|
|
var proposal = await _db.Proposals.FindAsync(new object[] { proposalId }, ct);
|
|
if (proposal == null) return NotFound();
|
|
|
|
var extension = Path.GetExtension(fileName).ToLowerInvariant();
|
|
if (extension != ".pdf")
|
|
return BadRequest(new { error = "Only PDF files are accepted" });
|
|
|
|
var s3Key = $"vendors/{proposalId}/{Guid.NewGuid()}{extension}";
|
|
var bucket = _config["UPLOADS_BUCKET"]!;
|
|
|
|
var url = await _s3.GeneratePresignedUploadUrlAsync(bucket, s3Key, "application/pdf");
|
|
|
|
var vendorProposal = new VendorProposal
|
|
{
|
|
Id = Guid.NewGuid(),
|
|
ProposalId = proposalId,
|
|
VendorName = vendorName ?? string.Empty,
|
|
FileName = fileName,
|
|
S3Key = s3Key,
|
|
UploadedAt = DateTime.UtcNow,
|
|
ProcessingStatus = ProcessingStatus.Pending,
|
|
};
|
|
|
|
_db.VendorProposals.Add(vendorProposal);
|
|
await _db.SaveChangesAsync(ct);
|
|
|
|
return Ok(new PresignedUploadResponse(url, s3Key, DateTime.UtcNow.AddMinutes(15), vendorProposal.Id));
|
|
}
|
|
|
|
[HttpPost("attachments/{vendorProposalId:guid}/confirm")]
|
|
public async Task<ActionResult> ConfirmUpload(
|
|
Guid proposalId,
|
|
Guid vendorProposalId,
|
|
CancellationToken ct)
|
|
{
|
|
var vendorProposal = await _db.VendorProposals
|
|
.FirstOrDefaultAsync(v => v.Id == vendorProposalId && v.ProposalId == proposalId, ct);
|
|
if (vendorProposal == null) return NotFound();
|
|
|
|
if (vendorProposal.ProcessingStatus != ProcessingStatus.Pending)
|
|
return Ok();
|
|
|
|
await _jobPublisher.PublishAsync("pdf-extract", new
|
|
{
|
|
proposalId,
|
|
s3Key = vendorProposal.S3Key,
|
|
vendorProposalId = vendorProposal.Id,
|
|
}, ct);
|
|
|
|
return Ok();
|
|
}
|
|
|
|
[HttpGet("pdf")]
|
|
[Authorize(Roles = "admins,sysadmins")]
|
|
public async Task<ActionResult<PdfDownloadResponse>> GetPdf(Guid proposalId, CancellationToken ct)
|
|
{
|
|
var pdf = await _db.GeneratedPdfs
|
|
.Where(p => p.ProposalId == proposalId)
|
|
.OrderByDescending(p => p.Revision)
|
|
.FirstOrDefaultAsync(ct);
|
|
|
|
if (pdf == null)
|
|
{
|
|
await _jobPublisher.PublishAsync("pdf-generate", new { proposalId }, ct);
|
|
return Accepted(new { message = "PDF generation queued" });
|
|
}
|
|
|
|
var bucket = _config["GENERATED_BUCKET"]!;
|
|
var url = await _s3.GeneratePresignedDownloadUrlAsync(bucket, pdf.S3Key, 60);
|
|
|
|
await _audit.LogAsync(AuditAction.Download, proposalId, $"Downloaded rev {pdf.Revision}", ct);
|
|
|
|
return Ok(new PdfDownloadResponse(url, DateTime.UtcNow.AddMinutes(60)));
|
|
}
|
|
|
|
[HttpGet("pdf/{revision:int}")]
|
|
[Authorize(Roles = "admins,sysadmins")]
|
|
public async Task<ActionResult<PdfDownloadResponse>> GetPdfRevision(
|
|
Guid proposalId,
|
|
int revision,
|
|
CancellationToken ct)
|
|
{
|
|
var pdf = await _db.GeneratedPdfs
|
|
.FirstOrDefaultAsync(p => p.ProposalId == proposalId && p.Revision == revision, ct);
|
|
|
|
if (pdf == null) return NotFound();
|
|
|
|
var bucket = _config["GENERATED_BUCKET"]!;
|
|
var url = await _s3.GeneratePresignedDownloadUrlAsync(bucket, pdf.S3Key, 60);
|
|
|
|
await _audit.LogAsync(AuditAction.Download, proposalId, $"Downloaded rev {revision}", ct);
|
|
|
|
return Ok(new PdfDownloadResponse(url, DateTime.UtcNow.AddMinutes(60)));
|
|
}
|
|
|
|
[HttpGet("vendors")]
|
|
[Authorize(Roles = "admins,sysadmins")]
|
|
public async Task<ActionResult<IReadOnlyList<VendorProposalResponse>>> GetVendors(
|
|
Guid proposalId,
|
|
CancellationToken ct)
|
|
{
|
|
var entities = await _db.VendorProposals
|
|
.Where(v => v.ProposalId == proposalId)
|
|
.OrderByDescending(v => v.UploadedAt)
|
|
.ToListAsync(ct);
|
|
|
|
var vendors = entities.Select(v => new VendorProposalResponse(
|
|
v.Id,
|
|
v.VendorName,
|
|
v.FileName,
|
|
v.TotalVendorCost,
|
|
v.ProcessingStatus.ToString(),
|
|
string.IsNullOrEmpty(v.ExtractedData) ? null : JsonSerializer.Deserialize<object>(v.ExtractedData)
|
|
)).ToList();
|
|
|
|
return Ok(vendors);
|
|
}
|
|
}
|