mirror of
https://github.com/Sea-Haven-Industries/proposal-system.git
synced 2026-10-06 22:52:02 +00:00
4f1271eb50
6-domain audit (API, web, mobile, lambdas, infra, QA) with fixes: API security: scope internal API key middleware to allowed paths only, return 401 on invalid key instead of falling through, remove unvalidated JWT code path, sanitize error messages, add UpdateProposal validator, remove status field from UpdateProposalRequest to prevent over-posting, log swallowed exceptions in ProposalService. Infrastructure: enforce SSL on all S3 buckets, encrypt SQS queues, enable optional MFA on Cognito, add API Gateway access logging. Lambdas: fix _retry_request undefined variable across all 4 Lambdas, re-raise exceptions in pdf-extract/pdf-generate instead of swallowing, add idempotency guard to suggestions Lambda. Web: add ErrorBoundary, add auth loading state to ProtectedRoute, add mutation error toasts in AdminWorkspace, fix dead Cognito link. Mobile: add mutex to offline queue processing, distinguish permanent vs retryable failures, register all screens for both roles, log sync errors. Swagger/OpenAPI: add Swashbuckle with JWT bearer security definition, add ProducesResponseType attributes to key endpoints. Includes AUDIT-REPORT.md with complete findings and CLAUDE.md project instructions.
92 lines
2.9 KiB
C#
92 lines
2.9 KiB
C#
using System.Net;
|
|
using System.Text.Json;
|
|
using FluentValidation;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
|
|
namespace ProposalSystem.Api.Middleware;
|
|
|
|
public class GlobalExceptionHandler : IMiddleware
|
|
{
|
|
private readonly ILogger<GlobalExceptionHandler> _logger;
|
|
|
|
public GlobalExceptionHandler(ILogger<GlobalExceptionHandler> logger)
|
|
{
|
|
_logger = logger;
|
|
}
|
|
|
|
public async Task InvokeAsync(HttpContext context, RequestDelegate next)
|
|
{
|
|
try
|
|
{
|
|
await next(context);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
await HandleExceptionAsync(context, ex);
|
|
}
|
|
}
|
|
|
|
private async Task HandleExceptionAsync(HttpContext context, Exception exception)
|
|
{
|
|
var (statusCode, problemDetails) = exception switch
|
|
{
|
|
ValidationException validationEx => (
|
|
HttpStatusCode.BadRequest,
|
|
new ProblemDetails
|
|
{
|
|
Status = 400,
|
|
Title = "Validation Error",
|
|
Detail = string.Join("; ", validationEx.Errors.Select(e => e.ErrorMessage)),
|
|
}
|
|
),
|
|
KeyNotFoundException => (
|
|
HttpStatusCode.NotFound,
|
|
new ProblemDetails
|
|
{
|
|
Status = 404,
|
|
Title = "Not Found",
|
|
Detail = "The requested resource was not found",
|
|
}
|
|
),
|
|
UnauthorizedAccessException => (
|
|
HttpStatusCode.Unauthorized,
|
|
new ProblemDetails
|
|
{
|
|
Status = 401,
|
|
Title = "Unauthorized",
|
|
Detail = "Authentication required",
|
|
}
|
|
),
|
|
InvalidOperationException => (
|
|
HttpStatusCode.BadRequest,
|
|
new ProblemDetails
|
|
{
|
|
Status = 400,
|
|
Title = "Invalid Operation",
|
|
Detail = "The requested operation is not valid for the current state",
|
|
}
|
|
),
|
|
_ => (
|
|
HttpStatusCode.InternalServerError,
|
|
new ProblemDetails
|
|
{
|
|
Status = 500,
|
|
Title = "Internal Server Error",
|
|
Detail = "An unexpected error occurred",
|
|
}
|
|
),
|
|
};
|
|
|
|
_logger.LogError(exception, "Exception on {Method} {Path}: {Status}",
|
|
context.Request.Method, context.Request.Path, (int)statusCode);
|
|
|
|
context.Response.StatusCode = (int)statusCode;
|
|
context.Response.ContentType = "application/problem+json";
|
|
|
|
await context.Response.WriteAsync(
|
|
JsonSerializer.Serialize(problemDetails, new JsonSerializerOptions
|
|
{
|
|
PropertyNamingPolicy = JsonNamingPolicy.CamelCase,
|
|
}));
|
|
}
|
|
}
|