proposal-system

adam/proposal-system

Fork 0

mirror of https://github.com/Sea-Haven-Industries/proposal-system.git synced 2026-10-07 16:18:57 +00:00

Commit graph

Author	SHA1	Message	Date
Adam Moussa	8dc8f7814b	feat(contracts): adopt shared api-contracts in web, add zod schemas and ProblemDetails codes Closes WEB-M5 (web hand-duplicated wire types, standing drift risk): - shared/api-contracts: rewritten as the authoritative superset of the .NET DTOs (ProposalListItem/ProposalDetail with poNumber and submittedByName, line item requests, customers, pricing library, dashboard, audit, sites, auth, presigned upload, ApiProblem); stale Proposal/UpdateLineItemsRequest shapes removed - shared/api-contracts/src/schemas.ts: zod runtime schemas coupled to every wire type via `satisfies z.ZodType<T>` (schema/type drift is now a compile error); separate entrypoint so type-only consumers (mobile) never pull zod - web: imports @proposal-system/api-contracts (file: dep + tsconfig paths + vite preserveSymlinks); all 7 lib/api modules re-export shared types so page imports stay stable; enum unions tightened (PricingLibraryPage form state now ServiceCategory-typed) - fix(web): customer create/update sent a singular `address` field the API silently dropped (contract is addresses: string[], CustomerDtos.cs) - addresses now round-trip, extra addresses preserved on edit - api: ProblemDetails responses carry a machine-readable top-level `code` (SHOC error-code vocabulary): ValidationFailed, InvalidStateTransition, NotFound, Unauthorized, InternalError; new BusinessRuleException(code, message) maps to 422 with its code; GlobalExceptionHandlerTests cover the full mapping (wire contract) Cross-checked .NET DTOs vs TS types vs zod schemas with the orchestrator scanner (Gemini): core domains consistent; internal-only DTOs (FileDtos vendor/lambda surface, SimilarProposalDtos, UserDtos admin surface) intentionally uncovered. Verify: dotnet 166/166, web tsc + vitest 26/26 + build, mobile tsc, shared tsc all green.	2026-07-13 17:19:42 -04:00
Adam Moussa	dd058f7170	build(deps): combine open Dependabot updates into one PR Consolidates the 15 open Dependabot PRs (#195–#209) into a single branch. Python (lambdas): - boto3 -> >=1.43.43,<2.0 in suggestions, library-ingest, pdf-generate, pdf-extract, aurora-pgvector-init (#203, #205, #206, #208, #204) - tests: pytest >=9.1.1 (#198, major), pytest-mock >=3.15.1 (#197), moto >=5.2.2 (#200), httpx >=0.28.1 (#195) npm: - infra: @types/node ^25.9.5 (#196), typescript ~7.0.2 (#199, major) - web: vitest ^4.1.10 (#202), typescript ~7.0.2 (#207, major) - shared/api-contracts: typescript ~7.0.2 (#201, major) Ruby (mobile): - bundler group: cocoapods 1.17.0, fastlane 2.237.0 + transitive (#209) Note: TypeScript 5.7 -> 7.0.2 and pytest 8 -> 9.1.1 are major bumps; relying on CI to validate.	2026-07-08 16:46:43 -04:00
Adam Moussa	5d84399a0d	feat: pricing library — curated priced items feed the RAG corpus (#127 ) Some checks are pending Deploy / Deploy to AWS (push) Waiting to run Details Adds a managed pricing library so admins can seed/curate reference priced items directly, instead of the corpus being populated only by ingesting Sent proposals. v1 PR5. API: - PricingLibraryItem entity + migration; /api/pricing-library CRUD (admin), with GET {id} reachable by internal Lambda callers (admins role via internal key). - Create/update publish an ADDITIVE library-ingest SQS job {pricingLibraryItemId}, wrapped so a publish failure never rolls back the save. Lambda (library-ingest): - Additive event-shape branch: pricingLibraryItemId -> fetch item, format markdown, upload to pricing-library/{category}/{id}.md, trigger KB sync. The existing proposalId path is byte-for-byte unchanged. Explicit error when neither id present; warns when both present. Web: - Pricing Library management page (/admin/pricing-library): list / create / edit / delete. GPT-4.1 cross-review on the event-shape change: no BLOCK (neither/both-id handling applied). Verified: api 159 tests; web tsc + 26 tests; lambdas ruff + 37 pytest.	2026-06-18 12:49:47 -04:00

Author

SHA1

Message

Date

Adam Moussa

8dc8f7814b

feat(contracts): adopt shared api-contracts in web, add zod schemas and ProblemDetails codes

Closes WEB-M5 (web hand-duplicated wire types, standing drift risk):

- shared/api-contracts: rewritten as the authoritative superset of the
  .NET DTOs (ProposalListItem/ProposalDetail with poNumber and
  submittedByName, line item requests, customers, pricing library,
  dashboard, audit, sites, auth, presigned upload, ApiProblem); stale
  Proposal/UpdateLineItemsRequest shapes removed
- shared/api-contracts/src/schemas.ts: zod runtime schemas coupled to
  every wire type via `satisfies z.ZodType<T>` (schema/type drift is now
  a compile error); separate entrypoint so type-only consumers (mobile)
  never pull zod
- web: imports @proposal-system/api-contracts (file: dep + tsconfig
  paths + vite preserveSymlinks); all 7 lib/api modules re-export shared
  types so page imports stay stable; enum unions tightened
  (PricingLibraryPage form state now ServiceCategory-typed)
- fix(web): customer create/update sent a singular `address` field the
  API silently dropped (contract is addresses: string[], CustomerDtos.cs)
  - addresses now round-trip, extra addresses preserved on edit
- api: ProblemDetails responses carry a machine-readable top-level
  `code` (SHOC error-code vocabulary): ValidationFailed,
  InvalidStateTransition, NotFound, Unauthorized, InternalError; new
  BusinessRuleException(code, message) maps to 422 with its code;
  GlobalExceptionHandlerTests cover the full mapping (wire contract)

Cross-checked .NET DTOs vs TS types vs zod schemas with the
orchestrator scanner (Gemini): core domains consistent; internal-only
DTOs (FileDtos vendor/lambda surface, SimilarProposalDtos, UserDtos
admin surface) intentionally uncovered.

Verify: dotnet 166/166, web tsc + vitest 26/26 + build, mobile tsc,
shared tsc all green.

2026-07-13 17:19:42 -04:00

Adam Moussa

dd058f7170

build(deps): combine open Dependabot updates into one PR

Consolidates the 15 open Dependabot PRs (#195–#209) into a single branch.

Python (lambdas):
- boto3 -> >=1.43.43,<2.0 in suggestions, library-ingest, pdf-generate,
  pdf-extract, aurora-pgvector-init (#203, #205, #206, #208, #204)
- tests: pytest >=9.1.1 (#198, major), pytest-mock >=3.15.1 (#197),
  moto >=5.2.2 (#200), httpx >=0.28.1 (#195)

npm:
- infra: @types/node ^25.9.5 (#196), typescript ~7.0.2 (#199, major)
- web: vitest ^4.1.10 (#202), typescript ~7.0.2 (#207, major)
- shared/api-contracts: typescript ~7.0.2 (#201, major)

Ruby (mobile):
- bundler group: cocoapods 1.17.0, fastlane 2.237.0 + transitive (#209)

Note: TypeScript 5.7 -> 7.0.2 and pytest 8 -> 9.1.1 are major bumps;
relying on CI to validate.

2026-07-08 16:46:43 -04:00

Adam Moussa

5d84399a0d

feat: pricing library — curated priced items feed the RAG corpus (#127 )

Deploy / Deploy to AWS (push) Waiting to run

Details

Adds a managed pricing library so admins can seed/curate reference priced items
directly, instead of the corpus being populated only by ingesting Sent proposals.
v1 PR5.

API:
- PricingLibraryItem entity + migration; /api/pricing-library CRUD (admin), with
  GET {id} reachable by internal Lambda callers (admins role via internal key).
- Create/update publish an ADDITIVE library-ingest SQS job {pricingLibraryItemId},
  wrapped so a publish failure never rolls back the save.

Lambda (library-ingest):
- Additive event-shape branch: pricingLibraryItemId -> fetch item, format markdown,
  upload to pricing-library/{category}/{id}.md, trigger KB sync. The existing
  proposalId path is byte-for-byte unchanged. Explicit error when neither id present;
  warns when both present.

Web:
- Pricing Library management page (/admin/pricing-library): list / create / edit / delete.

GPT-4.1 cross-review on the event-shape change: no BLOCK (neither/both-id handling
applied). Verified: api 159 tests; web tsc + 26 tests; lambdas ruff + 37 pytest.

2026-06-18 12:49:47 -04:00

3 commits