adam/proposal-system
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/proposal-system.git synced 2026-10-04 20:42:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix nested tbody in proposal tables: use Fragment instead of Box component="tbody"

Browse source
This commit is contained in:
Adam Moussa 2026-05-22 18:09:42 -04:00
parent b43bb64fff
commit 83e1a7948e
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
web/src/pages/admin/dashboard/AdminDashboard.tsx
View file

@ -1,4 +1,4 @@
import { useMemo, useState } from 'react'; import { useMemo, useState, Fragment } from 'react';
import { useNavigate } from 'react-router-dom'; import { useNavigate } from 'react-router-dom';
import { useQuery } from '@tanstack/react-query'; import { useQuery } from '@tanstack/react-query';
import { import {
@ -336,7 +336,7 @@ export default function AdminDashboard({ defaultStatus }: { defaultStatus?: stri
: grouped.map((group) => { : grouped.map((group) => {
const isExpanded = expanded.has(group.baseNumber); const isExpanded = expanded.has(group.baseNumber);
return ( return (
<Box component="tbody" key={group.baseNumber}> <Fragment key={group.baseNumber}>
{renderRow(group.latest, false, group.hasRevisions, isExpanded, group.baseNumber)} {renderRow(group.latest, false, group.hasRevisions, isExpanded, group.baseNumber)}
{group.hasRevisions && ( {group.hasRevisions && (
<TableRow> <TableRow>
@ -353,7 +353,7 @@ export default function AdminDashboard({ defaultStatus }: { defaultStatus?: stri
</TableCell> </TableCell>
</TableRow> </TableRow>
)} )}
</Box> </Fragment>
); );
})} })}
{!loading && rows.length === 0 && ( {!loading && rows.length === 0 && (

6
web/src/pages/proposals/list/ProposalListPage.tsx
View file

@ -1,4 +1,4 @@
import { useState, useMemo } from 'react'; import { useState, useMemo, Fragment } from 'react';
import { useNavigate } from 'react-router-dom'; import { useNavigate } from 'react-router-dom';
import { import {
Box, Box,
@ -275,7 +275,7 @@ export default function ProposalListPage() {
: grouped.map((group) => { : grouped.map((group) => {
const isExpanded = expanded.has(group.baseNumber); const isExpanded = expanded.has(group.baseNumber);
return ( return (
<Box component="tbody" key={group.baseNumber}> <Fragment key={group.baseNumber}>
{renderRow(group.latest, false, group.hasRevisions, isExpanded, group.baseNumber)} {renderRow(group.latest, false, group.hasRevisions, isExpanded, group.baseNumber)}
{group.hasRevisions && ( {group.hasRevisions && (
<TableRow> <TableRow>
@ -292,7 +292,7 @@ export default function ProposalListPage() {
</TableCell> </TableCell>
</TableRow> </TableRow>
)} )}
</Box> </Fragment>
); );
})} })}
{!loading && rows.length === 0 && ( {!loading && rows.length === 0 && (