procurement-ingest/tests/support/__init__.py
Adam Moussa ff368beaa4
test: consolidate test roots — one loader, shared support, enforced CI floor (phase 8) (#118)
* test: consolidate test roots — one repo-root loader, shared support package, missing-scenario suites, enforced ruff/coverage floor (refactor phase 8)

tests/conftest.py only loads for the tests/ root, not a standalone
`pytest lambdas/po/email_processor/tests` run, so it could never carry
session invariants like the dummy AWS env or the moto stubber
registration. Add a single repo-root conftest.py (pytest.ini pins
rootdir there, so it loads for every invocation) that sets the dummy
AWS credentials/region, imports moto BEFORE any handler module so
boto3 sessions pick up its stubber hook (carrying the explanatory
comment verbatim from the old _po_parser_support.py), and exposes one
load_lambda_module(pipeline, name) — the sys.modules save/restore
dance stays, since template_parser is still a duplicated bare name
across pipelines needing per-exec sibling binding.

Add tests/support/ as the shared package both pipelines' local
_*_parser_support.py modules delegate to: a superset FakeTable (PO's
update_item recording + WO's put_item and keyed single-row store),
FakeDynamoResource, load_email, and load_golden with parse_float=Decimal
kept (load-bearing for exact money comparison at PO magnitudes — WO's
prior load_golden had no parse_float and must not regress PO by losing
it). Rewrite _wo_parser_support.py off the bare `import handler` /
`from handler import parse_raw_email` strategy that was the source of
the bare-name sys.modules collision the other two loaders defend
against.

Move test_po_merge.py and test_pad_zip.py into
lambdas/po/email_processor/tests/ (PO-specific, belongs beside the
code) via git mv so history follows; test_parse_raw_email.py and
test_ses_auth.py stay at the repo root since they're genuinely
cross-pipeline, parameterized over both handlers. Delete
tests/test_local.py: it globs a nonexistent samples/ dir, is WO-only,
and imports a handler at collection time, bypassing the loader gate
entirely — the golden suites already cover its role. Its pytest.ini
exclusion comment goes with it.

New scenario coverage, all built on the single loader + support
package:
- PO+WO Bedrock transport errors (ThrottlingException, missing
  'content' key, empty content list, non-JSON model text), asserting
  PO's pre-call ai_fallback metric survives with no partial write and
  the exception propagates; WO's no-datapoint-on-throttle behavior is
  pinned with a documenting test rather than "fixed" by reordering.
- Handler-level SES-auth reject seam per pipeline: no auth
  monkeypatch + empty ALLOWED_DKIM_DOMAINS asserts zero Bedrock calls,
  zero writes, no raise — closing the hole where deleting the gate
  line today still passes every test.
- web_ui coverage for both PO and WO (0% before this): fail-closed on
  unset ARN and on a Secrets Manager exception, TTL cache refresh,
  Bearer/X-Auth-Token/header-case-insensitivity, wrong-token 401 with
  no table scan, non-ASCII token, and a hostile-field-escaping
  regression lock. PO web_ui has no __init__.py, so these go through
  the loader rather than package imports.
- A moto-backed mirror of test_po_merge for WO merge semantics
  (table 'WorkOrders'): null-status never clobbers wo_status,
  created_at immutable via if_not_exists, status->wo_status mapping,
  None fields absent from SET, record_type only-when-present.
- Small pins: the PO-DC-02 64-char EMF clamp regression and
  per-pipeline multi-record failure-isolation (all-or-retry contract).
  The reprocess.py synthetic-event-shape contract test already landed
  in Phase 7, so it isn't duplicated here.

Two WO product-code fixes ride along, since this is the phase that
exercises them: (a) the invalid_status reason-code fix in
template_parser.py's status check, which previously returned
malformed_site_code for the same failure validate_ai_fallback already
labels invalid_status, making one failure surface two codes depending
on path (grepped the dashboards/metric filters for
malformed_site_code first — no external references found, safe to
diverge the two codes); (b) wrapping the WO Bedrock call in
handler.py so a transport failure emits ai_fallback/bedrock_error in
an except-and-reraise. This is deliberately not a naive reorder: the
emit sits in the except block, not pre-call, so a gate-rejected email
still emits only ai_fallback_rejected and wo_stack's "a rejected
email emits nothing else" alarm contract doesn't double-count. A test
computes the emitted series by hand to pin the no-double-count
behavior. Neither change touches the handler event/return contract.

_validate_new_po_values in the PO template_parser.py is split into
per-rule helpers, and the V4 anchor-frame dataclass now carries
summary_matches/price so V13 can consume them; extract_new_po
(C901=35) is included in the split. Add ruff.toml enabling C901/PLR
so the mccabe/complexity suppressions scattered through the tree stop
being decorative; derived_fields.py is under the shadow-bake freeze
so its violations are silenced via a per-file ignore with a
justification comment instead of an in-file edit, and the handful of
other pre-existing violations surfaced by turning the config on get
the same per-file-ignore treatment with a reason, or a fix where the
file isn't frozen. scripts/ is added to the CI lint scope.

CI gains an explicit --cov module list (lambdas/po and wo
email_processor + web_ui, po/site_extractor, lambdas/shared) plus
--cov-fail-under=80, since web_ui and site_extractor lack __init__.py
markers and a bare --cov=lambdas silently skips them for the missing
package marker; .coveragerc omits the test dirs themselves from the
count. The Phase 0 AST bundle-consistency test stays in the standard
pytest run. .gitignore picks up the resulting .coverage data file.

docs/po-template-parser.md gets a small correction: the EXTRACTION_PROMPT
declares quantity/price as "number or null", not JSON strings, so
parse_float=Decimal already handles a conforming Bedrock response —
the doc previously implied the coercion path was the primary
mechanism rather than a defensive net for non-conforming responses.

* test: lock attribute-context quote escaping in web_ui hostile-field test

The escaping regression lock asserted only the element-context vector
(raw <script> absent, &lt;script&gt; present) while its docstring claimed
quotes were covered -- the payload's " and ' were never asserted on, so
a quote-escaping regression on the onclick row-link sink (attribute
breakout -> event-handler injection) would have passed green.
/sh-security-review finding WC-01 (confirmed medium, test-integrity).

Add assertions that the onclick sink's JSON string renders its opening
quote as &quot; (raw " after window.location= fails), that the
payload's quote characters appear only entity-escaped, and that the
raw payload never appears anywhere in the body. Mutation-verified: the
test now fails when the sink's quote-escaping is dropped.

* test: address Open SWE review — xfail the web_ui non-ASCII auth pin, document subset coverage-floor override

- tests/test_web_ui_auth.py: replace the TypeError characterization pin with an
  xfail(strict, raises=TypeError) asserting the DESIRED fail-closed (False)
  behavior. Documents the intended fix and auto-fails (xpass) once web_ui_auth is
  corrected, instead of requiring a passing test to be knowingly deleted. The
  module stays frozen this phase; the underlying hmac.compare_digest ASCII-only
  defect is tracked as a follow-up.
- pytest.ini: document that the aggregate 80% floor (enforced in CI via the
  reusable workflow's bare pytest) red-exits local subset runs by design, with the
  --cov-fail-under=0 override for iteration. Floor stays in addopts because the
  centralized ci-python-sam workflow exposes no per-run test command.
2026-07-20 16:19:15 -04:00

122 lines
4.2 KiB
Python

"""Shared offline test helpers for the procurement-ingest suite.
A real package (``tests.support``) resolved as a PEP-420 namespace member via
the repo-root conftest's sys.path insert. ``tests/`` itself gets NO __init__.py
(adding it would change pytest's module naming for the root suite).
This module imports NO moto, mutates NO environment, and imports NO handler at
module level -- the moto-before-handler ordering authority stays solely with the
repo-root conftest. The loader (which does exec handlers) is only invoked lazily
by ``load_email`` / by the pipeline shims, never at ``__init__`` import time.
"""
import io
import json
from decimal import Decimal
from tests.support.loader import REPO_ROOT, load_lambda_module
__all__ = [
"REPO_ROOT",
"load_lambda_module",
"FIXTURE_DIRS",
"stems",
"load_raw",
"load_email",
"load_golden",
"FakeTable",
"FakeDynamoResource",
"FakeS3",
]
FIXTURE_DIRS = {
"po": REPO_ROOT / "lambdas/po/email_processor/tests/fixtures",
"wo": REPO_ROOT / "lambdas/wo/email_processor/tests/fixtures",
}
def stems(pipeline, subdir):
"""Sorted list of fixture stems in ``<pipeline>/fixtures/<subdir>/*.eml``."""
return sorted(p.stem for p in (FIXTURE_DIRS[pipeline] / subdir).glob("*.eml"))
def load_raw(pipeline, subdir, stem):
"""Raw bytes of a fixture .eml."""
return (FIXTURE_DIRS[pipeline] / subdir / f"{stem}.eml").read_bytes()
def load_email(pipeline, subdir, stem):
"""Parse a fixture .eml into the email_data dict the parser consumes.
Uses the Phase-3 single-sourced ``email_parsing.parse_raw_email`` that BOTH
handlers re-export -- semantics identical to the old
``po_handler.parse_raw_email`` / bare ``from handler import parse_raw_email``
paths, now with one implementation.
"""
email_parsing = load_lambda_module("shared", "email_parsing")
return email_parsing.parse_raw_email(load_raw(pipeline, subdir, stem))
def load_golden(pipeline, stem):
"""Load the expected parser output for a positive fixture.
Goldens store money as JSON numbers; ``parse_float=Decimal`` mirrors the
handler's Bedrock decode and makes every golden money value compare exactly
equal to the parser's Decimal output (2-dp values at PO magnitudes round-trip
float repr losslessly). Applied UNCONDITIONALLY: WO goldens are integer-only
at the JSON-number level (verified: zero float-typed values across all 55 WO
goldens; decimal-looking strings occur only inside comment_text STRING
values, which parse_float never touches), so WO callers gain Decimal decoding
with no observable change.
"""
path = FIXTURE_DIRS[pipeline] / "expected" / f"{stem}.json"
with open(path) as fh:
return json.load(fh, parse_float=Decimal)
class FakeTable:
"""Superset offline DynamoDB table -- union of the PO and WO fakes.
PO callers only ever ``update_item`` (their ``puts``/``store`` stay
permanently empty); WO callers use ``put_item`` (recorded in ``puts`` and in
the keyed single-row ``store``) AND ``update_item``. Neither suite regresses:
each sees exactly the recorder it used before.
"""
def __init__(self, name):
self.name = name
self.puts = []
self.updates = []
# Single-row-per-key store (WO): detects overwrite vs distinct rows.
self.store = {}
def put_item(self, Item=None, **kwargs): # noqa: N803 (boto3 kwarg name)
self.puts.append(Item)
key = (Item.get("work_order_id"), Item.get("comment_id"))
self.store[key] = Item
def update_item(self, **kwargs):
self.updates.append(kwargs)
class FakeDynamoResource:
def __init__(self):
self.tables = {}
def Table(self, name): # noqa: N802 (boto3 method name)
return self.tables.setdefault(name, FakeTable(name))
class FakeS3:
"""Offline S3 client for the handler-level seam tests.
The sender-auth gate sits AFTER ``get_object`` in both handlers, so a fake
S3 is mandatory to reach (and exercise) the gate. ``objects`` maps the S3
object Key to its raw bytes.
"""
def __init__(self, objects):
self.objects = dict(objects)
def get_object(self, Bucket, Key): # noqa: N803 (boto3 kwarg names)
return {"Body": io.BytesIO(self.objects[Key])}