mirror of
https://github.com/Sea-Haven-Industries/procurement-ingest.git
synced 2026-09-30 11:53:13 +00:00
* test: consolidate test roots — one repo-root loader, shared support package, missing-scenario suites, enforced ruff/coverage floor (refactor phase 8) tests/conftest.py only loads for the tests/ root, not a standalone `pytest lambdas/po/email_processor/tests` run, so it could never carry session invariants like the dummy AWS env or the moto stubber registration. Add a single repo-root conftest.py (pytest.ini pins rootdir there, so it loads for every invocation) that sets the dummy AWS credentials/region, imports moto BEFORE any handler module so boto3 sessions pick up its stubber hook (carrying the explanatory comment verbatim from the old _po_parser_support.py), and exposes one load_lambda_module(pipeline, name) — the sys.modules save/restore dance stays, since template_parser is still a duplicated bare name across pipelines needing per-exec sibling binding. Add tests/support/ as the shared package both pipelines' local _*_parser_support.py modules delegate to: a superset FakeTable (PO's update_item recording + WO's put_item and keyed single-row store), FakeDynamoResource, load_email, and load_golden with parse_float=Decimal kept (load-bearing for exact money comparison at PO magnitudes — WO's prior load_golden had no parse_float and must not regress PO by losing it). Rewrite _wo_parser_support.py off the bare `import handler` / `from handler import parse_raw_email` strategy that was the source of the bare-name sys.modules collision the other two loaders defend against. Move test_po_merge.py and test_pad_zip.py into lambdas/po/email_processor/tests/ (PO-specific, belongs beside the code) via git mv so history follows; test_parse_raw_email.py and test_ses_auth.py stay at the repo root since they're genuinely cross-pipeline, parameterized over both handlers. Delete tests/test_local.py: it globs a nonexistent samples/ dir, is WO-only, and imports a handler at collection time, bypassing the loader gate entirely — the golden suites already cover its role. Its pytest.ini exclusion comment goes with it. New scenario coverage, all built on the single loader + support package: - PO+WO Bedrock transport errors (ThrottlingException, missing 'content' key, empty content list, non-JSON model text), asserting PO's pre-call ai_fallback metric survives with no partial write and the exception propagates; WO's no-datapoint-on-throttle behavior is pinned with a documenting test rather than "fixed" by reordering. - Handler-level SES-auth reject seam per pipeline: no auth monkeypatch + empty ALLOWED_DKIM_DOMAINS asserts zero Bedrock calls, zero writes, no raise — closing the hole where deleting the gate line today still passes every test. - web_ui coverage for both PO and WO (0% before this): fail-closed on unset ARN and on a Secrets Manager exception, TTL cache refresh, Bearer/X-Auth-Token/header-case-insensitivity, wrong-token 401 with no table scan, non-ASCII token, and a hostile-field-escaping regression lock. PO web_ui has no __init__.py, so these go through the loader rather than package imports. - A moto-backed mirror of test_po_merge for WO merge semantics (table 'WorkOrders'): null-status never clobbers wo_status, created_at immutable via if_not_exists, status->wo_status mapping, None fields absent from SET, record_type only-when-present. - Small pins: the PO-DC-02 64-char EMF clamp regression and per-pipeline multi-record failure-isolation (all-or-retry contract). The reprocess.py synthetic-event-shape contract test already landed in Phase 7, so it isn't duplicated here. Two WO product-code fixes ride along, since this is the phase that exercises them: (a) the invalid_status reason-code fix in template_parser.py's status check, which previously returned malformed_site_code for the same failure validate_ai_fallback already labels invalid_status, making one failure surface two codes depending on path (grepped the dashboards/metric filters for malformed_site_code first — no external references found, safe to diverge the two codes); (b) wrapping the WO Bedrock call in handler.py so a transport failure emits ai_fallback/bedrock_error in an except-and-reraise. This is deliberately not a naive reorder: the emit sits in the except block, not pre-call, so a gate-rejected email still emits only ai_fallback_rejected and wo_stack's "a rejected email emits nothing else" alarm contract doesn't double-count. A test computes the emitted series by hand to pin the no-double-count behavior. Neither change touches the handler event/return contract. _validate_new_po_values in the PO template_parser.py is split into per-rule helpers, and the V4 anchor-frame dataclass now carries summary_matches/price so V13 can consume them; extract_new_po (C901=35) is included in the split. Add ruff.toml enabling C901/PLR so the mccabe/complexity suppressions scattered through the tree stop being decorative; derived_fields.py is under the shadow-bake freeze so its violations are silenced via a per-file ignore with a justification comment instead of an in-file edit, and the handful of other pre-existing violations surfaced by turning the config on get the same per-file-ignore treatment with a reason, or a fix where the file isn't frozen. scripts/ is added to the CI lint scope. CI gains an explicit --cov module list (lambdas/po and wo email_processor + web_ui, po/site_extractor, lambdas/shared) plus --cov-fail-under=80, since web_ui and site_extractor lack __init__.py markers and a bare --cov=lambdas silently skips them for the missing package marker; .coveragerc omits the test dirs themselves from the count. The Phase 0 AST bundle-consistency test stays in the standard pytest run. .gitignore picks up the resulting .coverage data file. docs/po-template-parser.md gets a small correction: the EXTRACTION_PROMPT declares quantity/price as "number or null", not JSON strings, so parse_float=Decimal already handles a conforming Bedrock response — the doc previously implied the coercion path was the primary mechanism rather than a defensive net for non-conforming responses. * test: lock attribute-context quote escaping in web_ui hostile-field test The escaping regression lock asserted only the element-context vector (raw <script> absent, <script> present) while its docstring claimed quotes were covered -- the payload's " and ' were never asserted on, so a quote-escaping regression on the onclick row-link sink (attribute breakout -> event-handler injection) would have passed green. /sh-security-review finding WC-01 (confirmed medium, test-integrity). Add assertions that the onclick sink's JSON string renders its opening quote as " (raw " after window.location= fails), that the payload's quote characters appear only entity-escaped, and that the raw payload never appears anywhere in the body. Mutation-verified: the test now fails when the sink's quote-escaping is dropped. * test: address Open SWE review — xfail the web_ui non-ASCII auth pin, document subset coverage-floor override - tests/test_web_ui_auth.py: replace the TypeError characterization pin with an xfail(strict, raises=TypeError) asserting the DESIRED fail-closed (False) behavior. Documents the intended fix and auto-fails (xpass) once web_ui_auth is corrected, instead of requiring a passing test to be knowingly deleted. The module stays frozen this phase; the underlying hmac.compare_digest ASCII-only defect is tracked as a follow-up. - pytest.ini: document that the aggregate 80% floor (enforced in CI via the reusable workflow's bare pytest) red-exits local subset runs by design, with the --cov-fail-under=0 override for iteration. Floor stays in addopts because the centralized ci-python-sam workflow exposes no per-run test command.
112 lines
4.4 KiB
Python
112 lines
4.4 KiB
Python
"""Repo-root pytest configuration -- the ONE loader of session invariants.
|
|
|
|
pytest's rootdir is pinned by pytest.ini at the repo root, so THIS conftest
|
|
loads for EVERY invocation, including a standalone
|
|
``pytest lambdas/po/email_processor/tests`` run: rootdir conftests load at
|
|
session start, before any collection import. ``tests/conftest.py`` is NOT an
|
|
ancestor of the pipeline test roots, which is exactly why it cannot carry the
|
|
session invariants below.
|
|
|
|
The Lambda handlers create boto3 clients lazily on first use, but the moto
|
|
stubber hook must still be registered before any client is ever constructed, so
|
|
this conftest sets the dummy AWS env and imports moto BEFORE anything loads a
|
|
handler.
|
|
"""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent
|
|
|
|
# The handlers build boto3 clients on first call; give boto3 a region and dummy
|
|
# credentials so client construction works offline / under CI regardless of the
|
|
# ambient environment.
|
|
import os # noqa: E402
|
|
|
|
os.environ.setdefault("AWS_DEFAULT_REGION", "us-east-1")
|
|
os.environ.setdefault("AWS_ACCESS_KEY_ID", "testing")
|
|
os.environ.setdefault("AWS_SECRET_ACCESS_KEY", "testing")
|
|
os.environ.setdefault("AWS_SESSION_TOKEN", "testing")
|
|
|
|
# Imported for its side effect and DELIBERATELY BEFORE the handler modules are
|
|
# loaded below: moto registers its botocore stubber hook into botocore's
|
|
# BUILTIN_HANDLERS at import time, and boto3 sessions only pick the hook up if
|
|
# they are created AFTER that registration. This conftest chain is imported at
|
|
# pytest session start -- before tests/test_po_merge.py gets a chance to import
|
|
# moto -- so without this import the handler's module-level boto3 clients would
|
|
# be created un-stubbable and the moto-backed suites would hit real AWS.
|
|
import moto # noqa: F401,E402
|
|
|
|
# Put the repo root on sys.path so ``tests.support`` resolves as a PEP-420
|
|
# namespace package from every invocation directory.
|
|
if str(REPO_ROOT) not in sys.path:
|
|
sys.path.insert(0, str(REPO_ROOT))
|
|
|
|
# The single loader lives in tests/support/loader.py; the root conftest exposes
|
|
# it (constraint 1). Re-exported rather than reimplemented -- `from conftest
|
|
# import ...` is unsafe with three conftest.py files across the roots.
|
|
from tests.support.loader import load_lambda_module # noqa: E402,F401
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def po_handler():
|
|
"""The PO email processor handler module."""
|
|
return load_lambda_module("po", "email_processor/handler")
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def wo_handler():
|
|
"""The WO email processor handler module."""
|
|
return load_lambda_module("wo", "email_processor/handler")
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def po_persistence(po_handler):
|
|
"""The PO persistence sibling (owns PO_TABLE + save_* after Phase 5).
|
|
|
|
load_lambda_module registers each sibling under ``<handler>__<sibling>`` in
|
|
sys.modules (only the bare-name binding is restored afterwards), so the
|
|
persistence module stays reachable here by its unique name. test_po_merge.py
|
|
keys its moto table on ``po_persistence.PO_TABLE`` rather than a literal.
|
|
"""
|
|
return sys.modules["po_email_processor_handler__persistence"]
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def po_enrichment(po_handler):
|
|
"""The PO enrichment sibling (owns pad_zip after Phase 5).
|
|
|
|
pad_zip is PURE and NOT re-exported by handler (handler's body never calls
|
|
it -- it runs inside enrich_parsed), so test_pad_zip.py dereferences it on
|
|
the owning module instead of po_handler.
|
|
"""
|
|
return sys.modules["po_email_processor_handler__enrichment"]
|
|
|
|
|
|
@pytest.fixture(scope="session")
|
|
def wo_persistence(wo_handler):
|
|
"""The WO persistence sibling (owns save_work_order / save_event).
|
|
|
|
Reachable by its unique sys.modules name for test_wo_merge symmetry with
|
|
po_persistence.
|
|
"""
|
|
return sys.modules["wo_email_processor_handler__persistence"]
|
|
|
|
|
|
@pytest.fixture(params=["po_handler", "wo_handler"])
|
|
def email_handler(request):
|
|
"""Parametrized fixture yielding each email processor handler module."""
|
|
return request.getfixturevalue(request.param)
|
|
|
|
|
|
@pytest.fixture
|
|
def ses_auth():
|
|
"""The single-sourced ses_auth module (lambdas/shared/, Phase 3).
|
|
|
|
Previously parameterized over the two per-pipeline copies to prove they
|
|
stayed byte-identical; now there is exactly one copy, so this loads it
|
|
once -- halving the test_ses_auth run.
|
|
"""
|
|
return load_lambda_module("shared", "ses_auth")
|