adam/procurement-ingest
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/procurement-ingest.git synced 2026-10-03 12:43:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix esc(None) TypeError and javascript: scheme in PO web UI

Browse source 
Coerce supplier name through `or ""` before escaping to handle
nested None from DynamoDB. Add scheme allowlist on view_order_url
to block javascript:/data: hrefs from LLM-extracted URLs.
This commit is contained in:
Adam Moussa 2026-05-12 14:49:04 -04:00
parent afcd0eabe2
commit b545bfed3d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lambdas/po/web_ui/handler.py
View file

@ -71,7 +71,7 @@ def render_po_detail(po):
("Email Type", render_badge(po.get("email_type", ""), EMAIL_TYPE_COLORS)), ("Email Type", render_badge(po.get("email_type", ""), EMAIL_TYPE_COLORS)),
("Total Amount", fmt_currency(po.get("total_amount"))), ("Total Amount", fmt_currency(po.get("total_amount"))),
("Currency", esc(po.get("currency", "")) or None), ("Currency", esc(po.get("currency", "")) or None),
("Supplier", esc((po.get("supplier") or {}).get("name", "")) or None), ("Supplier", esc((po.get("supplier") or {}).get("name") or "") or None),
("Site Code", esc(po.get("site_code", "")) or None), ("Site Code", esc(po.get("site_code", "")) or None),
("State", esc(po.get("state", "")) or None), ("State", esc(po.get("state", "")) or None),
("Trade", esc(po.get("trade", "")) or None), ("Trade", esc(po.get("trade", "")) or None),
@ -102,7 +102,7 @@ def render_po_detail(po):
fields.append(("Ship To", "<br>".join(ship_parts))) fields.append(("Ship To", "<br>".join(ship_parts)))
view_url = po.get("view_order_url") view_url = po.get("view_order_url")
if view_url: if view_url and view_url.startswith(("https://", "http://")):
escaped_url = esc(view_url, quote=True) escaped_url = esc(view_url, quote=True)
fields.append( fields.append(
( (