2026-04-07 12:12:30 -04:00
|
|
|
"""CDK stack for the Coupa PO email ingestion pipeline."""
|
|
|
|
|
|
|
|
|
|
import aws_cdk as cdk
|
|
|
|
|
from aws_cdk import (
|
|
|
|
|
Duration,
|
|
|
|
|
RemovalPolicy,
|
|
|
|
|
Stack,
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
aws_cloudwatch as cloudwatch,
|
|
|
|
|
aws_cloudwatch_actions as cw_actions,
|
2026-04-07 12:12:30 -04:00
|
|
|
aws_dynamodb as dynamodb,
|
2026-06-10 19:31:55 -04:00
|
|
|
aws_kms as kms,
|
2026-04-07 12:12:30 -04:00
|
|
|
aws_lambda as lambda_,
|
2026-04-30 14:26:53 -04:00
|
|
|
aws_lambda_event_sources as lambda_event_sources,
|
|
|
|
|
aws_logs as logs,
|
2026-04-07 12:12:30 -04:00
|
|
|
aws_s3 as s3,
|
|
|
|
|
aws_s3_notifications as s3n,
|
|
|
|
|
aws_ses as ses,
|
|
|
|
|
aws_ses_actions as ses_actions,
|
|
|
|
|
aws_secretsmanager as secretsmanager,
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
aws_sns as sns,
|
|
|
|
|
aws_sqs as sqs,
|
2026-06-10 19:31:55 -04:00
|
|
|
aws_ssm as ssm,
|
2026-04-07 12:12:30 -04:00
|
|
|
)
|
|
|
|
|
from constructs import Construct
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# Operations these tables actually issue (PutItem/UpdateItem/DeleteItem writes,
|
|
|
|
|
# GetItem/Query/BatchGetItem reads). DynamoDB emits ThrottledRequests/SystemErrors
|
|
|
|
|
# keyed by TableName + Operation only, so the CDK *_for_operations helpers (which
|
|
|
|
|
# render a SUM MathExpression across these per-operation metrics) are the correct,
|
|
|
|
|
# non-deprecated way to roll a table up to a single alarmable series.
|
|
|
|
|
_DDB_ALARM_OPERATIONS = [
|
|
|
|
|
dynamodb.Operation.GET_ITEM,
|
|
|
|
|
dynamodb.Operation.BATCH_GET_ITEM,
|
|
|
|
|
dynamodb.Operation.QUERY,
|
|
|
|
|
dynamodb.Operation.SCAN,
|
|
|
|
|
dynamodb.Operation.PUT_ITEM,
|
|
|
|
|
dynamodb.Operation.UPDATE_ITEM,
|
|
|
|
|
dynamodb.Operation.DELETE_ITEM,
|
|
|
|
|
dynamodb.Operation.BATCH_WRITE_ITEM,
|
|
|
|
|
]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def _add_ddb_alarms(scope, id_prefix, table, alarm_name_prefix, alarm_topic):
|
|
|
|
|
"""Add throttle + system-error alarms for a DynamoDB table.
|
|
|
|
|
|
|
|
|
|
Both fire on any non-zero datapoint in a 5-min window. ALARM-only SnsAction
|
|
|
|
|
to site-alerts (no OK action); TreatMissingData NOT_BREACHING.
|
|
|
|
|
"""
|
|
|
|
|
table.metric_throttled_requests_for_operations(
|
|
|
|
|
operations=_DDB_ALARM_OPERATIONS,
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
scope,
|
|
|
|
|
f"{id_prefix}ThrottlesAlarm",
|
|
|
|
|
alarm_name=f"{alarm_name_prefix}-throttles",
|
|
|
|
|
alarm_description=f"{alarm_name_prefix} DynamoDB throttled requests",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
|
|
|
|
table.metric_system_errors_for_operations(
|
|
|
|
|
operations=_DDB_ALARM_OPERATIONS,
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
scope,
|
|
|
|
|
f"{id_prefix}SystemErrorsAlarm",
|
|
|
|
|
alarm_name=f"{alarm_name_prefix}-system-errors",
|
|
|
|
|
alarm_description=f"{alarm_name_prefix} DynamoDB server-side (5xx) errors",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
2026-04-07 12:12:30 -04:00
|
|
|
|
|
|
|
|
class PoIngestStack(Stack):
|
|
|
|
|
def __init__(self, scope: Construct, construct_id: str, **kwargs):
|
|
|
|
|
super().__init__(scope, construct_id, **kwargs)
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# --- Shared alarm SNS topic (site-alerts) ---
|
|
|
|
|
# Imported once near the top so every alarm in this stack reuses the same
|
|
|
|
|
# Topic construct instance (avoids duplicate logical IDs). ALARM-only
|
|
|
|
|
# SnsAction; no OK action, per the CloudWatch-alarm preference. The
|
|
|
|
|
# topic's CMK (alias/seahaven-alarm-topics) lives on the topic itself.
|
|
|
|
|
alarm_topic = sns.Topic.from_topic_arn(
|
|
|
|
|
self,
|
|
|
|
|
"SiteAlertsTopic",
|
|
|
|
|
f"arn:aws:sns:{self.region}:{self.account}:site-alerts",
|
|
|
|
|
)
|
|
|
|
|
|
2026-04-07 12:12:30 -04:00
|
|
|
# --- S3 bucket for raw emails ---
|
|
|
|
|
email_bucket = s3.Bucket(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"EmailBucket",
|
2026-04-07 12:12:30 -04:00
|
|
|
bucket_name=f"po-ingest-emails-{self.account}",
|
2026-06-17 17:23:06 -04:00
|
|
|
block_public_access=s3.BlockPublicAccess.BLOCK_ALL,
|
2026-04-07 12:12:30 -04:00
|
|
|
removal_policy=RemovalPolicy.RETAIN,
|
|
|
|
|
lifecycle_rules=[
|
|
|
|
|
s3.LifecycleRule(expiration=Duration.days(90)),
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
2026-06-10 19:31:55 -04:00
|
|
|
# --- Shared customer-managed CMK for sensitive DynamoDB tables ---
|
|
|
|
|
# Owned by the account-baseline app (alias/seahaven-dynamodb, INFRA-95 /
|
|
|
|
|
# M-3); ARN published to SSM. The purchase-orders table was migrated to
|
|
|
|
|
# SSE-KMS out-of-band, so declaring encryption_key here reconciles the
|
|
|
|
|
# drift and — via grant_read_write_data below — propagates the required
|
|
|
|
|
# kms:Decrypt/GenerateDataKey/DescribeKey to the consumer roles.
|
|
|
|
|
dynamodb_cmk = kms.Key.from_key_arn(
|
|
|
|
|
self,
|
|
|
|
|
"DynamoDbCmk",
|
|
|
|
|
ssm.StringParameter.value_for_string_parameter(
|
|
|
|
|
self, "/seahaven/dynamodb/cmk-arn"
|
|
|
|
|
),
|
|
|
|
|
)
|
|
|
|
|
|
2026-04-30 14:26:53 -04:00
|
|
|
# --- Purchase-orders DynamoDB table ---
|
|
|
|
|
# Owned by this stack. Streams enabled for the site-extractor pipeline.
|
|
|
|
|
# Other stacks (seahaven-slack-bot) reference this table via fromTableName().
|
|
|
|
|
po_table = dynamodb.Table(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"PurchaseOrdersTable",
|
2026-04-30 14:26:53 -04:00
|
|
|
table_name="purchase-orders",
|
|
|
|
|
partition_key=dynamodb.Attribute(
|
|
|
|
|
name="po_number",
|
|
|
|
|
type=dynamodb.AttributeType.STRING,
|
|
|
|
|
),
|
|
|
|
|
billing_mode=dynamodb.BillingMode.PAY_PER_REQUEST,
|
|
|
|
|
removal_policy=RemovalPolicy.RETAIN,
|
Align PO schema with enriched records and improve extraction prompt
Replaces extraction prompt with domain-specific rules: trade
classification taxonomy (23 categories), site_code skip list,
zip padding, revision email type, and structured extraction for
fiscal_year, trade, and coupa_category.
Handler changes:
- New "revision" email type overwrites existing PO via put_item
- enrich_parsed() adds top-level state, ship_to_raw, data_source
- pad_zip() zero-pads short zip codes (e.g., "7001" → "07001")
- Removed invoice_total/invoice_count (Payee Central only)
Web UI: added revision badge, new detail fields (site code, state,
trade, fiscal year, coupa category, data source), line item table
now shows Qty/Unit/Price columns, list view shows Site and Trade.
CDK: fixed StreamViewType to match deployed table (NEW_IMAGE).
README: documented PO record schema and revision flow.
2026-05-01 19:40:18 -04:00
|
|
|
stream=dynamodb.StreamViewType.NEW_IMAGE,
|
2026-06-10 19:31:55 -04:00
|
|
|
encryption=dynamodb.TableEncryption.CUSTOMER_MANAGED,
|
|
|
|
|
encryption_key=dynamodb_cmk,
|
2026-04-07 12:12:30 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# --- Secrets Manager for Anthropic API key ---
|
|
|
|
|
anthropic_secret = secretsmanager.Secret(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"AnthropicApiKey",
|
2026-04-07 12:12:30 -04:00
|
|
|
secret_name="po-ingest/anthropic-api-key",
|
|
|
|
|
description="Anthropic API key for Coupa PO email parsing",
|
2026-05-01 19:17:19 -04:00
|
|
|
removal_policy=RemovalPolicy.RETAIN,
|
2026-04-07 12:12:30 -04:00
|
|
|
)
|
|
|
|
|
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
# --- DLQ for failed async invocations (INFRA-41 / audit H-8) ---
|
|
|
|
|
# SES → S3 → Lambda is async; without an OnFailure destination a failed
|
|
|
|
|
# parse (bad email, transient error) is silently dropped after Lambda's
|
|
|
|
|
# retries. CDK generates the queue name to avoid colliding with the
|
|
|
|
|
# interim CLI-created po-email-processor-dlq (removed post-deploy).
|
|
|
|
|
email_processor_dlq = sqs.Queue(
|
|
|
|
|
self,
|
|
|
|
|
"EmailProcessorDlq",
|
|
|
|
|
retention_period=Duration.days(14),
|
|
|
|
|
enforce_ssl=True,
|
|
|
|
|
)
|
|
|
|
|
|
2026-04-07 12:12:30 -04:00
|
|
|
# --- Lambda function ---
|
|
|
|
|
email_processor = lambda_.Function(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"EmailProcessor",
|
2026-04-07 12:12:30 -04:00
|
|
|
function_name="po-email-processor",
|
|
|
|
|
runtime=lambda_.Runtime.PYTHON_3_12,
|
2026-04-30 14:26:53 -04:00
|
|
|
architecture=lambda_.Architecture.ARM_64,
|
2026-04-07 12:12:30 -04:00
|
|
|
handler="handler.handler",
|
2026-05-08 16:01:21 -04:00
|
|
|
code=lambda_.Code.from_asset(
|
2026-05-12 15:21:06 -04:00
|
|
|
"../lambdas/po/email_processor",
|
2026-05-08 16:01:21 -04:00
|
|
|
bundling=cdk.BundlingOptions(
|
|
|
|
|
image=lambda_.Runtime.PYTHON_3_12.bundling_image,
|
|
|
|
|
command=[
|
|
|
|
|
"bash",
|
|
|
|
|
"-c",
|
2026-06-03 14:56:02 -04:00
|
|
|
"pip install --platform manylinux2014_aarch64 --only-binary=:all: "
|
|
|
|
|
"-r requirements.txt -t /asset-output && "
|
Add fail-closed SES sender authentication
The From header and any raw-MIME Authentication-Results copies are
attacker-forgeable, so a forged email to apm@int.seahaven.com or
amazon_po@int.seahaven.com could create or mutate a WO/PO (INFRA-107,
CRITICAL). Both S3-triggered email processors now authenticate the
sender against the Authentication-Results header SES itself prepends
at delivery: only the topmost header is consulted, its authserv-id
must be amazonses.com, and it must carry dkim=pass for a domain in
the per-pipeline ALLOWED_DKIM_DOMAINS env var (comma-separated, set
in CDK so ops can adjust without code changes).
Allowlists come from live traffic observed 2026-07-15 on both ingest
buckets: WO mail arrives via the apm@ Google Groups forward, which
re-signs as seahaven.com (the hxgnsmartcloud.com signature does not
survive the forward); PO mail passes for amazon.coupahost.com.
amazonses.com also passes on PO mail but is deliberately excluded --
every SES customer's outbound mail passes for it.
Every failure path (env var unset, header missing or unparseable,
verdict fail, unaligned domain) rejects the email: a structured
warning with the reason and S3 key is logged and the record skipped
without erroring the invocation, so rejected mail causes no Lambda
retries or DLQ messages. Handler signatures and event sources are
unchanged.
Refs: INFRA-107
2026-07-15 18:53:46 -04:00
|
|
|
"cp handler.py ses_auth.py /asset-output/",
|
2026-05-08 16:01:21 -04:00
|
|
|
],
|
|
|
|
|
),
|
|
|
|
|
),
|
2026-04-07 12:12:30 -04:00
|
|
|
timeout=Duration.seconds(60),
|
|
|
|
|
memory_size=256,
|
2026-04-30 14:26:53 -04:00
|
|
|
log_retention=logs.RetentionDays.TWO_MONTHS,
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
dead_letter_queue=email_processor_dlq,
|
2026-04-07 12:12:30 -04:00
|
|
|
environment={
|
|
|
|
|
"PO_TABLE": "purchase-orders",
|
|
|
|
|
"ANTHROPIC_API_KEY_SECRET_ARN": anthropic_secret.secret_arn,
|
Add fail-closed SES sender authentication
The From header and any raw-MIME Authentication-Results copies are
attacker-forgeable, so a forged email to apm@int.seahaven.com or
amazon_po@int.seahaven.com could create or mutate a WO/PO (INFRA-107,
CRITICAL). Both S3-triggered email processors now authenticate the
sender against the Authentication-Results header SES itself prepends
at delivery: only the topmost header is consulted, its authserv-id
must be amazonses.com, and it must carry dkim=pass for a domain in
the per-pipeline ALLOWED_DKIM_DOMAINS env var (comma-separated, set
in CDK so ops can adjust without code changes).
Allowlists come from live traffic observed 2026-07-15 on both ingest
buckets: WO mail arrives via the apm@ Google Groups forward, which
re-signs as seahaven.com (the hxgnsmartcloud.com signature does not
survive the forward); PO mail passes for amazon.coupahost.com.
amazonses.com also passes on PO mail but is deliberately excluded --
every SES customer's outbound mail passes for it.
Every failure path (env var unset, header missing or unparseable,
verdict fail, unaligned domain) rejects the email: a structured
warning with the reason and S3 key is logged and the record skipped
without erroring the invocation, so rejected mail causes no Lambda
retries or DLQ messages. Handler signatures and event sources are
unchanged.
Refs: INFRA-107
2026-07-15 18:53:46 -04:00
|
|
|
# Fail-closed sender auth (INFRA-107): the handler only
|
|
|
|
|
# accepts mail whose SES-stamped Authentication-Results
|
|
|
|
|
# header carries dkim=pass for one of these domains.
|
|
|
|
|
# Observed on live traffic 2026-07-15: Coupa PO mail passes
|
|
|
|
|
# DKIM for amazon.coupahost.com (and amazonses.com, which is
|
|
|
|
|
# deliberately NOT allowlisted — every SES customer's mail
|
|
|
|
|
# passes that). Unset/empty ⇒ the handler rejects all mail.
|
|
|
|
|
"ALLOWED_DKIM_DOMAINS": "amazon.coupahost.com",
|
2026-04-07 12:12:30 -04:00
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# Grant permissions
|
|
|
|
|
email_bucket.grant_read(email_processor)
|
|
|
|
|
po_table.grant_read_write_data(email_processor)
|
|
|
|
|
anthropic_secret.grant_read(email_processor)
|
|
|
|
|
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
# --- Errors alarm (INFRA-41 / audit H-8) ---
|
|
|
|
|
# ALARM-only (no OK action, per the CloudWatch-alarm preference) to the
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# shared site-alerts topic. Any errored invocation in a 5-min window pages.
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
email_processor.metric_errors(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"EmailProcessorErrorsAlarm",
|
|
|
|
|
alarm_name="po-email-processor-errors",
|
|
|
|
|
alarm_description="po-email-processor async invocation errors",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# --- Throttles alarm: po-email-processor ---
|
|
|
|
|
# Any throttled invocation (concurrency cap hit) in a 5-min window pages.
|
|
|
|
|
# ALARM-only to site-alerts; no OK action; NOT_BREACHING when no data.
|
|
|
|
|
email_processor.metric_throttles(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"EmailProcessorThrottlesAlarm",
|
|
|
|
|
alarm_name="po-email-processor-throttles",
|
|
|
|
|
alarm_description="po-email-processor invocation throttles",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
2026-06-17 17:28:42 -04:00
|
|
|
# --- DLQ messages-present alarm ---
|
|
|
|
|
# Pages when any message lands in the EmailProcessorDlq: a message here
|
|
|
|
|
# means a PO email was permanently dropped after Lambda exhausted its
|
|
|
|
|
# async retries. Maximum over a single 5-min window > 0 fires; missing
|
|
|
|
|
# data (no messages metric emitted) is not breaching. Reuses the shared
|
|
|
|
|
# site-alerts topic, ALARM-only, like the errors alarm above. The metric
|
|
|
|
|
# helper derives the QueueName dimension from the queue construct, so the
|
|
|
|
|
# alarm tracks the CDK-generated queue name without hardcoding it.
|
|
|
|
|
email_processor_dlq.metric_approximate_number_of_messages_visible(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Maximum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"EmailProcessorDlqMessagesAlarm",
|
|
|
|
|
alarm_name="po-email-processor-dlq-messages",
|
|
|
|
|
alarm_description="po-email-processor DLQ has messages (dropped PO emails)",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# --- Duration alarm: po-email-processor (orphan adoption) ---
|
|
|
|
|
# Adopts the orphaned CLI alarm Lambda-Duration-po-email-processor under
|
|
|
|
|
# the repo's <fn>-duration naming (NEW logical name → no deploy collision;
|
|
|
|
|
# delete the orphan post-deploy). p99 / 45000 ms
|
|
|
|
|
# (75% of the 60s timeout) / eval 3 of 3 — tighter than the orphan's
|
|
|
|
|
# Maximum>=48000 / 1-of-1.
|
|
|
|
|
email_processor.metric_duration(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="p99",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"EmailProcessorDurationAlarm",
|
|
|
|
|
alarm_name="po-email-processor-duration",
|
|
|
|
|
alarm_description="po-email-processor p99 duration approaching the 60s timeout",
|
|
|
|
|
threshold=45000,
|
|
|
|
|
evaluation_periods=3,
|
|
|
|
|
datapoints_to_alarm=2,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_OR_EQUAL_TO_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
2026-04-07 12:12:30 -04:00
|
|
|
# S3 event notification → Lambda
|
|
|
|
|
email_bucket.add_event_notification(
|
|
|
|
|
s3.EventType.OBJECT_CREATED,
|
|
|
|
|
s3n.LambdaDestination(email_processor),
|
|
|
|
|
s3.NotificationKeyFilter(prefix="inbound/"),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# --- SES Receipt Rule ---
|
|
|
|
|
# Reuse the existing INBOUND_MAIL rule set (shared with workorder-ingest)
|
|
|
|
|
rule_set = ses.ReceiptRuleSet.from_receipt_rule_set_name(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"ExistingRuleSet",
|
|
|
|
|
"INBOUND_MAIL",
|
2026-04-07 12:12:30 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
rule_set.add_rule(
|
|
|
|
|
"PoEmailRule",
|
|
|
|
|
recipients=["amazon_po@int.seahaven.com"],
|
|
|
|
|
actions=[
|
|
|
|
|
ses_actions.S3(
|
|
|
|
|
bucket=email_bucket,
|
|
|
|
|
object_key_prefix="inbound/",
|
|
|
|
|
),
|
|
|
|
|
],
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# --- Web UI Lambda ---
|
|
|
|
|
web_ui = lambda_.Function(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"WebUI",
|
2026-04-07 12:12:30 -04:00
|
|
|
function_name="po-web-ui",
|
|
|
|
|
runtime=lambda_.Runtime.PYTHON_3_12,
|
2026-04-30 14:26:53 -04:00
|
|
|
architecture=lambda_.Architecture.ARM_64,
|
2026-04-07 12:12:30 -04:00
|
|
|
handler="handler.handler",
|
2026-05-12 15:21:06 -04:00
|
|
|
code=lambda_.Code.from_asset("../lambdas/po/web_ui"),
|
2026-04-07 12:12:30 -04:00
|
|
|
timeout=Duration.seconds(60),
|
|
|
|
|
memory_size=256,
|
2026-04-30 14:26:53 -04:00
|
|
|
log_retention=logs.RetentionDays.TWO_MONTHS,
|
2026-04-07 12:12:30 -04:00
|
|
|
environment={
|
|
|
|
|
"PO_TABLE": "purchase-orders",
|
|
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
po_table.grant_read_data(web_ui)
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# --- Throttles alarm: po-web-ui ---
|
|
|
|
|
web_ui.metric_throttles(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"WebUiThrottlesAlarm",
|
|
|
|
|
alarm_name="po-web-ui-throttles",
|
|
|
|
|
alarm_description="po-web-ui invocation throttles",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
|
|
|
|
# --- Duration alarm: po-web-ui ---
|
|
|
|
|
# Net-new (no orphan exists for this function).
|
|
|
|
|
# p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2.
|
|
|
|
|
web_ui.metric_duration(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="p99",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"WebUiDurationAlarm",
|
|
|
|
|
alarm_name="po-web-ui-duration",
|
|
|
|
|
alarm_description="po-web-ui p99 duration approaching the 60s timeout",
|
|
|
|
|
threshold=45000,
|
|
|
|
|
evaluation_periods=3,
|
|
|
|
|
datapoints_to_alarm=2,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_OR_EQUAL_TO_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
Reconcile IaC with out-of-band DLQ + Function URL changes (INFRA-74, INFRA-41) (#50)
Make CDK the source of truth for two sets of changes applied out-of-band
via CLI to the po-ingest and WorkorderIngestStack stacks.
INFRA-74 (audit C-5): remove the public FunctionUrlAuthType.NONE Function
URL construct (and its auto-generated Principal:* invoke permission +
output) from both po-web-ui and workorder-web-ui. The URLs were already
deleted live via CLI; CFN's delete is idempotent.
INFRA-41 (audit H-8): add a CDK-managed SQS dead-letter queue
(dead_letter_queue=, 14d retention, SSL-enforced, CDK-generated name) and
an ALARM-only Errors alarm (Sum, threshold>0, site-alerts topic) for both
po-email-processor and workorder-email-processor, mirroring the
apm-wo-analysis-classifier DLQ and payments-payroll-batch alarm patterns.
Interim CLI resources (per-fn -dlq queues, -errors alarms, dlq-send inline
policies, OnFailure event-invoke-configs) removed post-deploy.
2026-06-08 16:02:29 -04:00
|
|
|
# Public Function URL removed 2026-06-08 (INFRA-74 / audit C-5): the
|
|
|
|
|
# unauthenticated FunctionUrlAuthType.NONE URL was deleted out-of-band
|
|
|
|
|
# via CLI. Removing the construct (and its auto-generated Principal:*
|
|
|
|
|
# invoke permission) reconciles IaC with the live state.
|
2026-04-30 14:26:53 -04:00
|
|
|
|
|
|
|
|
# --- Verified sites table (extracted from PO ship-to addresses) ---
|
|
|
|
|
verified_sites_table = dynamodb.Table(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"VerifiedSitesTable",
|
2026-04-30 14:26:53 -04:00
|
|
|
table_name="verified-sites",
|
|
|
|
|
partition_key=dynamodb.Attribute(
|
|
|
|
|
name="siteCode",
|
|
|
|
|
type=dynamodb.AttributeType.STRING,
|
|
|
|
|
),
|
|
|
|
|
billing_mode=dynamodb.BillingMode.PAY_PER_REQUEST,
|
|
|
|
|
removal_policy=RemovalPolicy.RETAIN,
|
|
|
|
|
)
|
2026-06-03 15:32:23 -04:00
|
|
|
# by-state GSI removed 2026-06-03 (audit M-20): 0 reads in 30d against
|
|
|
|
|
# 518 WCU of write amplification. Re-add if a state-level query path ships.
|
2026-04-30 14:26:53 -04:00
|
|
|
|
|
|
|
|
# --- Site extractor Lambda (DynamoDB Streams → verified-sites) ---
|
|
|
|
|
site_extractor = lambda_.Function(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"SiteExtractor",
|
2026-04-30 14:26:53 -04:00
|
|
|
function_name="po-ingest-site-extractor",
|
|
|
|
|
runtime=lambda_.Runtime.PYTHON_3_12,
|
|
|
|
|
architecture=lambda_.Architecture.ARM_64,
|
|
|
|
|
handler="handler.handler",
|
2026-05-12 15:21:06 -04:00
|
|
|
code=lambda_.Code.from_asset("../lambdas/po/site_extractor"),
|
2026-04-30 14:26:53 -04:00
|
|
|
timeout=Duration.seconds(60),
|
|
|
|
|
memory_size=256,
|
|
|
|
|
log_retention=logs.RetentionDays.TWO_MONTHS,
|
|
|
|
|
environment={
|
|
|
|
|
"VERIFIED_SITES_TABLE": verified_sites_table.table_name,
|
2026-04-30 15:01:09 -04:00
|
|
|
"PENDING_REVIEW_TABLE": "pending-site-review",
|
2026-04-30 14:26:53 -04:00
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
verified_sites_table.grant_read_write_data(site_extractor)
|
|
|
|
|
|
|
|
|
|
site_extractor.add_event_source(
|
|
|
|
|
lambda_event_sources.DynamoEventSource(
|
|
|
|
|
po_table,
|
|
|
|
|
starting_position=lambda_.StartingPosition.TRIM_HORIZON,
|
|
|
|
|
batch_size=10,
|
|
|
|
|
max_batching_window=Duration.seconds(30),
|
|
|
|
|
bisect_batch_on_error=True,
|
|
|
|
|
retry_attempts=3,
|
|
|
|
|
)
|
|
|
|
|
)
|
|
|
|
|
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
# --- Errors alarm: po-ingest-site-extractor ---
|
|
|
|
|
# Stream-consumer errors retry per the event-source config, but a
|
|
|
|
|
# persistent failure stalls the verified-sites pipeline. ALARM-only to
|
|
|
|
|
# site-alerts; no OK action; NOT_BREACHING when no data.
|
|
|
|
|
site_extractor.metric_errors(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"SiteExtractorErrorsAlarm",
|
|
|
|
|
alarm_name="po-ingest-site-extractor-errors",
|
|
|
|
|
alarm_description="po-ingest-site-extractor invocation errors",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
|
|
|
|
# --- Throttles alarm: po-ingest-site-extractor ---
|
|
|
|
|
site_extractor.metric_throttles(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="Sum",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"SiteExtractorThrottlesAlarm",
|
|
|
|
|
alarm_name="po-ingest-site-extractor-throttles",
|
|
|
|
|
alarm_description="po-ingest-site-extractor invocation throttles",
|
|
|
|
|
threshold=0,
|
|
|
|
|
evaluation_periods=1,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
|
|
|
|
# --- Duration alarm: po-ingest-site-extractor ---
|
|
|
|
|
# Net-new (no orphan exists for this function).
|
|
|
|
|
# p99 / 45000 ms (75% of the 60s timeout) / eval 3, datapoints 2.
|
|
|
|
|
site_extractor.metric_duration(
|
|
|
|
|
period=Duration.minutes(5),
|
|
|
|
|
statistic="p99",
|
|
|
|
|
).create_alarm(
|
|
|
|
|
self,
|
|
|
|
|
"SiteExtractorDurationAlarm",
|
|
|
|
|
alarm_name="po-ingest-site-extractor-duration",
|
|
|
|
|
alarm_description="po-ingest-site-extractor p99 duration approaching the 60s timeout",
|
|
|
|
|
threshold=45000,
|
|
|
|
|
evaluation_periods=3,
|
|
|
|
|
datapoints_to_alarm=2,
|
|
|
|
|
comparison_operator=cloudwatch.ComparisonOperator.GREATER_THAN_OR_EQUAL_TO_THRESHOLD,
|
|
|
|
|
treat_missing_data=cloudwatch.TreatMissingData.NOT_BREACHING,
|
|
|
|
|
).add_alarm_action(cw_actions.SnsAction(alarm_topic))
|
|
|
|
|
|
2026-05-08 16:01:21 -04:00
|
|
|
cdk.CfnOutput(
|
|
|
|
|
self,
|
|
|
|
|
"VerifiedSitesTableName",
|
2026-04-30 14:26:53 -04:00
|
|
|
value=verified_sites_table.table_name,
|
|
|
|
|
description="Verified site addresses extracted from POs",
|
|
|
|
|
)
|
2026-04-30 15:01:09 -04:00
|
|
|
|
|
|
|
|
# --- Pending site review table (POs with no extractable site code) ---
|
|
|
|
|
pending_review_table = dynamodb.Table(
|
2026-05-08 16:01:21 -04:00
|
|
|
self,
|
|
|
|
|
"PendingSiteReviewTable",
|
2026-04-30 15:01:09 -04:00
|
|
|
table_name="pending-site-review",
|
|
|
|
|
partition_key=dynamodb.Attribute(
|
|
|
|
|
name="po_number",
|
|
|
|
|
type=dynamodb.AttributeType.STRING,
|
|
|
|
|
),
|
|
|
|
|
billing_mode=dynamodb.BillingMode.PAY_PER_REQUEST,
|
|
|
|
|
removal_policy=RemovalPolicy.RETAIN,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
pending_review_table.grant_read_write_data(site_extractor)
|
|
|
|
|
verified_sites_table.grant_read_data(site_extractor)
|
Add CloudWatch alarm coverage for po-ingest and workorder-ingest (#70)
* Add CloudWatch alarm coverage for po-ingest and workorder-ingest
Expands alarm coverage across both CDK stacks. All alarms are ALARM-only
(no OK action) to the shared site-alerts SNS topic, with TreatMissingData
NOT_BREACHING. The site-alerts topic is now imported once near the top of
each stack so every alarm reuses one Topic instance.
po-ingest (cdk/po_stack.py):
- Errors: po-ingest-site-extractor
- Throttles: po-email-processor, po-ingest-site-extractor, po-web-ui
- Duration (p99, >=45000ms, eval3/dp2): po-email-processor (orphan adoption),
po-ingest-site-extractor, po-web-ui
- DynamoDB throttle + system-error: purchase-orders, verified-sites,
pending-site-review
workorder-ingest (cdk/wo_stack.py):
- Throttles: workorder-email-processor
- Duration (p95, >=45000ms, eval3/dp2): workorder-email-processor (orphan adoption)
- DynamoDB throttle + system-error: WorkOrders, WorkOrderComments
DynamoDB ThrottledRequests/SystemErrors emit only at the TableName+Operation
dimension set, so each table alarm is a Sum math expression across operations
via the non-deprecated metric_*_for_operations helpers (metric_throttled_requests
is deprecated/invalid in aws-cdk-lib 2.259.0).
Refs INFRA-41 / audit H-8.
* Drop NEEDS ADAM SIGN-OFF wording from alarm comments
Duration alarm thresholds are owner-approved; remove the sign-off flag
from po_stack.py and wo_stack.py comments. Threshold values, eval config,
and orphan-delete notes are unchanged.
2026-06-17 14:46:03 -04:00
|
|
|
|
|
|
|
|
# --- DynamoDB throttle + system-error alarms ---
|
|
|
|
|
# ThrottledRequests / SystemErrors emit at TableName + Operation only
|
|
|
|
|
# (verified against live CloudWatch: no TableName-only rollup exists, and
|
|
|
|
|
# metric_throttled_requests is deprecated/invalid in aws-cdk-lib 2.259.0).
|
|
|
|
|
# Each table currently has zero throttle/error datapoints, so the series
|
|
|
|
|
# only materialise on first occurrence — NOT_BREACHING keeps them OK until
|
|
|
|
|
# then.
|
|
|
|
|
_add_ddb_alarms(
|
|
|
|
|
self, "PurchaseOrdersTable", po_table, "purchase-orders", alarm_topic
|
|
|
|
|
)
|
|
|
|
|
_add_ddb_alarms(
|
|
|
|
|
self,
|
|
|
|
|
"VerifiedSitesTable",
|
|
|
|
|
verified_sites_table,
|
|
|
|
|
"verified-sites",
|
|
|
|
|
alarm_topic,
|
|
|
|
|
)
|
|
|
|
|
_add_ddb_alarms(
|
|
|
|
|
self,
|
|
|
|
|
"PendingSiteReviewTable",
|
|
|
|
|
pending_review_table,
|
|
|
|
|
"pending-site-review",
|
|
|
|
|
alarm_topic,
|
|
|
|
|
)
|