adam/payments-dashboard
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/payments-dashboard.git synced 2026-10-04 14:52:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(csv): comma-tolerant amount parsing in backfill (PR #72 review)

Browse source 
Number() on a hand-inserted comma-formatted string amount would NaN and
skip the check during backfill; hoist the CSV path's parseAmount to
module scope and share it. No live records are affected (all amount_usd
values are DDB Number type) — defensive consistency.
This commit is contained in:
Adam Moussa 2026-07-21 19:24:11 -04:00
parent e125e56820
commit 0daec80461
No known key found for this signature in database
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/processPaymentCsv.js
View file

@ -44,6 +44,13 @@ async function getAccessToken(applicationID, clientId, clientSecret) {
// CloudWatch log lines (CWE-117). // CloudWatch log lines (CWE-117).
const logSafe = (v) => JSON.stringify(String(v ?? "").slice(0, 64)); const logSafe = (v) => JSON.stringify(String(v ?? "").slice(0, 64));
// Comma-tolerant amount parsing, shared by the CSV path and the backfill so
// a hand-inserted "1,234.56" string record can't NaN out of registration.
const parseAmount = (value) => {
const num = parseFloat(String(value || "0").replace(/,/g, "").trim());
return isNaN(num) ? 0 : num;
};
async function backfillBoA() { async function backfillBoA() {
const cancelStatuses = ["voided", "cancelled", "canceled", "marked as void"]; const cancelStatuses = ["voided", "cancelled", "canceled", "marked as void"];
@ -82,7 +89,7 @@ async function backfillBoA() {
if (cancelStatuses.includes((item.status || "").toLowerCase())) continue; if (cancelStatuses.includes((item.status || "").toLowerCase())) continue;
if (item.check_number.length > 10) continue; if (item.check_number.length > 10) continue;
const issueDate = toISODate(item.send_payment_on); const issueDate = toISODate(item.send_payment_on);
const amount = Number(item.amount_usd); const amount = parseAmount(item.amount_usd);
if (!issueDate || !(amount > 0)) { if (!issueDate || !(amount > 0)) {
console.error(`Backfill skipping check ${logSafe(item.check_number)}: missing issue date or amount`); console.error(`Backfill skipping check ${logSafe(item.check_number)}: missing issue date or amount`);
continue; continue;
@ -256,11 +263,6 @@ export const handler = async (event) => {
return clean; return clean;
}); });
const parseAmount = (value) => {
const num = parseFloat(String(value || "0").replace(/,/g, "").trim());
return isNaN(num) ? 0 : num;
};
const cancelStatuses = ["voided", "cancelled", "canceled", "marked as void"]; const cancelStatuses = ["voided", "cancelled", "canceled", "marked as void"];
// Status progression ranks — higher number = further along in lifecycle // Status progression ranks — higher number = further along in lifecycle