Adam Moussa
ed8e9a13ab
Resolve the security-review BLOCKER and the confirmed authz/info findings on the Confluence-writer node: - BLOCKER (data-loss): _page_has_macros fail-OPENed (real ConfluenceClient has no page_has_macros/ADF methods) so every live write fell through to a wholesale storage-body PUT that drops Mermaid macros — the page-1540098 diagram-loss class. Add count_storage_macros + a real ConfluenceClient .page_has_macros (storage-body detection); make _page_has_macros FAIL CLOSED; and add _assert_macros_preserved as the final backstop: refuse any storage write whose body carries fewer macros than the live page. - AUTHZ-CONF-01: add an opt-in AGENT_TEAM_CONFLUENCE_ALLOWED_PAGE_IDS allowlist enforced server-side before a live update (model-derived page_id). - AUTHZ-CONF-02: stop silently picking the first accessible Confluence site; require CONFLUENCE_CLOUD_ID when multiple resolve. - INFO: 'applied' now fail-honest (defaults False, not True) on a missing attr. +10 regression tests; full suite 1612 passed; ruff clean. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| build_verify_subgraph.py | ||
| builders.py | ||
| builders_llm.py | ||
| clarifier.py | ||
| clarifier_llm.py | ||
| confluence_writer.py | ||
| confluence_writer_llm.py | ||
| dispatch_invoker.py | ||
| fixer.py | ||
| handbook.py | ||
| planner.py | ||
| review_loop.py | ||
| review_loop_llm.py | ||
| verifier.py | ||
| verifier_llm.py | ||