GPT-4.1 cross-family review (APPROVE, no critical/high) raised two MEDIUMs on the rollback tooling; addressed both: - require_keys: each restore_* asserts its required baseline keys up front and refuses a PARTIAL (silently-weaker) restore. environment accepts ids OR logins (equivalent); a missing protection.full now REFUSES the enforce_admins-only degrade unless P3_ROLLBACK_ALLOW_PARTIAL=1 is set (loud DEGRADED warning). - out-of-band ACK: an --apply that needs a MANUAL App neutralise (no APP JWT, or action=out-of-band) refuses unless P3_ROLLBACK_OOB_ACK=1 — so the App is never left un-neutralised without a conscious operator sign-off; with the ack the other surfaces still restore. Documented both env vars in usage. +3 tests (required-key refuse, partial-protection ack, oob ack). Suite: 1362 passed, ruff clean. |
||
|---|---|---|
| .. | ||
| assert_no_write_token.py | ||
| deploy-r720-ws-rollout.sh | ||
| deploy-r720.sh | ||
| p3_rollback.sh | ||