agent-team: approved-plan terminus mislabeled as phase=build/status=active on the dashboard #68

New issue

Closed

opened 2026-06-24 23:27:11 +00:00 by amoussa1229 · 1 comment

amoussa1229 commented

2026-06-24 23:27:11 +00:00

(Migrated from github.com)

Summary

When the review loop approves a plan, the task's terminus is labeled current_phase = build / status = active, even though (in the path that doesn't drive into an actual build) it has effectively reached the documented "stops at an approved plan" terminus. The dashboard then shows an approved/finished task as "Build · active", which reads as in-progress build work.

Detail

graph.py review-approve sets phase = BUILD, status = ACTIVE before routing to BUILD_NODE (when build_verify wired) or END (when not).
When the task ends at that terminus without an executed build (see sibling issue on the tick-resume gap), the persisted state stays build/active with no build transition row and $0 build cost.
The read-only dashboard faithfully renders current_phase/status, so the column/badge says "Build / active" for a task that is really plan-approved, idle.

Impact

Operators (and the Board view) can't distinguish "actively building" from "approved plan, nothing happening". Cosmetic but misleading during triage.

Suggested fix direction

Give the approved-plan terminus an honest terminal marker (e.g. status=done with a phase like plan_approved, or don't advance current_phase to build until the build node actually enters). The dashboard needs no change once the backend state reads truthfully.

Found during the dashboard-redesign e2e test (PR #64).

## Summary When the review loop **approves a plan**, the task's terminus is labeled `current_phase = build` / `status = active`, even though (in the path that doesn't drive into an actual build) it has effectively reached the documented "stops at an approved plan" terminus. The dashboard then shows an approved/finished task as **"Build · active"**, which reads as in-progress build work. ## Detail - `graph.py` review-approve sets `phase = BUILD`, `status = ACTIVE` before routing to `BUILD_NODE` (when `build_verify` wired) or `END` (when not). - When the task ends at that terminus without an executed build (see sibling issue on the tick-resume gap), the persisted state stays `build/active` with **no build transition row and `$0` build cost**. - The read-only dashboard faithfully renders `current_phase`/`status`, so the column/badge says "Build / active" for a task that is really *plan-approved, idle*. ## Impact Operators (and the Board view) can't distinguish "actively building" from "approved plan, nothing happening". Cosmetic but misleading during triage. ## Suggested fix direction Give the approved-plan terminus an honest terminal marker (e.g. `status=done` with a phase like `plan_approved`, or don't advance `current_phase` to `build` until the build node actually enters). The dashboard needs no change once the backend state reads truthfully. Found during the dashboard-redesign e2e test (PR #64).

amoussa1229 commented

2026-07-14 23:03:18 +00:00

(Migrated from github.com)

agent-team subsystem was decommissioned 2026-06-26 and this repo is being archived — closing as not planned.

This repo is archived. You cannot comment on issues.