agent-team web CI: wire Prettier + ESLint + Playwright and enable the toggled-off CI steps #65

New issue

Closed

opened 2026-06-24 22:46:23 +00:00 by amoussa1229 · 1 comment

amoussa1229 commented

2026-06-24 22:46:23 +00:00

(Migrated from github.com)

Background

The agent-team dashboard (agent-team/web) got real CI in #64 via the org reusable workflow ci-typescript-frontend.yaml (caller: .github/workflows/ci-web.yaml). To get it green now, three reusable steps were toggled off because the tooling isn't wired yet:

# .github/workflows/ci-web.yaml
with:
  required-scripts: "build,test"
  run-format-check: false   # no Prettier
  run-lint: false           # no ESLint
  run-e2e: false            # no Playwright

The reusable workflow already supports all three — this issue is to add the tools + npm scripts and flip the toggles back on.

Tasks

Prettier — add prettier + config, add a format:check script (prettier --check .), format the web/ tree, then set run-format-check: true (remove from the off-list).
ESLint — add ESLint (flat config) with the React + TypeScript + hooks plugins, add a lint script, fix findings, then set run-lint: true.
Playwright — add @playwright/test, a minimal browser smoke (load the dashboard, assert the Board renders against a mocked//api-proxied backend), add a test:e2e script, then set run-e2e: true (default browser chromium).
Restore required-scripts to the workflow default (format:check,lint,build,test,test:e2e) once all scripts exist — or drop the explicit override entirely.

Notes

Keep the scoped paths: agent-team/web/** trigger and the distinct ci-web job id (status ci-web / ci, so it doesn't collide with the Python ci / ci).
Local dev / CI uses Node 24 / npm 11 (lockfileVersion 3) per the engineering handbook.
Optional: once stable, add ci-web / ci to the main branch-protection ruleset so it gates merges (org-admin change).

Follow-up to #64.

## Background The agent-team dashboard (`agent-team/web`) got real CI in #64 via the org reusable workflow `ci-typescript-frontend.yaml` (caller: `.github/workflows/ci-web.yaml`). To get it green now, three reusable steps were **toggled off** because the tooling isn't wired yet: ```yaml # .github/workflows/ci-web.yaml with: required-scripts: "build,test" run-format-check: false # no Prettier run-lint: false # no ESLint run-e2e: false # no Playwright ``` The reusable workflow already supports all three — this issue is to add the tools + npm scripts and flip the toggles back on. ## Tasks - [ ] **Prettier** — add `prettier` + config, add a `format:check` script (`prettier --check .`), format the `web/` tree, then set `run-format-check: true` (remove from the off-list). - [ ] **ESLint** — add ESLint (flat config) with the React + TypeScript + hooks plugins, add a `lint` script, fix findings, then set `run-lint: true`. - [ ] **Playwright** — add `@playwright/test`, a minimal browser smoke (load the dashboard, assert the Board renders against a mocked/`/api`-proxied backend), add a `test:e2e` script, then set `run-e2e: true` (default browser chromium). - [ ] Restore `required-scripts` to the workflow default (`format:check,lint,build,test,test:e2e`) once all scripts exist — or drop the explicit override entirely. ## Notes - Keep the scoped `paths: agent-team/web/**` trigger and the distinct `ci-web` job id (status `ci-web / ci`, so it doesn't collide with the Python `ci / ci`). - Local dev / CI uses **Node 24 / npm 11** (lockfileVersion 3) per the engineering handbook. - Optional: once stable, add `ci-web / ci` to the `main` branch-protection ruleset so it gates merges (org-admin change). Follow-up to #64.

amoussa1229 commented

2026-07-14 23:03:20 +00:00

(Migrated from github.com)

agent-team subsystem was decommissioned 2026-06-26 and this repo is being archived — closing as not planned.

This repo is archived. You cannot comment on issues.