adam/orchestrator
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(agent-team): make slack_live token test independent of slack_sdk presence

Browse source 
CI lacks slack_sdk, so the deferred-import-missing error fired before the no-token check and masked it. Stub slack_sdk into sys.modules so the token branch is deterministically exercised in both environments.
This commit is contained in:
Adam Moussa 2026-06-18 13:00:34 -04:00
parent 0f33fa6f24
commit 8d9babe52e
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
agent-team/tests/test_slack_live.py
View file

@ -214,7 +214,19 @@ def test_poster_unsupported_response_raises_type_error() -> None:
def test_missing_token_raises_runtime_error(monkeypatch: pytest.MonkeyPatch) -> None: def test_missing_token_raises_runtime_error(monkeypatch: pytest.MonkeyPatch) -> None:
"""No token and no SLACK_BOT_TOKEN raises a clear RuntimeError.""" """No token and no SLACK_BOT_TOKEN raises a clear RuntimeError.
Stub ``slack_sdk`` into ``sys.modules`` so the deferred import SUCCEEDS and
the no-token branch is what's under test. Without this the test is
environment-dependent: where slack_sdk is absent (CI) the import-missing
error fires first and masks the token check (local-vs-CI drift).
"""
import sys
from types import ModuleType
fake = ModuleType("slack_sdk")
fake.WebClient = lambda **kw: None # type: ignore[attr-defined]
monkeypatch.setitem(sys.modules, "slack_sdk", fake)
monkeypatch.delenv("SLACK_BOT_TOKEN", raising=False) monkeypatch.delenv("SLACK_BOT_TOKEN", raising=False)
with pytest.raises(RuntimeError, match="Slack bot token"): with pytest.raises(RuntimeError, match="Slack bot token"):