Johannes du Plessis 903c327e4c fix: enforce client-side deadline on sandbox execute (#1451) ... * fix: enforce client-side deadline on sandbox execute The langsmith SDK's default execute path is now a WebSocket stream with no client-side read deadline. On a live socket where the dataplane never emits an exit/error frame, CommandHandle.result blocks forever in an uncancellable thread, wedging the run (introduced by the langsmith 0.8.3 -> 0.8.8 bump in #1385). The command `timeout` is only enforced server-side, so it doesn't fire. TimeoutLangSmithSandbox drives a non-blocking CommandHandle and kills the command if it overruns its timeout by a grace window (SANDBOX_EXECUTE_CLIENT_GRACE_SECONDS, default 30), returning a timed-out tool result instead of hanging. WS connect failures fall back to the base wait=True path, whose HTTP fallback carries its own request deadline. * fix: fall back to HTTP when WS execute connect fails run(wait=False) eagerly opens the WebSocket and reads the "started" frame, so connect/setup failures (and connect timeouts) raise from the run() call itself, not from handle.result. The previous structure left run() outside the try, so those failures bypassed the HTTP fallback and would fail every sandbox command in any environment where the WS path is unavailable. Move handle creation inside the fallback handler in both execute and aexecute, and run it via to_thread in the async path since it now blocks on connect. Add tests for connect-failure and connect-timeout fallback. --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>		2026-06-08 11:16:08 -07:00
..
middleware	fix: keep sandbox backend stable across recovery (#1294)w	2026-05-11 16:03:38 -07:00
conftest.py	Remove reviewer env allowlist (#1353)	2026-05-28 14:29:33 -07:00
test_account_link.py	fix: use Slack OIDC mappings for Slack thread ownership (#1410)	2026-06-04 19:58:30 +00:00
test_agent_schedules.py	feat: add scheduled web agents (#1422)	2026-06-05 02:20:24 +00:00
test_agent_subagent_models.py	fix: Reduce graph load and dashboard repo failures (#1412)	2026-06-04 13:54:06 -07:00
test_agent_usage.py	fix: precompute usage tab caches (#1434)	2026-06-06 08:11:53 -07:00
test_analyzer_cron.py	feat: outcomes dataset + bootstrap/continual split via skills (#1365)	2026-06-01 13:25:12 -07:00
test_analyzer_skills.py	feat: outcomes dataset + bootstrap/continual split via skills (#1365)	2026-06-01 13:25:12 -07:00
test_anthropic_effort.py	feat: tune reviewer for precision — web/wiki tools + recalibrated prompt (#1312)	2026-05-20 18:35:00 +00:00
test_auth_sources.py	fix: stop storing GitHub tokens in metadata (#1405)	2026-06-04 09:33:51 -07:00
test_authorship.py	feat: open Slack-triggered PRs as the triggering user (#1375)	2026-06-02 15:04:20 -07:00
test_check_message_queue.py	fix: prioritize web replies after Slack handoff (#1406)	2026-06-04 10:01:10 -07:00
test_dashboard_message_adapter.py	feat: support dashboard chat images (#1435)	2026-06-06 11:50:24 -07:00
test_dashboard_org_login_gate.py	fix: Lock dashboard login to GitHub org members (#1367)	2026-06-01 20:56:30 +00:00
test_dashboard_repo_optional.py	feat: add stop button to cancel running agent from web UI (#1433)	2026-06-06 08:12:30 -07:00
test_dashboard_repos.py	fix: Reduce graph load and dashboard repo failures (#1412)	2026-06-04 13:54:06 -07:00
test_dashboard_run_email.py	fix: use Slack OIDC mappings for Slack thread ownership (#1410)	2026-06-04 19:58:30 +00:00
test_dashboard_thread_api.py	fix: reject images for text-only models (#1439)	2026-06-06 13:09:31 -07:00
test_dashboard_thread_api_activity.py	fix: update sidebar thread activity indicators (#1441)	2026-06-08 10:38:31 -07:00
test_dashboard_web_handoff.py	fix: reject images for text-only models (#1439)	2026-06-06 13:09:31 -07:00
test_daytona_integration.py	fix(daytona): make sandbox snapshot configurable (#1220)	2026-05-01 22:51:34 +00:00
test_encryption.py	feat: support TOKEN_ENCRYPTION_KEY rotation via MultiFernet [closes AB-2323] (#1275)	2026-05-08 14:29:23 -07:00
test_ensure_no_empty_msg.py	fix: prioritize web replies after Slack handoff (#1406)	2026-06-04 10:01:10 -07:00
test_fireworks_model.py	feat: Add Fireworks model provider (#1415)	2026-06-04 21:59:47 +00:00
test_github_app.py	fix: scope public reviewer tokens (#1389)	2026-06-03 09:25:17 -07:00
test_github_comment_prompts.py	chore: attribute commit co-author to open-swe[bot], not open-swe user	2026-06-03 11:19:24 -07:00
test_github_feedback.py	feat: reconcile reviewer comment lifecycle (#1332)	2026-05-26 16:24:34 -07:00
test_github_issue_webhook.py	feat: surface dashboard UI link on PR reviews [INF-0000] (#1440)	2026-06-07 05:17:09 +00:00
test_github_oauth_refresh.py	fix: review style prompts UX, stale runs, and OAuth refresh (#1321)	2026-05-21 17:44:04 +00:00
test_github_token_ttl.py	fix: stop storing GitHub tokens in metadata (#1405)	2026-06-04 09:33:51 -07:00
test_google_model.py	feat: add Gemini 3.5 Flash provider (#1420)	2026-06-04 17:38:54 -07:00
test_http_security.py	fix: harden http_request SSRF guard against DNS rebinding [closes AB-2321] (#1277)	2026-05-08 22:06:25 +00:00
test_langsmith_sandbox_config.py	feat: add idle TTL and delete-after-stop sandbox lifecycle controls (#1265)	2026-05-08 00:30:14 -04:00
test_langsmith_sandbox_timeout.py	fix: enforce client-side deadline on sandbox execute (#1451)	2026-06-08 11:16:08 -07:00
test_local_integration.py	fix: auto-create local sandbox root dir (#1402)	2026-06-03 23:47:08 +00:00
test_model_fallback_middleware.py	feat: cross-provider model fallback on transient errors (#1281)	2026-05-08 15:35:13 -07:00
test_model_fallback_resolution.py	feat: upgrade default agent + reviewer model to Opus 4.8 (#1350)	2026-05-28 10:59:29 -07:00
test_multimodal.py	chore: Drop monorepo (#1029)	2026-03-06 16:10:34 -08:00
test_normalize_repo.py	feat: tune reviewer for precision — web/wiki tools + recalibrated prompt (#1312)	2026-05-20 18:35:00 +00:00
test_notify_step_limit_middleware.py	fix: notify users via Slack when agent hits model call step limit (#1204)	2026-05-01 14:24:25 -07:00
test_open_pull_request.py	feat: open PRs as the triggering user via dedicated tool (#1378)	2026-06-02 16:01:54 -07:00
test_pr_ready_auto_review.py	fix: reviewer resolves GitHub App token at run start, not via cross-process cache (#1409)	2026-06-04 12:11:23 -07:00
test_prompt_default_repo.py	fix: make default repository configurable (#1429)	2026-06-05 13:48:47 -07:00
test_proxy_auth.py	fix: Reduce graph load and dashboard repo failures (#1412)	2026-06-04 13:54:06 -07:00
test_public_repo_org_gate.py	fix: remove manual review trigger surfaces (#1396)	2026-06-03 12:33:22 -07:00
test_recent_comments.py	chore: Drop monorepo (#1029)	2026-03-06 16:10:34 -08:00
test_refresh_slack_status_middleware.py	feat: add optional Slack Assistants API typing status indicator (#1269)	2026-05-08 10:21:55 -07:00
test_repo_extraction.py	feat: support allowed repos in addition to allowed orgs for webhook filtering (#1092)	2026-05-08 13:26:30 -07:00
test_review_style_collector.py	feat: tune reviewer for precision — web/wiki tools + recalibrated prompt (#1312)	2026-05-20 18:35:00 +00:00
test_review_style_sync.py	fix: review style prompts UX, stale runs, and OAuth refresh (#1321)	2026-05-21 17:44:04 +00:00
test_review_styles_store.py	feat: tune reviewer for precision — web/wiki tools + recalibrated prompt (#1312)	2026-05-20 18:35:00 +00:00
test_reviewer.py	feat: inject org-wide guidelines into reviewer prompt (#1431)	2026-06-05 13:49:30 -07:00
test_reviewer_diff.py	fix: fetch PR diff via GitHub API to re-enable add_finding validation (#1339)	2026-05-27 17:03:33 +00:00
test_reviewer_eval_run.py	feat: upgrade default agent + reviewer model to Opus 4.8 (#1350)	2026-05-28 10:59:29 -07:00
test_reviewer_eval_target.py	feat: upgrade default agent + reviewer model to Opus 4.8 (#1350)	2026-05-28 10:59:29 -07:00
test_reviewer_findings.py	fix: reviewer publishes against stale head_sha on mid-run re-review (#1393)	2026-06-03 11:38:56 -07:00
test_reviewer_outcomes.py	feat: outcomes dataset + bootstrap/continual split via skills (#1365)	2026-06-01 13:25:12 -07:00
test_reviewer_publish.py	fix: reword reviewer feedback prompt (#1449)	2026-06-08 10:02:02 -07:00
test_reviewer_reconcile.py	feat: let reviewer set comment titles (#1356)	2026-05-28 16:04:38 -07:00
test_reviewer_tools.py	feat: surface out-of-diff findings in a collapsed dropdown (#1427)	2026-06-05 10:41:48 -07:00
test_reviewer_watch.py	fix: reviewer resolves GitHub App token at run start, not via cross-process cache (#1409)	2026-06-04 12:11:23 -07:00
test_sandbox_paths.py	fix: better custom backend support (#1071)	2026-03-17 11:55:36 -07:00
test_sanitize_thinking_blocks.py	fix: sanitize malformed Anthropic thinking blocks (#1357)	2026-05-28 16:15:13 -07:00
test_sanitize_tool_inputs.py	fix: coerce malformed integer strings in read_file offset/limit params (#1216)	2026-05-01 14:29:48 -07:00
test_slack_assistants_status.py	feat: add Slack Block Kit reply options (#1407)	2026-06-04 10:26:09 -07:00
test_slack_context.py	fix: make default repository configurable (#1429)	2026-06-05 13:48:47 -07:00
test_slack_feedback.py	feat: add Slack reaction feedback to LangSmith (#1231)	2026-05-08 14:24:12 -07:00
test_slack_oauth.py	feat: open Slack-triggered PRs as the triggering user (#1375)	2026-06-02 15:04:20 -07:00
test_slack_thread_reply_tool.py	feat: add Slack Block Kit reply options (#1407)	2026-06-04 10:26:09 -07:00
test_stale_sandbox_creating.py	fix: scope public reviewer tokens (#1389)	2026-06-03 09:25:17 -07:00
test_team_settings_org_guidelines.py	feat: inject org-wide guidelines into reviewer prompt (#1431)	2026-06-05 13:49:30 -07:00
test_user_mappings.py	fix: use Slack OIDC mappings for Slack thread ownership (#1410)	2026-06-04 19:58:30 +00:00