mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 19:43:15 +00:00
* feat(dashboard): restructure Open SWE Review tab + wire create_prs Restructures the dashboard around two related changes the reviewer settings have been asking for: - Wire profile.create_prs. Defaults to true (opt-out); when off the system prompt gets a `Pull Request Policy Override` section telling the agent to push the branch and notify with the branch URL instead of opening a PR. Removes the noop Slack Notifications / Allow Artifacts / First Name / Last Name controls and their schema fields. - Repositories opt-in for Open SWE Review. New per-team enabled list stored in the LangGraph Store (`["enabled_review_repos"]`). Every reviewer webhook chokepoint now goes through `_is_repo_enabled_for_review` which AND-combines the existing env allowlist with the dashboard list. Default is empty (opt-in) — admins enable repos per-installation from the new Repositories page nested under Open SWE Review. - Open SWE Review tab now mirrors the Cursor "rules" pattern: main page shows installation rows + a Rules entry; both drill into nested pages (/review/repositories/$owner and /review/styles) with a back link. - Adds the new logo/favicon assets shipped from sidebar + html head. Tests pass with a new autouse fixture (`tests/conftest.py`) that defaults `is_review_repo_enabled` to True for existing allowlist tests. * fix(dashboard): make main content scroll independently of the sidebar Outer flex container was min-h-svh, so it grew with main's content and the whole page scrolled — sidebar moved with it. Pin to h-svh + overflow-hidden so the sidebar stays put and only <main> scrolls. * fix(dashboard): make disabled repo toggles obviously disabled Switch's disabled state used opacity-50 against a muted background, so the not-admin state looked nearly identical to the off state. Bump to opacity-40 + grayscale, and wrap each repo toggle in a span carrying a native hover tooltip explaining why it's disabled. * fix(switch): handle base-ui's data-disabled state base-ui's Switch.Root sets data-disabled (not the HTML disabled attribute) when disabled, so Tailwind's disabled: variant never matches and the button keeps its cursor-pointer + clickable look. Mirror the styling under the data-[disabled] variant and add pointer-events-none so the disabled state is both visible and actually unclickable. * feat(dashboard): paginate per-installation repository list 20 repos per page with Prev / page X of Y / Next controls at the bottom. Pager only renders when there are more than 20 repos. Page resets to 0 when navigating between installations. * feat(dashboard): global default model selectors for Agent + Reviewer Adds team-wide default model + reasoning effort for both agents in the Admin tab so operators can switch models without redeploying. Resolution chain: Agent: hardcoded -> LLM_MODEL_ID env -> team default -> user profile Reviewer: hardcoded -> LLM_MODEL_ID env -> team default -> per-call configurable Team defaults live in team_settings and are validated against the SUPPORTED_MODELS allowlist + the model's supported reasoning efforts. 'Inherit from env' clears the override and falls back to LLM_MODEL_ID. * refactor(models): drop LLM_MODEL_ID env in favour of the team default The team default is now the single source of truth for the runtime model choice; per-user (agent) and per-call configurable (reviewer) selections still win on top. When no admin has touched the team default, it surfaces the hardcoded fallback (DEFAULT_MODEL_ID + its default effort), so the admin UI's dropdown is always pre-populated with a sensible value. The Admin UI loses the 'Inherit from env' option since there is no longer an env layer to inherit from. * chore(models): set hardcoded fallback to gpt-5.5 medium Decouple the team-default boot value (gpt-5.5 / medium) from each model's ProfileForm-suggested default_effort so we can change one without nudging the other. The Opus xhigh default for new user profiles is unchanged. * feat(dashboard): trigger-mode copy, Coming Soon badges, logout in My Settings - Rename trigger mode 'ready_for_review' -> 'once_per_pr' with new description copy that matches the screenshot. Legacy stored values fall back to 'every_push' on read so the UI never shows an unknown selection. - Add a 'Coming soon' badge + greyed-out + disabled state on the controls that don't have runtime consumers yet: Trigger Mode, Autofix Mode, Autofix Severity Threshold, and Automatically fix CI failures. SettingsRow grew a comingSoon prop to keep this consistent. - My Settings drops the noop PR Preferences section and adds a Sign Out button. preferred_pr_destination is removed from the profile schema; old records get the field popped on next write. --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
96 lines
3.3 KiB
Python
96 lines
3.3 KiB
Python
"""Profile lookup + override helpers consumed by ``agent.server.get_agent``."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from typing import Any
|
|
|
|
import httpx
|
|
from langgraph_sdk import get_client
|
|
|
|
from ..utils.github_user_email_map import GITHUB_USER_EMAIL_MAP
|
|
from .options import SUPPORTED_MODEL_IDS, model_supports_effort
|
|
from .profiles import PROFILES_NAMESPACE
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def resolve_login_from_email(email: str | None) -> str | None:
|
|
"""Reverse-lookup ``GITHUB_USER_EMAIL_MAP`` for the GitHub login of an email."""
|
|
if not isinstance(email, str) or not email.strip():
|
|
return None
|
|
normalized = email.strip().lower()
|
|
for gh_login, mapped in GITHUB_USER_EMAIL_MAP.items():
|
|
if mapped.lower() == normalized:
|
|
return gh_login
|
|
return None
|
|
|
|
|
|
def resolve_github_login(config: dict[str, Any]) -> str | None:
|
|
"""Best-effort resolution of the triggering user's GitHub login from config."""
|
|
configurable = (config or {}).get("configurable") or {}
|
|
|
|
login = configurable.get("github_login")
|
|
if isinstance(login, str) and login.strip():
|
|
return login.strip()
|
|
|
|
slack_thread = configurable.get("slack_thread") or {}
|
|
email = configurable.get("user_email") or slack_thread.get("triggering_user_email")
|
|
return resolve_login_from_email(email if isinstance(email, str) else None)
|
|
|
|
|
|
async def get_profile_default_repo(login: str | None) -> dict[str, str] | None:
|
|
"""Return ``{"owner", "name"}`` for the user's profile default_repo, if set."""
|
|
if not login:
|
|
return None
|
|
profile = await load_profile(login)
|
|
if not profile:
|
|
return None
|
|
default_repo = profile.get("default_repo")
|
|
if not isinstance(default_repo, str):
|
|
return None
|
|
parts = default_repo.strip().split("/", 1)
|
|
if len(parts) != 2:
|
|
return None
|
|
owner, name = parts[0].strip(), parts[1].strip()
|
|
if not owner or not name:
|
|
return None
|
|
return {"owner": owner, "name": name}
|
|
|
|
|
|
async def load_profile(login: str) -> dict[str, Any] | None:
|
|
try:
|
|
item = await get_client().store.get_item(PROFILES_NAMESPACE, login)
|
|
except httpx.HTTPStatusError as e:
|
|
if e.response.status_code == 404:
|
|
return None
|
|
logger.warning("profile lookup failed for %s: %s", login, e)
|
|
return None
|
|
if item is None:
|
|
return None
|
|
value = item.get("value") if isinstance(item, dict) else getattr(item, "value", None)
|
|
return value if isinstance(value, dict) else None
|
|
|
|
|
|
def profile_create_prs(profile: dict[str, Any] | None) -> bool:
|
|
"""Return whether the agent should automatically open a PR. Defaults to True."""
|
|
if not isinstance(profile, dict):
|
|
return True
|
|
value = profile.get("create_prs")
|
|
if isinstance(value, bool):
|
|
return value
|
|
return True
|
|
|
|
|
|
def normalize_profile_overrides(profile: dict[str, Any]) -> tuple[str | None, str | None]:
|
|
"""Return ``(model_id, reasoning_effort)`` if both are valid, else ``(None, None)``."""
|
|
model_id = profile.get("default_model")
|
|
effort = profile.get("reasoning_effort")
|
|
if (
|
|
isinstance(model_id, str)
|
|
and model_id in SUPPORTED_MODEL_IDS
|
|
and isinstance(effort, str)
|
|
and model_supports_effort(model_id, effort)
|
|
):
|
|
return model_id, effort
|
|
return None, None
|