mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 17:23:15 +00:00
* Adopt upstream modular webhook skeleton (#1621) Apply the durable-interrupt-dispatch refactor: split the monolithic webapp.py into a thin routing layer plus per-source handlers in webhooks/{github,slack,linear}.py, and add completion.py, dispatch.py, and reconcile.py. Reconcile fork divergence by keeping the Bedrock/ Fireworks cross-provider fallback, the no-agent-attribution prompt policy, the dashboard-handoff re-export, and the Slack channel-info cache. ci_autofix is restored on the new dispatch model in a later commit. Refs: #80 * Port fork webhook security delta onto modular handlers Re-apply the fork's security customizations that #1621 did not carry: Linear webhook replay protection (freshness window on the signed webhookTimestamp), per-repo token-cache binding threaded through the thread token resolvers, the INTERNAL_BOT_LOGINS self-check in the review-finding-reply path, and a user-mapping cache refresh before email resolution on the issue and PR-comment paths (multi-replica staleness). Existing fork security tests pass unchanged. Refs: #80 * Restore CI auto-fix on the modular dispatch model Bring back ci_autofix.py and the ci_monitor graph that #1621 deleted, re-wiring the fork's security-reviewed PR-babysitting onto the new structure: the CI-event, autofix-toggle, and review-feedback handlers move into webhooks/github.py and the github_webhook router re-gains the check_run/check_suite/workflow_run/status routing plus the autofix command and actionable-review branches. Auto-fix runs now dispatch through dispatch_agent_run (durability + completion webhook) while keeping the deliberate batch-while-busy skip-rule via get_thread_active_status. Restore langgraph.json's ci_monitor entry and the fork autofix tests (dispatch mock + import paths re-pointed). Refs: #80 * Reformat and update docs for the modular webhook split Point CLAUDE.md and deploy/MIGRATION.md at the new webhooks/ modules and the dispatch/completion/reconcile contract, and mark the user-mapping cache-refresh fix as applied on the GitHub handlers. Refs: #80 * Restore reject backstop for autofix dispatch A burst of near-simultaneous CI events for one head SHA can slip past the busy-check before the dedupe SHA is recorded, so dispatch the autofix path with multitask_strategy=reject (dev's prior platform default) to drop duplicate concurrent creates instead of letting them interrupt each other. Also make the completion failure-reply dedup claim-then-post and drop the unreachable interrupted branch. --------- Co-authored-by: amoussa1229 <166072409+amoussa1229@users.noreply.github.com>
93 lines
3.6 KiB
Python
93 lines
3.6 KiB
Python
"""Single durable dispatch contract behind every agent/reviewer run trigger.
|
|
|
|
Replaces the per-site ``runs.create`` calls (plus the ``is_thread_active``
|
|
busy-check and the custom store-queue) with one function that always uses:
|
|
|
|
- ``multitask_strategy="interrupt"`` — a follow-up halts the active run
|
|
(progress preserved by the sync checkpoint) and resumes the agent with full
|
|
history + the new message; on an idle thread it just starts. This is the
|
|
platform-native, cross-process replacement for the racy busy-check + queue.
|
|
- ``durability="sync"`` — checkpoint before each step so a crash/recycle
|
|
resumes from the last checkpoint instead of losing all work.
|
|
- ``webhook=COMPLETION_WEBHOOK_URL`` — the platform calls us on completion or
|
|
failure so every run ends with a signal even if the agent died.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from typing import Any
|
|
|
|
from langgraph_sdk import get_client
|
|
from langgraph_sdk.client import LangGraphClient
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
ContentBlocks = str | list[dict[str, Any]]
|
|
|
|
# Same-server FastAPI route the platform POSTs run completion/failure to. A
|
|
# relative URL loopback-posts into this app (no SSRF/loopback config needed);
|
|
# override with an absolute URL via env for split deployments. The route is
|
|
# fail-closed on RUN_COMPLETE_WEBHOOK_SECRET, so only register the webhook when
|
|
# the secret is set, appending it as ?token= so the route can verify the call
|
|
# came from us (completion.verify_run_complete_token). Unset → no webhook.
|
|
_COMPLETION_WEBHOOK_BASE = os.environ.get("COMPLETION_WEBHOOK_URL") or "/webhooks/run-complete"
|
|
_RUN_COMPLETE_SECRET = os.environ.get("RUN_COMPLETE_WEBHOOK_SECRET")
|
|
COMPLETION_WEBHOOK_URL: str | None
|
|
if not _RUN_COMPLETE_SECRET:
|
|
COMPLETION_WEBHOOK_URL = None
|
|
elif "?" in _COMPLETION_WEBHOOK_BASE:
|
|
COMPLETION_WEBHOOK_URL = _COMPLETION_WEBHOOK_BASE
|
|
else:
|
|
COMPLETION_WEBHOOK_URL = f"{_COMPLETION_WEBHOOK_BASE}?token={_RUN_COMPLETE_SECRET}"
|
|
|
|
|
|
def _langgraph_url() -> str:
|
|
return os.environ.get("LANGGRAPH_URL") or os.environ.get(
|
|
"LANGGRAPH_URL_PROD", "http://localhost:2024"
|
|
)
|
|
|
|
|
|
def dispatch_client() -> LangGraphClient:
|
|
return get_client(url=_langgraph_url())
|
|
|
|
|
|
async def dispatch_agent_run(
|
|
thread_id: str,
|
|
content: ContentBlocks,
|
|
configurable: dict[str, Any],
|
|
*,
|
|
source: str,
|
|
assistant_id: str = "agent",
|
|
metadata: dict[str, Any] | None = None,
|
|
client: LangGraphClient | None = None,
|
|
multitask_strategy: str = "interrupt",
|
|
) -> dict[str, Any]:
|
|
"""Create (or interrupt-and-resume) a run for ``thread_id``.
|
|
|
|
Routes every Slack / Linear / GitHub / dashboard trigger through one
|
|
contract. ``source`` is for logging/metadata only; ``assistant_id`` selects
|
|
the graph (``"agent"`` or ``"reviewer"``). ``multitask_strategy`` defaults to
|
|
``"interrupt"`` (human follow-ups halt + resume); autofix passes ``"reject"``
|
|
so a burst of concurrent CI events for one head SHA can't interrupt each other.
|
|
"""
|
|
client = client or dispatch_client()
|
|
run = await client.runs.create(
|
|
thread_id,
|
|
assistant_id,
|
|
input={"messages": [{"role": "user", "content": content}]},
|
|
config={"configurable": configurable, "metadata": metadata or {}},
|
|
multitask_strategy=multitask_strategy,
|
|
durability="sync",
|
|
webhook=COMPLETION_WEBHOOK_URL,
|
|
if_not_exists="create",
|
|
)
|
|
logger.info(
|
|
"Dispatched %s run on thread %s (source=%s, run=%s)",
|
|
assistant_id,
|
|
thread_id,
|
|
source,
|
|
run.get("run_id") if isinstance(run, dict) else None,
|
|
)
|
|
return run
|