mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 15:03:16 +00:00
Adam Moussa
ae1f883b4c
Applies the plan's C5 step: git mv every test per the domain-reorg
move-map (movemap-m50.txt) into tests/{agent,analyzer,auth,dashboard,
github,middleware,models,reviewer,sandbox,slack,tools,webhooks}/, plus
the 13 fork-only placements from the scoping report §2c (Atlassian
webhook tests -> tests/webhooks/, test_atlassian_connect.py and
test_auth_error_leak.py -> tests/auth/, jira/confluence util tests ->
tests/tools/, test_repo_binding_isolation.py -> tests/sandbox/,
bot-identity/autofix tests -> tests/github/).
Path-only move: the only content edits are parents[1] -> parents[2]
fixes in test_e2b_integration.py and test_daytona_integration.py,
required because their __file__-relative ROOT path gained one more
directory level in the move.
Monkeypatch retargets for these files were already completed in C4;
none remained outstanding here.
76 lines
2.7 KiB
Python
76 lines
2.7 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import Any
|
|
|
|
from langchain_core.messages import ToolMessage
|
|
|
|
from agent.middleware.pr_creation_guard import (
|
|
PullRequestCreationGuardMiddleware,
|
|
is_pr_creation_fallback_command,
|
|
)
|
|
|
|
|
|
class _Request:
|
|
def __init__(self, command: str) -> None:
|
|
self.tool_call = {
|
|
"name": "execute",
|
|
"args": {"command": command},
|
|
"id": "call-1",
|
|
}
|
|
|
|
|
|
async def _handler(_request: Any) -> ToolMessage:
|
|
return ToolMessage(content="allowed", tool_call_id="call-1")
|
|
|
|
|
|
def test_detects_pr_creation_fallback_commands() -> None:
|
|
assert is_pr_creation_fallback_command("GH_TOKEN=dummy gh pr create --draft")
|
|
assert is_pr_creation_fallback_command(
|
|
"gh api repos/langchain-ai/open-swe/pulls -X POST -f title=x"
|
|
)
|
|
assert is_pr_creation_fallback_command(
|
|
"gh api -X POST repos/langchain-ai/open-swe/pulls -f title=x"
|
|
)
|
|
assert is_pr_creation_fallback_command(
|
|
"GH_TOKEN=dummy gh api -X POST repos/langchain-ai/open-swe/pulls -f title=x"
|
|
)
|
|
assert is_pr_creation_fallback_command(
|
|
"curl -X POST https://api.github.com/repos/langchain-ai/open-swe/pulls -d '{}'"
|
|
)
|
|
|
|
|
|
def test_allows_safe_pr_commands() -> None:
|
|
assert not is_pr_creation_fallback_command("GH_TOKEN=dummy gh pr view 1 --json url")
|
|
assert not is_pr_creation_fallback_command("gh pr list --head open-swe/foo")
|
|
assert not is_pr_creation_fallback_command("gh pr edit 1 --add-label ready")
|
|
assert not is_pr_creation_fallback_command("gh pr comment 1 --body done")
|
|
|
|
|
|
async def test_middleware_blocks_execute_pr_creation_fallbacks() -> None:
|
|
for command in (
|
|
"GH_TOKEN=dummy gh pr create --draft",
|
|
"gh api repos/langchain-ai/open-swe/pulls -X POST -f title=x",
|
|
"GH_TOKEN=dummy gh api -X POST repos/langchain-ai/open-swe/pulls -f title=x",
|
|
"curl -X POST https://api.github.com/repos/langchain-ai/open-swe/pulls -d '{}'",
|
|
):
|
|
result = await PullRequestCreationGuardMiddleware().awrap_tool_call(
|
|
_Request(command), _handler
|
|
)
|
|
|
|
assert isinstance(result, ToolMessage)
|
|
assert result.status == "error"
|
|
payload = json.loads(str(result.content))
|
|
assert payload["code"] == "pr_creation_fallback_blocked"
|
|
assert payload["recoverable_by_agent"] is False
|
|
assert "open_pull_request" in payload["error"]
|
|
assert payload["blocked_command"] == command
|
|
|
|
|
|
async def test_middleware_allows_safe_pr_view() -> None:
|
|
result = await PullRequestCreationGuardMiddleware().awrap_tool_call(
|
|
_Request("GH_TOKEN=dummy gh pr view 1 --json url"), _handler
|
|
)
|
|
|
|
assert isinstance(result, ToolMessage)
|
|
assert result.content == "allowed"
|