open-swe/tests/e2e/tests/sandbox_id.spec.ts
Adam Moussa bc59c05642
feat(dashboard): surface thread sandbox ID in sidebar (#169)
* feat(dashboard): surface thread sandbox ID in sidebar

Port of upstream #1689 (feb7ac98): expose the thread's sandbox_id on the
dashboard thread summary and surface it in the sidebar via a "Copy sandbox
ID" action.

- thread_api: add sandboxId to the thread summary, hiding the
  "__creating__" in-flight sentinel.
- queries/types: thread the sandboxId field through AgentThread and the
  optimistic thread.
- AgentsSidebar: replace the hover-only resolve/delete buttons and the
  right-click context menu with one touch-friendly kebab (⋮) menu that
  works on both pointer and touch, and add the Copy sandbox ID item.
- vite: disable the PWA service worker in dev (it precaches assets and
  defeats HMR).
- tests: unit test for the summary field + e2e spec in the real-backend
  harness.

Closes #140. Part of #134.

* chore(triage): mark feb7ac98 (#1689) landed

Ported to dev via feat/thread-sandbox-id-sidebar (#140).
2026-07-10 13:17:03 -04:00

115 lines
4.2 KiB
TypeScript

import { test, expect, type Locator, type Page } from "@playwright/test";
// Exercises the sidebar's "Copy sandbox ID" action against the REAL dashboard
// UI and a REAL (local-provider) sandbox: the Slack flow runs the agent, which
// creates a sandbox and stamps its id into the thread metadata, and the UI
// copies that same id. Only the LLM/GitHub/Slack boundaries are faked.
const SAME_USER = { login: "alice", email: "alice@example.com" };
async function loginAs(page: Page, user: { login: string; email: string }) {
const res = await page.request.post("/control/login", { data: user });
expect(res.ok()).toBeTruthy();
}
// Drive the Slack flow so the real agent creates a thread + sandbox, then follow
// the bot's "Open in Web" link. Returns the created thread id.
async function createThreadWithSandbox(page: Page): Promise<string> {
await page.goto("/mock/slack");
await page.locator("#reset").click();
await expect(page.locator("#thread")).toContainText("No messages yet");
await page
.locator("#text")
.fill("<@U0BOT> please add a greet() helper and open a PR");
await page.locator("#send").click();
await expect(
page.locator(".msg.bot").filter({ hasText: "Add greet() helper" }),
).toBeVisible();
const webLink = page.locator('.msg.bot a[href*="/agents/"]').first();
await expect(webLink).toBeVisible();
await webLink.click();
await expect(page).toHaveURL(/\/agents\//);
const id = new URL(page.url()).pathname.split("/").filter(Boolean).pop();
expect(id).toBeTruthy();
return id as string;
}
const copyItem = (page: Page) =>
page.getByRole("menuitem", { name: "Copy sandbox ID" });
// The kebab sits beside the row Link (not inside the anchor), so reach it via
// their shared wrapper — the Link's parent.
const kebabFor = (row: Locator) =>
row.locator("..").getByRole("button", { name: "Thread actions" });
test.describe("thread sandbox id (real dashboard UI)", () => {
test("desktop: kebab menu copies the real sandbox id", async ({
page,
baseURL,
}) => {
await page
.context()
.grantPermissions(["clipboard-read", "clipboard-write"], {
origin: baseURL,
});
await loginAs(page, SAME_USER);
const threadId = await createThreadWithSandbox(page);
const row = page.locator(`a[href$="/agents/${threadId}"]`).first();
await expect(row).toBeVisible();
// The kebab is revealed on hover on pointer devices.
await row.hover();
await kebabFor(row).click();
await expect(copyItem(page)).toBeEnabled();
await copyItem(page).click();
const clip = await page.evaluate(() => navigator.clipboard.readText());
expect(clip.length).toBeGreaterThan(0);
});
test("iPad: kebab copies the sandbox id without navigating", async ({
browser,
baseURL,
}) => {
// iPad-class device: Chromium in mobile mode reports (hover: none), which
// gates the touch-only kebab. 834px is wider than the 767px mobile
// breakpoint, so the sidebar renders inline.
const context = await browser.newContext({
baseURL,
viewport: { width: 834, height: 1112 },
isMobile: true,
hasTouch: true,
});
await context.grantPermissions(["clipboard-read", "clipboard-write"], {
origin: baseURL,
});
const page = await context.newPage();
await loginAs(page, SAME_USER);
// Two threads: we sit on B's page and act on A's sidebar row, so a stray
// Link navigation would be observable as a URL change to A.
const threadA = await createThreadWithSandbox(page);
const threadB = await createThreadWithSandbox(page);
await expect(page).toHaveURL(new RegExp(`/agents/${threadB}$`));
const rowA = page.locator(`a[href$="/agents/${threadA}"]`).first();
await expect(rowA).toBeVisible();
const kebab = kebabFor(rowA);
await expect(kebab).toBeVisible();
await kebab.tap();
await expect(copyItem(page)).toBeEnabled();
await copyItem(page).tap();
const clip = await page.evaluate(() => navigator.clipboard.readText());
expect(clip.length).toBeGreaterThan(0);
// Tapping the kebab must open the menu, not follow A's Link — we stay on B.
await expect(page).toHaveURL(new RegExp(`/agents/${threadB}$`));
await context.close();
});
});