mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 19:43:15 +00:00
Adam Moussa
ae1f883b4c
Applies the plan's C5 step: git mv every test per the domain-reorg
move-map (movemap-m50.txt) into tests/{agent,analyzer,auth,dashboard,
github,middleware,models,reviewer,sandbox,slack,tools,webhooks}/, plus
the 13 fork-only placements from the scoping report §2c (Atlassian
webhook tests -> tests/webhooks/, test_atlassian_connect.py and
test_auth_error_leak.py -> tests/auth/, jira/confluence util tests ->
tests/tools/, test_repo_binding_isolation.py -> tests/sandbox/,
bot-identity/autofix tests -> tests/github/).
Path-only move: the only content edits are parents[1] -> parents[2]
fixes in test_e2b_integration.py and test_daytona_integration.py,
required because their __file__-relative ROOT path gained one more
directory level in the move.
Monkeypatch retargets for these files were already completed in C4;
none remained outstanding here.
118 lines
4.5 KiB
Python
118 lines
4.5 KiB
Python
from __future__ import annotations
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
from langchain_core.messages import AIMessage, HumanMessage, ToolMessage
|
|
|
|
from agent.middleware.sanitize_fireworks_messages import SanitizeFireworksMessagesMiddleware
|
|
|
|
|
|
def _make_request(messages: list[object], model: object | None = None) -> MagicMock:
|
|
request = MagicMock()
|
|
request.model = model
|
|
request.messages = messages
|
|
return request
|
|
|
|
|
|
def _fireworks_model() -> MagicMock:
|
|
"""A mock that satisfies ``_is_chat_fireworks`` via spec'd ``ChatFireworks``."""
|
|
try:
|
|
from langchain_fireworks.chat_models import ChatFireworks
|
|
except ImportError: # pragma: no cover
|
|
pytest.skip("langchain-fireworks not installed")
|
|
return MagicMock(spec=ChatFireworks)
|
|
|
|
|
|
class TestSanitizeFireworksMessagesMiddleware:
|
|
def test_drops_legacy_function_call(self) -> None:
|
|
message = AIMessage(
|
|
content="",
|
|
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
|
|
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
|
|
)
|
|
request = _make_request([message], model=_fireworks_model())
|
|
response = MagicMock()
|
|
|
|
def handler(req: object) -> object:
|
|
assert req is request
|
|
return response
|
|
|
|
result = SanitizeFireworksMessagesMiddleware().wrap_model_call(request, handler)
|
|
|
|
assert result is response
|
|
assert "function_call" not in message.additional_kwargs
|
|
# tool_calls are untouched
|
|
assert len(message.tool_calls) == 1
|
|
|
|
def test_preserves_message_without_function_call(self) -> None:
|
|
message = AIMessage(
|
|
content="ok",
|
|
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
|
|
)
|
|
request = _make_request([message], model=_fireworks_model())
|
|
|
|
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
|
|
|
|
assert "function_call" not in message.additional_kwargs
|
|
assert len(message.tool_calls) == 1
|
|
|
|
def test_drops_function_call_with_no_tool_calls(self) -> None:
|
|
message = AIMessage(
|
|
content="",
|
|
additional_kwargs={"function_call": {"name": "search", "arguments": "{}"}},
|
|
)
|
|
request = _make_request([message], model=_fireworks_model())
|
|
|
|
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
|
|
|
|
assert "function_call" not in message.additional_kwargs
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_async_drops_legacy_function_call(self) -> None:
|
|
tool_result = ToolMessage(content="result", tool_call_id="tc1")
|
|
message = AIMessage(
|
|
content="",
|
|
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
|
|
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
|
|
)
|
|
request = _make_request(
|
|
[HumanMessage(content="hi"), message, tool_result],
|
|
model=_fireworks_model(),
|
|
)
|
|
response = MagicMock()
|
|
|
|
async def handler(req: object) -> object:
|
|
assert req is request
|
|
return response
|
|
|
|
result = await SanitizeFireworksMessagesMiddleware().awrap_model_call(request, handler)
|
|
|
|
assert result is response
|
|
assert "function_call" not in message.additional_kwargs
|
|
|
|
def test_ignores_non_fireworks_models(self) -> None:
|
|
message = AIMessage(
|
|
content="",
|
|
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
|
|
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
|
|
)
|
|
# Non-Fireworks model (plain MagicMock, no ChatFireworks in its spec chain)
|
|
request = _make_request([message], model=MagicMock())
|
|
|
|
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
|
|
|
|
# function_call preserved for non-Fireworks providers
|
|
assert "function_call" in message.additional_kwargs
|
|
|
|
def test_skips_non_ai_messages(self) -> None:
|
|
messages = [
|
|
HumanMessage(content="hi"),
|
|
ToolMessage(content="result", tool_call_id="tc1"),
|
|
]
|
|
request = _make_request(messages, model=_fireworks_model())
|
|
|
|
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
|
|
|
|
# No AIMessages to mutate — handler still called
|
|
assert all(not isinstance(m, AIMessage) for m in messages)
|