open-swe/tests/agent/test_agent_assembly_context.py
Adam Moussa ae1f883b4c
refactor: move tests into tests/<domain>/ layout
Applies the plan's C5 step: git mv every test per the domain-reorg
move-map (movemap-m50.txt) into tests/{agent,analyzer,auth,dashboard,
github,middleware,models,reviewer,sandbox,slack,tools,webhooks}/, plus
the 13 fork-only placements from the scoping report §2c (Atlassian
webhook tests -> tests/webhooks/, test_atlassian_connect.py and
test_auth_error_leak.py -> tests/auth/, jira/confluence util tests ->
tests/tools/, test_repo_binding_isolation.py -> tests/sandbox/,
bot-identity/autofix tests -> tests/github/).

Path-only move: the only content edits are parents[1] -> parents[2]
fixes in test_e2b_integration.py and test_daytona_integration.py,
required because their __file__-relative ROOT path gained one more
directory level in the move.

Monkeypatch retargets for these files were already completed in C4;
none remained outstanding here.
2026-07-17 14:42:45 -04:00

123 lines
4.4 KiB
Python

"""Assembly contract for the main agent's context-management + middleware wiring.
Locks in that `get_agent` hands a sandbox `backend` to `create_deep_agent` (which
is what makes deepagents auto-wire `FilesystemMiddleware` tool-result eviction and
`SummarizationMiddleware` history offloading), and that the redundant custom
`RepairOrphanedToolCallsMiddleware` is no longer added explicitly — the built-in
`PatchToolCallsMiddleware` that `create_deep_agent` adds covers it.
"""
from __future__ import annotations
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from langgraph.graph.state import RunnableConfig
from agent.server import get_agent
class _DummyAgent:
def with_config(self, config: RunnableConfig) -> _DummyAgent:
self.config = config
return self
def _base_config() -> RunnableConfig:
return {
"configurable": {
"__is_for_execution__": True,
"thread_id": "thread-ctx",
"github_login": "octocat",
},
"metadata": {},
}
async def _capture_create_deep_agent_kwargs() -> dict[str, object]:
captured: dict[str, object] = {}
def fake_create_deep_agent(**kwargs: object) -> _DummyAgent:
captured.update(kwargs)
return _DummyAgent()
with (
patch(
"agent.server.resolve_github_token",
new_callable=AsyncMock,
return_value=("ghp", None),
),
patch("agent.server.resolve_triggering_user_identity", return_value=None),
patch(
"agent.server.ensure_sandbox_for_thread",
new_callable=AsyncMock,
return_value=MagicMock(),
),
patch(
"agent.server.aresolve_sandbox_work_dir",
new_callable=AsyncMock,
return_value="/workspace",
),
patch(
"agent.server.get_team_default_model_pair",
new_callable=AsyncMock,
return_value=(("openai:gpt-5.5", "medium"), ("openai:gpt-5.5", "low")),
),
patch("agent.server.load_profile", new_callable=AsyncMock, return_value=None),
patch("agent.server.fallback_model_id_for", return_value=None),
patch("agent.utils.deferred_model.make_model", side_effect=[MagicMock(), MagicMock()]),
patch("agent.server.construct_system_prompt", return_value="prompt"),
patch("agent.server.create_deep_agent", side_effect=fake_create_deep_agent),
):
await get_agent(_base_config())
return captured
@pytest.mark.asyncio
async def test_agent_is_built_with_a_backend_for_eviction_and_summarization() -> None:
captured = await _capture_create_deep_agent_kwargs()
# The backend is what enables deepagents' auto-wired FilesystemMiddleware
# eviction + SummarizationMiddleware offloading.
assert callable(captured["backend"])
@pytest.mark.asyncio
async def test_agent_does_not_add_custom_repair_middleware() -> None:
captured = await _capture_create_deep_agent_kwargs()
middleware = captured["middleware"]
assert isinstance(middleware, list)
names = {type(m).__name__ for m in middleware}
# Built-in PatchToolCallsMiddleware (added by create_deep_agent) replaces it.
assert "RepairOrphanedToolCallsMiddleware" not in names
@pytest.mark.asyncio
async def test_agent_wires_subdir_agents_middleware_after_tool_error() -> None:
captured = await _capture_create_deep_agent_kwargs()
middleware = captured["middleware"]
assert isinstance(middleware, list)
names = [type(m).__name__ for m in middleware]
assert "SubdirAgentsReadMiddleware" in names
assert names.index("ToolErrorMiddleware") < names.index("SubdirAgentsReadMiddleware")
@pytest.mark.asyncio
async def test_agent_keeps_message_queue_and_step_limit_middleware() -> None:
captured = await _capture_create_deep_agent_kwargs()
middleware = captured["middleware"]
# The dashboard depends on check_message_queue_before_model; the step-limit
# notifier must still fire when the lowered run budget is hit.
present = {type(m).__name__ for m in middleware}
assert "check_message_queue_before_model" in present
assert "notify_step_limit_reached" in present
@pytest.mark.asyncio
async def test_agent_includes_report_platform_issue_tool() -> None:
from agent.tools import report_platform_issue
captured = await _capture_create_deep_agent_kwargs()
tools = captured["tools"]
assert isinstance(tools, list)
assert report_platform_issue in tools