mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 23:13:15 +00:00
5702a9d452
* feat: reconcile reviewer comment lifecycle Track GitHub review threads for reviewer findings so re-reviews can resolve or reply to existing comments, and collect thumbs feedback on new review comments in LangSmith. * fix: clarify reviewer comment lifecycle * chore: apply reviewer formatting --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
75 lines
2.4 KiB
Python
75 lines
2.4 KiB
Python
from __future__ import annotations
|
|
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from agent.reviewer_reconcile import reconcile_findings_with_review_threads
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reconcile_marks_resolved_github_thread_resolved() -> None:
|
|
findings = [
|
|
{
|
|
"id": "f1",
|
|
"status": "open",
|
|
"github_review_comment_id": 11,
|
|
"github_review_thread_id": "THREAD_1",
|
|
}
|
|
]
|
|
replace = AsyncMock()
|
|
|
|
with (
|
|
patch("agent.reviewer_reconcile.list_findings", AsyncMock(return_value=findings)),
|
|
patch("agent.reviewer_reconcile.replace_findings", replace),
|
|
):
|
|
result = await reconcile_findings_with_review_threads(
|
|
"tid",
|
|
[
|
|
{
|
|
"id": "THREAD_1",
|
|
"is_resolved": True,
|
|
"is_outdated": False,
|
|
"comments": [{"id": 11, "author": "open-swe[bot]", "body": "bug"}],
|
|
}
|
|
],
|
|
)
|
|
|
|
assert result[0]["status"] == "resolved"
|
|
assert result[0]["github_thread_resolved"] is True
|
|
replace.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reconcile_records_latest_human_reply_after_bot_comment() -> None:
|
|
findings = [{"id": "f1", "status": "open", "github_review_comment_id": 11}]
|
|
replace = AsyncMock()
|
|
|
|
with (
|
|
patch("agent.reviewer_reconcile.list_findings", AsyncMock(return_value=findings)),
|
|
patch("agent.reviewer_reconcile.replace_findings", replace),
|
|
):
|
|
result = await reconcile_findings_with_review_threads(
|
|
"tid",
|
|
[
|
|
{
|
|
"id": "THREAD_1",
|
|
"is_resolved": False,
|
|
"is_outdated": False,
|
|
"comments": [
|
|
{"id": 11, "author": "open-swe[bot]", "body": "bug"},
|
|
{
|
|
"id": 12,
|
|
"author": "human",
|
|
"body": "This is not valid because the caller already guards it.",
|
|
"created_at": "2026-05-26T10:00:00Z",
|
|
},
|
|
],
|
|
}
|
|
],
|
|
)
|
|
|
|
assert result[0]["github_review_thread_id"] == "THREAD_1"
|
|
assert result[0]["last_human_reply_author"] == "human"
|
|
assert "not valid" in result[0]["last_human_reply_body"]
|
|
replace.assert_awaited_once()
|