open-swe/agent/tools/slack_thread_reply.py
Johannes du Plessis 209132d355
refactor: durable interrupt dispatch + completion webhook (#1621)
* wip(rebuild): core reliability spine

- remove PR-babysitting (ci_autofix + ci_monitor graph + webhook wiring)
- dispatch core: agent/dispatch.py with multitask_strategy=interrupt +
  durability=sync + completion webhook; reroute all webhook + plan triggers;
  drop the racy in-process lock + is_thread_active busy-check
- completion webhook: agent/completion.py + /webhooks/run-complete loopback
  route for failure/timeout replies (idempotent)

Co-authored-by: open-swe[bot]

* feat(rebuild): async tools, reconcile, shared http timeouts, assembly tuning

Parallel batch on top of the reliability spine:
- async-ify all 24 tools (drop asyncio.run; requests->httpx); re-implement the
  http_request/fetch_url SSRF + DNS-rebinding defense httpx-natively and harden
  the IP check to 'not is_global' (+ IPv4-mapped unwrap)
- reconcile.py: stale pending-run sweep (threads.search -> per-thread runs.list
  -> cancel_many), wired into the scheduler graph via task='reconcile'
- shared DEFAULT_HTTP_TIMEOUT (agent/utils/http.py) on every bare
  httpx.AsyncClient() across utils/dashboard/webapp/middleware
- run budget: MODEL_CALL_RECURSION_LIMIT 5000->250
- fix stale OpenAI->Anthropic fallback id (claude-opus-4-5 -> 4-8)
- drop redundant custom repair middleware (deepagents auto-adds PatchToolCalls)
- confirm tool-result eviction + summarization auto-wired via backend
- slim system prompt ~8% (full harness-profile rewrite deferred)

Co-authored-by: open-swe[bot]

* feat(rebuild): harness-profile prompt + split webhooks out of webapp

- prompt.py: own the system prompt via a registered harness profile
  (OPEN_SWE_SHARED_BASE, kept neutral so the read-only reviewer/analyzer that
  share it stay safe), registered across all 4 providers; per-thread values
  stay in construct_system_prompt. Assembled main-agent prompt ~6.8k -> ~3.1k
  tokens (~55% smaller); de-duped PR/commit/suite/force-push guidance; dropped
  ALL-CAPS markers.
- webapp.py 3325 -> 1890 LOC: moved 14 per-source handlers into
  agent/webhooks/{linear,slack,github}.py; webapp re-exports them for the
  routes + tests; moved handlers reach shared helpers via the webapp namespace
  to preserve the test suite's monkeypatch targets.

Full suite: 1168 passing, lint clean.

Co-authored-by: open-swe[bot]

* Restore MODEL_CALL_RECURSION_LIMIT to 5000 for long-running tasks

Reverts the 250 cap from the run-budget change — long-running tasks legitimately
need many model calls. The notify_step_limit_reached safety net still fires if a
run does hit the cap, so runs end with a signal either way.

Co-authored-by: open-swe[bot]

* fix: address PR review (auth, SSRF, interrupted status, redirect headers)

- completion.py: drop `interrupted` from failure statuses — with
  multitask_strategy=interrupt a follow-up ends the prior run as interrupted,
  which is healthy, not a failure to report. [open-swe]
- /webhooks/run-complete: shared-secret auth — dispatch appends ?token= when
  RUN_COMPLETE_WEBHOOK_SECRET is set; route verifies via hmac.compare_digest.
  [corridor-security]
- SSRF: extract the URL validator to agent/utils/url_safety.py and apply it
  before server-side image fetches in multimodal.fetch_image_block.
  [corridor-security]
- http_request: preserve caller headers/extensions across redirect hops instead
  of dropping them on the first hop. [open-swe]

Co-authored-by: open-swe[bot]

* chore: remove REBUILD_PLAN.md (planning doc, not needed in the repo)

Co-authored-by: open-swe[bot]

* fix: fail closed on run-complete webhook auth when secret unset

Corridor follow-up: verify_run_complete_token returns False (not True) when
RUN_COMPLETE_WEBHOOK_SECRET is unset, so the public route is never
unauthenticated. Logs a startup warning when the secret is absent, and dispatch
skips registering the webhook when there's no secret (no rejected callbacks).

Co-authored-by: open-swe[bot]

---------

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
2026-06-26 13:48:38 -07:00

202 lines
8.3 KiB
Python

import json
import os
from typing import Any
from langgraph.config import get_config
from langgraph_sdk import get_client
from ..utils.slack import (
convert_mentions_to_slack_format,
post_slack_thread_reply_with_ts,
store_slack_message_run_mapping,
)
LANGGRAPH_URL = os.environ.get("LANGGRAPH_URL") or os.environ.get(
"LANGGRAPH_URL_PROD", "http://localhost:2024"
)
async def slack_thread_reply(
message: str,
options: list[str] | None = None,
blocks: list[dict[str, Any]] | None = None,
plan_approval: bool = False,
) -> dict[str, Any]:
"""Post a message to the current Slack thread.
Use this for clarifying questions, mid-run progress updates, and the final
summary. You can call this multiple times during a run — if you're about to
do long-running work (cloning, large refactors, big test runs) consider
posting a brief status update first so the user knows what's happening.
Always end the run with a final reply summarizing what you did.
Format messages using Slack's mrkdwn format, NOT standard Markdown.
Key differences: *bold*, _italic_, ~strikethrough~, <url|link text>,
bullet lists with "• ", ```code blocks```, > blockquotes.
Do NOT use **bold**, [link](url), or other standard Markdown syntax.
To ask a user to choose from predefined options, pass `options`. Slack will
render interactive buttons and the web UI will render the same choices.
The user can still reply manually in the Slack thread.
To present a plan for approval with action buttons, pass plan_approval=True. This renders "Approve & Implement", "Revise Plan", and "Cancel" buttons. The plan itself should be posted to the dashboard thread; use this to post a summary with a link to the dashboard thread view where the full plan can be reviewed.
To mention/tag a user, use Slack's mention format: <@USER_ID>.
You can find user IDs in the conversation context (e.g. @Name(U06KD8BFY95)).
Example: <@U06KD8BFY95> will tag that user in the message."""
config = get_config()
configurable = config.get("configurable", {})
slack_thread = configurable.get("slack_thread", {})
channel_id = slack_thread.get("channel_id")
thread_ts = slack_thread.get("thread_ts")
if not channel_id or not thread_ts:
return {
"success": False,
"error": "Missing slack_thread.channel_id or slack_thread.thread_ts in config",
}
if not message.strip():
return {"success": False, "error": "Message cannot be empty"}
message = convert_mentions_to_slack_format(message)
if plan_approval:
slack_blocks = _build_plan_approval_blocks(message)
else:
slack_blocks = blocks or _build_option_blocks(message, options)
message_ts, slack_error = await _post_and_store_mapping(
channel_id, thread_ts, message, blocks=slack_blocks
)
if message_ts is None:
return {
"success": False,
"error": slack_error or "post failed",
"slack_error": slack_error,
"message_chars": len(message),
"hint": _slack_reply_failure_hint(slack_error),
}
return {"success": True}
def _build_option_blocks(message: str, options: list[str] | None) -> list[dict[str, Any]] | None:
if not options:
return None
clean_options = [option.strip() for option in options if option.strip()]
if not clean_options:
return None
return [
{"type": "section", "text": {"type": "mrkdwn", "text": message}},
{
"type": "actions",
"elements": [
{
"type": "button",
"text": {"type": "plain_text", "text": option[:75], "emoji": True},
"value": json.dumps({"type": "open_swe_option", "response": option}),
"action_id": "open_swe_option_select",
}
for option in clean_options[:5]
],
},
]
def _build_plan_approval_blocks(message: str) -> list[dict[str, Any]]:
return [
{"type": "section", "text": {"type": "mrkdwn", "text": message}},
{
"type": "actions",
"elements": [
{
"type": "button",
"text": {"type": "plain_text", "text": "Approve & Implement", "emoji": True},
"style": "primary",
"value": json.dumps({"type": "plan_approval", "action": "approve"}),
"action_id": "open_swe_option_select",
},
{
"type": "button",
"text": {"type": "plain_text", "text": "Revise Plan", "emoji": True},
"value": json.dumps({"type": "plan_approval", "action": "revise"}),
"action_id": "open_swe_option_select",
},
{
"type": "button",
"text": {"type": "plain_text", "text": "Cancel", "emoji": True},
"style": "danger",
"value": json.dumps({"type": "plan_approval", "action": "cancel"}),
"action_id": "open_swe_option_select",
},
],
},
]
def build_workflow_approval_blocks(message: str, fingerprint: str) -> list[dict[str, Any]]:
return [
{"type": "section", "text": {"type": "mrkdwn", "text": message}},
{
"type": "actions",
"elements": [
{
"type": "button",
"text": {"type": "plain_text", "text": "Approve workflow push", "emoji": True},
"style": "primary",
"value": json.dumps(
{
"type": "workflow_push_approval",
"action": "approve",
"fingerprint": fingerprint,
}
),
"action_id": "open_swe_option_select",
},
{
"type": "button",
"text": {"type": "plain_text", "text": "Reject", "emoji": True},
"style": "danger",
"value": json.dumps(
{
"type": "workflow_push_approval",
"action": "reject",
"fingerprint": fingerprint,
}
),
"action_id": "open_swe_option_select",
},
],
},
]
def _slack_reply_failure_hint(slack_error: str | None) -> str:
if slack_error == "msg_too_long":
return "Slack rejected the message as too long; retry with a shorter message."
if slack_error in {"channel_not_found", "not_in_channel"}:
return "Slack rejected the channel; do not retry. Surface the failure to the user via the trace output instead."
if slack_error and slack_error.startswith("rate_limited"):
retry_after = slack_error.partition(":")[2].strip()
if retry_after:
return f"Slack rate limited the request; wait at least {retry_after}s before retrying, or surface the failure to the user via the trace output."
return "Slack rate limited the request; wait before retrying, or surface the failure to the user via the trace output."
if slack_error == "missing_slack_bot_token":
return "Slack bot token is missing; do not retry. Surface the failure to the user via the trace output instead."
if slack_error and slack_error.startswith("http_error:"):
return "Slack posting hit an HTTP error; retry once, then surface the failure to the user via the trace output."
return "Slack post failed; retry once with a concise message or surface the failure to the user via the trace output."
async def _post_and_store_mapping(
channel_id: str,
thread_ts: str,
message: str,
*,
blocks: list[dict[str, Any]] | None = None,
) -> tuple[str | None, str | None]:
message_ts, slack_error = await post_slack_thread_reply_with_ts(
channel_id, thread_ts, message, blocks=blocks
)
if message_ts:
langgraph_client = get_client(url=LANGGRAPH_URL)
await store_slack_message_run_mapping(langgraph_client, channel_id, thread_ts, message_ts)
return message_ts, slack_error