mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 05:43:14 +00:00
Adam Moussa
b3fc62da80
Plan step C4 (docs/upstream-sync/domain-reorg/reorg-build-plan.md, approved
decisions 1-2): split the 2,590-line agent/webapp.py monolith into
agent/webhooks/common.py (shared verify/dispatch helpers), agent/api/app.py
(composition), agent/api/health.py (/health + /webhooks/run-complete), and
per-source {github,linear,slack,jira,confluence}_routes.py. Atlassian
Connect lifecycle + descriptor routes (/connect/*) fold into
confluence_routes.py; webapp.py becomes the upstream-shaped compatibility
shim (from .api.app import app). langgraph.json http.app stays
agent.webapp:app via the shim.
Fork content, upstream layout: linear/slack route files verified
content-identical to upstream 8356eb34 and taken verbatim; github_routes is
upstream + the fork's CI auto-fix trigger wiring; jira/confluence routes are
fork-only, transformed to the same common.X / service.X module-attribute
style. All signature verification (GitHub HMAC, Slack, Linear
timestamp-freshness, verify_jira_secret + opt-in HMAC/timestamp/IP
allowlist, Connect JWT/qsh), token-attribution gating, TID-COLLIDE-01 repo
binding, _is_repo_auto_review_enabled gates, and public-repo org gate move
unchanged.
Handlers rewired from webapp.X to common.X; test monkeypatch sites across
26 files + conftest.py + e2e/harness.py retargeted to
webhook_common/handler/route modules per upstream's pattern. Residual
agent.webapp importers: only the shim, langgraph.json http.app, Makefile
uvicorn target, and docs (doc-path updates land in C7).
Gates: ruff check + format, pytest --co, full unit (1637 passed), full
Playwright E2E vs real langgraph dev (9/9), residual-importer sweep.
70 lines
2.5 KiB
Python
70 lines
2.5 KiB
Python
from typing import Any
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
|
|
from agent.webhooks import common as webhook_common
|
|
from agent.webhooks import slack as slack_webhook
|
|
|
|
|
|
class _FakeThreads:
|
|
def __init__(self) -> None:
|
|
self.updates: list[dict[str, Any]] = []
|
|
|
|
async def update(self, *, thread_id: str, metadata: dict[str, Any]) -> None:
|
|
self.updates.append({"thread_id": thread_id, "metadata": metadata})
|
|
|
|
|
|
class _FakeClient:
|
|
def __init__(self) -> None:
|
|
self.threads = _FakeThreads()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_slack_processing_error_posts_dashboard_link(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
async def fail_processing(event_data: dict[str, Any], repo_config: dict[str, str]) -> None:
|
|
raise RuntimeError("boom")
|
|
|
|
client = _FakeClient()
|
|
upsert = AsyncMock()
|
|
set_status = AsyncMock()
|
|
post_reply = AsyncMock(return_value=True)
|
|
|
|
monkeypatch.setattr(slack_webhook, "_process_slack_mention_impl", fail_processing)
|
|
monkeypatch.setattr(webhook_common, "generate_thread_id_from_slack_thread", lambda *_: "t1")
|
|
monkeypatch.setattr(webhook_common, "strip_bot_mention", lambda text, *_args, **_kwargs: text)
|
|
monkeypatch.setattr(webhook_common, "upsert_agent_thread_owner_metadata", upsert)
|
|
monkeypatch.setattr(webhook_common, "get_client", lambda *, url: client)
|
|
monkeypatch.setattr(webhook_common, "set_slack_assistant_status", set_status)
|
|
monkeypatch.setattr(
|
|
webhook_common,
|
|
"dashboard_thread_url",
|
|
lambda thread_id: f"https://ui/{thread_id}",
|
|
)
|
|
monkeypatch.setattr(webhook_common, "post_slack_thread_reply", post_reply)
|
|
|
|
await slack_webhook.process_slack_mention(
|
|
{
|
|
"channel_id": "C1",
|
|
"thread_ts": "123.45",
|
|
"event_ts": "123.45",
|
|
"user_id": "U1",
|
|
"text": "help",
|
|
"bot_user_id": "BOT",
|
|
},
|
|
{"owner": "langchain-ai", "name": "open-swe"},
|
|
)
|
|
|
|
upsert.assert_awaited_once()
|
|
assert len(client.threads.updates) == 1
|
|
update = client.threads.updates[0]
|
|
assert update["thread_id"] == "t1"
|
|
assert update["metadata"]["latest_run_status"] == "error"
|
|
assert "failure_reply_posted" not in update["metadata"]
|
|
assert isinstance(update["metadata"]["updated_at_ms"], int)
|
|
set_status.assert_awaited_once_with("C1", "123.45", status="")
|
|
post_reply.assert_awaited_once()
|
|
assert post_reply.await_args.args[:2] == ("C1", "123.45")
|
|
assert "<https://ui/t1|Open SWE Web>" in post_reply.await_args.args[2]
|