mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 18:33:15 +00:00
Adam Moussa
ae1f883b4c
Applies the plan's C5 step: git mv every test per the domain-reorg
move-map (movemap-m50.txt) into tests/{agent,analyzer,auth,dashboard,
github,middleware,models,reviewer,sandbox,slack,tools,webhooks}/, plus
the 13 fork-only placements from the scoping report §2c (Atlassian
webhook tests -> tests/webhooks/, test_atlassian_connect.py and
test_auth_error_leak.py -> tests/auth/, jira/confluence util tests ->
tests/tools/, test_repo_binding_isolation.py -> tests/sandbox/,
bot-identity/autofix tests -> tests/github/).
Path-only move: the only content edits are parents[1] -> parents[2]
fixes in test_e2b_integration.py and test_daytona_integration.py,
required because their __file__-relative ROOT path gained one more
directory level in the move.
Monkeypatch retargets for these files were already completed in C4;
none remained outstanding here.
117 lines
4 KiB
Python
117 lines
4 KiB
Python
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from agent.middleware.check_message_queue import (
|
|
DASHBOARD_HANDOFF_MARKER,
|
|
_build_blocks_from_payload,
|
|
check_message_queue_before_model,
|
|
)
|
|
|
|
|
|
class _QueuedItem:
|
|
def __init__(self, value: dict[str, Any]) -> None:
|
|
self.value = value
|
|
|
|
|
|
class _FakeStore:
|
|
def __init__(self, items: dict[tuple[tuple[str, ...], str], dict[str, Any]]) -> None:
|
|
self.items = items
|
|
self.deleted: list[tuple[tuple[str, ...], str]] = []
|
|
|
|
async def aget(self, namespace: tuple[str, ...], key: str) -> _QueuedItem | None:
|
|
value = self.items.get((namespace, key))
|
|
return _QueuedItem(value) if value is not None else None
|
|
|
|
async def adelete(self, namespace: tuple[str, ...], key: str) -> None:
|
|
self.deleted.append((namespace, key))
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_check_message_queue_injects_dashboard_handoff_instruction() -> None:
|
|
store = _FakeStore(
|
|
{
|
|
(("queue", "thread-1"), "pending_messages"): {
|
|
"messages": [
|
|
{"content": {"text": "continue in web", "source": "dashboard"}},
|
|
]
|
|
}
|
|
}
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"agent.middleware.check_message_queue.get_config",
|
|
return_value={"configurable": {"thread_id": "thread-1"}},
|
|
),
|
|
patch("agent.middleware.check_message_queue.get_store", return_value=store),
|
|
):
|
|
result = await check_message_queue_before_model.abefore_model({}, MagicMock())
|
|
|
|
assert result is not None
|
|
message = result["messages"][0]
|
|
assert message["role"] == "user"
|
|
assert DASHBOARD_HANDOFF_MARKER in message["content"][0]["text"]
|
|
assert message["content"][1] == {"type": "text", "text": "continue in web"}
|
|
assert store.deleted == [(("queue", "thread-1"), "pending_messages")]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_check_message_queue_injects_pending_autofix_event() -> None:
|
|
store = _FakeStore(
|
|
{
|
|
(("autofix", "thread-1"), "pending_event"): {
|
|
"reason": "review_feedback",
|
|
"details": ["Reviewer alice commented: rename to userId"],
|
|
}
|
|
}
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"agent.middleware.check_message_queue.get_config",
|
|
return_value={"configurable": {"thread_id": "thread-1"}},
|
|
),
|
|
patch("agent.middleware.check_message_queue.get_store", return_value=store),
|
|
):
|
|
result = await check_message_queue_before_model.abefore_model({}, MagicMock())
|
|
|
|
assert result is not None
|
|
message = result["messages"][0]
|
|
assert message["role"] == "user"
|
|
text = message["content"][0]["text"]
|
|
assert "PR babysitting event arrived" in text
|
|
# The reviewer's actual comment is carried through, not dropped for a generic nudge.
|
|
assert "rename to userId" in text
|
|
assert (("autofix", "thread-1"), "pending_event") in store.deleted
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_blocks_skips_images_for_text_only_model() -> None:
|
|
payload = {
|
|
"text": "see this screenshot",
|
|
"image_urls": ["https://files.slack.com/fake.png"],
|
|
}
|
|
blocks = await _build_blocks_from_payload(
|
|
payload, model_id="fireworks:accounts/fireworks/models/glm-5p2"
|
|
)
|
|
assert len(blocks) == 1
|
|
assert blocks[0]["type"] == "text"
|
|
assert "does not support image input" in blocks[0]["text"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_blocks_includes_images_for_vision_model() -> None:
|
|
payload: dict[str, Any] = {"text": "see this", "image_urls": []}
|
|
blocks = await _build_blocks_from_payload(payload, model_id="openai:gpt-5.5")
|
|
assert blocks == [{"type": "text", "text": "see this"}]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_blocks_no_model_check_fetches_images() -> None:
|
|
payload: dict[str, Any] = {"text": "see this", "image_urls": []}
|
|
blocks = await _build_blocks_from_payload(payload)
|
|
assert blocks == [{"type": "text", "text": "see this"}]
|