mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 09:13:14 +00:00
Some checks are pending
CI / Lint (push) Waiting to run
CI / Format check (push) Waiting to run
CI / Unit tests (push) Waiting to run
CI / Playwright E2E (push) Waiting to run
CI / Docker build smoke (push) Waiting to run
CI / Triage ledger up to date (push) Waiting to run
CI / ui bun.lock in sync (push) Waiting to run
* feat: port plan-review & workflow-approval UX (#135)
Port six upstream commits onto dev:
- c03a6be7 (already ported): keep plan guidance high-level
- 546042a4: add workflow approval UI with diff preview, approval URLs,
web review links, and polling for approval status during active runs
- 216cf181: remove workflow token elevation; approved pushes pass
through directly without proxy token rewriting
- 3dbc0282: preserve plan redirects after login by accepting relative
same-origin redirect_to values and rejecting blocked paths
- bb104d93: submit plan comments with cmd+enter
- 90cb6caa: terse Slack replies, shared content via save_plan outside
plan mode (PLAN_STATUS_SHARED), reject shared-content mutations
Refs: #135
* feat: port durable dispatch hardening and startup latency improvements
Port five upstream PRs onto dev:
- #1621 / #1658: durable dispatch with loopback webhook defense,
create_durable_run helper, _config_with_prepare_run_id, degradation
to None for relative/loopback completion webhook URLs
- #1696: run-level completion webhook deduplication (replace
claim-then-post with post-then-flag per run_id), DeferredErrorModel
for graph-factory resilience, ToolRetryMiddleware for task subagents,
TimeoutWrapupMiddleware for all three graphs
- #1697: lazy-load __init__.py for agent.middleware, agent.tools,
agent.dashboard (PEP 562); defer heavy imports (exa_py in web_search,
agent.webapp in request_pr_review, deepagents in sandbox.py); add
ttl_cache.py with stale-while-revalidate for tool loaders
Refs: #137
* fix: restore login page render and clear CI lint/format
The plan-review port removed the authRedirectUrl import from login.tsx
but left its call site, crashing the login page at runtime (blank page,
no 'Sign in to open-swe'). Pass the relative path straight to loginUrl,
matching the plan route and the backend relative-redirect handling.
Also drop an unused os import in the guard test and reformat
workflow_push_guard.py to satisfy ruff.
* fix: restore RepairOrphaned middleware export and repoint model fake to deferred_model boundary
* fix: restore RepairOrphanedToolCallsMiddleware, fix E2E model-fake patch, drop dead ttl_cache
- Re-add RepairOrphanedToolCallsMiddleware to the lazy middleware __init__
(_MIDDLEWARE_MODULES, __all__, TYPE_CHECKING) so agent.reviewer can import it.
- Reroute E2E model patching to deferred_model.make_model so make_model_or_defer
(used by all three graph factories) returns the scripted fake instead of
building a real model with fake credentials.
- Drop unused agent/utils/ttl_cache.py — no agent module imports it.
- Fix import ordering in agent/reviewer.py and agent/analyzer.py (ruff I001).
- Format tests/test_dispatch.py.
* fix: claim-then-post run-level failure dedup; stop permanent suppression
---------
Co-authored-by: amoussa1229 <166072409+amoussa1229@users.noreply.github.com>
Co-authored-by: Adam Moussa <adam@seahavenind.com>
66 lines
2.6 KiB
Python
66 lines
2.6 KiB
Python
import os
|
|
from collections.abc import Callable
|
|
from importlib import import_module
|
|
from typing import Any
|
|
|
|
SandboxFactory = Callable[..., Any]
|
|
|
|
SANDBOX_FACTORIES: dict[str, tuple[str, str]] = {
|
|
"langsmith": ("agent.integrations.langsmith", "create_langsmith_sandbox"),
|
|
"daytona": ("agent.integrations.daytona", "create_daytona_sandbox"),
|
|
"modal": ("agent.integrations.modal", "create_modal_sandbox"),
|
|
"runloop": ("agent.integrations.runloop", "create_runloop_sandbox"),
|
|
"local": ("agent.integrations.local", "create_local_sandbox"),
|
|
}
|
|
|
|
|
|
def _load_sandbox_factory(sandbox_type: str) -> SandboxFactory:
|
|
factory_path = SANDBOX_FACTORIES.get(sandbox_type)
|
|
if factory_path is None:
|
|
supported = ", ".join(sorted(SANDBOX_FACTORIES))
|
|
raise ValueError(f"Invalid sandbox type: {sandbox_type}. Supported types: {supported}")
|
|
module_name, function_name = factory_path
|
|
factory = getattr(import_module(module_name), function_name)
|
|
if not callable(factory):
|
|
raise TypeError(f"Sandbox factory {module_name}.{function_name} is not callable")
|
|
return factory
|
|
|
|
|
|
def create_sandbox(
|
|
sandbox_id: str | None = None,
|
|
*,
|
|
snapshot_id: str | None = None,
|
|
) -> Any:
|
|
"""Create or reconnect to a sandbox using the configured provider.
|
|
|
|
The provider is selected via the SANDBOX_TYPE environment variable.
|
|
Supported values: langsmith (default), daytona, modal, runloop, local.
|
|
|
|
Args:
|
|
sandbox_id: Optional existing sandbox ID to reconnect to.
|
|
snapshot_id: Optional snapshot to boot a new sandbox from. Only the
|
|
langsmith provider honors this; others ignore it. When omitted the
|
|
langsmith provider falls back to DEFAULT_SANDBOX_SNAPSHOT_ID.
|
|
|
|
Returns:
|
|
A sandbox backend implementing SandboxBackendProtocol.
|
|
"""
|
|
sandbox_type = os.getenv("SANDBOX_TYPE", "langsmith")
|
|
factory = _load_sandbox_factory(sandbox_type)
|
|
if sandbox_type == "langsmith" and snapshot_id is not None:
|
|
return factory(sandbox_id, snapshot_id=snapshot_id)
|
|
return factory(sandbox_id)
|
|
|
|
|
|
def validate_sandbox_startup_config() -> None:
|
|
"""Validate the configured sandbox provider's env vars at server startup.
|
|
|
|
Raises ValueError if the active provider's configuration is invalid.
|
|
Called from the FastAPI lifespan hook so errors surface at boot rather
|
|
than on the first sandbox creation.
|
|
"""
|
|
sandbox_type = os.getenv("SANDBOX_TYPE", "langsmith")
|
|
if sandbox_type == "langsmith":
|
|
from agent.integrations.langsmith import LangSmithProvider
|
|
|
|
LangSmithProvider.validate_startup_config()
|