mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 10:23:14 +00:00
0546085672
Some checks are pending
CI / Lint (push) Waiting to run
CI / Format check (push) Waiting to run
CI / Unit tests (push) Waiting to run
CI / Playwright E2E (push) Waiting to run
CI / Docker build smoke (push) Waiting to run
CI / Triage ledger up to date (push) Waiting to run
CI / ui bun.lock in sync (push) Waiting to run
* feat: port plan-review & workflow-approval UX (#135)
Port six upstream commits onto dev:
- c03a6be7 (already ported): keep plan guidance high-level
- 546042a4: add workflow approval UI with diff preview, approval URLs,
web review links, and polling for approval status during active runs
- 216cf181: remove workflow token elevation; approved pushes pass
through directly without proxy token rewriting
- 3dbc0282: preserve plan redirects after login by accepting relative
same-origin redirect_to values and rejecting blocked paths
- bb104d93: submit plan comments with cmd+enter
- 90cb6caa: terse Slack replies, shared content via save_plan outside
plan mode (PLAN_STATUS_SHARED), reject shared-content mutations
Refs: #135
* feat: port durable dispatch hardening and startup latency improvements
Port five upstream PRs onto dev:
- #1621 / #1658: durable dispatch with loopback webhook defense,
create_durable_run helper, _config_with_prepare_run_id, degradation
to None for relative/loopback completion webhook URLs
- #1696: run-level completion webhook deduplication (replace
claim-then-post with post-then-flag per run_id), DeferredErrorModel
for graph-factory resilience, ToolRetryMiddleware for task subagents,
TimeoutWrapupMiddleware for all three graphs
- #1697: lazy-load __init__.py for agent.middleware, agent.tools,
agent.dashboard (PEP 562); defer heavy imports (exa_py in web_search,
agent.webapp in request_pr_review, deepagents in sandbox.py); add
ttl_cache.py with stale-while-revalidate for tool loaders
Refs: #137
* fix: restore login page render and clear CI lint/format
The plan-review port removed the authRedirectUrl import from login.tsx
but left its call site, crashing the login page at runtime (blank page,
no 'Sign in to open-swe'). Pass the relative path straight to loginUrl,
matching the plan route and the backend relative-redirect handling.
Also drop an unused os import in the guard test and reformat
workflow_push_guard.py to satisfy ruff.
* fix: restore RepairOrphaned middleware export and repoint model fake to deferred_model boundary
* fix: restore RepairOrphanedToolCallsMiddleware, fix E2E model-fake patch, drop dead ttl_cache
- Re-add RepairOrphanedToolCallsMiddleware to the lazy middleware __init__
(_MIDDLEWARE_MODULES, __all__, TYPE_CHECKING) so agent.reviewer can import it.
- Reroute E2E model patching to deferred_model.make_model so make_model_or_defer
(used by all three graph factories) returns the scripted fake instead of
building a real model with fake credentials.
- Drop unused agent/utils/ttl_cache.py — no agent module imports it.
- Fix import ordering in agent/reviewer.py and agent/analyzer.py (ruff I001).
- Format tests/test_dispatch.py.
* fix: claim-then-post run-level failure dedup; stop permanent suppression
---------
Co-authored-by: amoussa1229 <166072409+amoussa1229@users.noreply.github.com>
Co-authored-by: Adam Moussa <adam@seahavenind.com>
98 lines
4.1 KiB
Python
98 lines
4.1 KiB
Python
import sys
|
|
from types import ModuleType
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
_MIDDLEWARE_MODULES = {
|
|
"check_message_queue_before_model": ".check_message_queue",
|
|
"ensure_no_empty_msg": ".ensure_no_empty_msg",
|
|
"ExcludeToolsMiddleware": ".exclude_tools",
|
|
"ModelFallbackMiddleware": ".model_fallback",
|
|
"notify_step_limit_reached": ".notify_step_limit",
|
|
"PlanModeMiddleware": ".plan_mode",
|
|
"refresh_github_proxy_before_model": ".refresh_github_proxy",
|
|
"RepairOrphanedToolCallsMiddleware": ".repair_orphaned_tool_calls",
|
|
"SlackAssistantStatusMiddleware": ".refresh_slack_status",
|
|
"SandboxCircuitBreakerMiddleware": ".sandbox_circuit_breaker",
|
|
"SanitizeFireworksMessagesMiddleware": ".sanitize_fireworks_messages",
|
|
"SanitizeOpenAIResponsesMiddleware": ".sanitize_openai_responses",
|
|
"SanitizeThinkingBlocksMiddleware": ".sanitize_thinking_blocks",
|
|
"SanitizeToolInputsMiddleware": ".sanitize_tool_inputs",
|
|
"settle_review_check_on_exit": ".settle_review_check",
|
|
"SubdirAgentsReadMiddleware": ".subdir_agents",
|
|
"task_on_failure": ".task_retry",
|
|
"task_retry_on": ".task_retry",
|
|
"TimeoutWrapupMiddleware": ".timeout_wrapup",
|
|
"ToolArtifactMiddleware": ".tool_artifact",
|
|
"ToolErrorMiddleware": ".tool_error_handler",
|
|
"WorkflowPushGuardMiddleware": ".workflow_push_guard",
|
|
}
|
|
|
|
__all__ = [
|
|
"ExcludeToolsMiddleware",
|
|
"ModelFallbackMiddleware",
|
|
"PlanModeMiddleware",
|
|
"RepairOrphanedToolCallsMiddleware",
|
|
"SanitizeFireworksMessagesMiddleware",
|
|
"SanitizeOpenAIResponsesMiddleware",
|
|
"SanitizeThinkingBlocksMiddleware",
|
|
"SanitizeToolInputsMiddleware",
|
|
"SubdirAgentsReadMiddleware",
|
|
"ToolArtifactMiddleware",
|
|
"ToolErrorMiddleware",
|
|
"TimeoutWrapupMiddleware",
|
|
"WorkflowPushGuardMiddleware",
|
|
"SandboxCircuitBreakerMiddleware",
|
|
"SlackAssistantStatusMiddleware",
|
|
"check_message_queue_before_model",
|
|
"ensure_no_empty_msg",
|
|
"notify_step_limit_reached",
|
|
"refresh_github_proxy_before_model",
|
|
"settle_review_check_on_exit",
|
|
"task_on_failure",
|
|
"task_retry_on",
|
|
]
|
|
|
|
if TYPE_CHECKING:
|
|
from .check_message_queue import check_message_queue_before_model
|
|
from .ensure_no_empty_msg import ensure_no_empty_msg
|
|
from .exclude_tools import ExcludeToolsMiddleware
|
|
from .model_fallback import ModelFallbackMiddleware
|
|
from .notify_step_limit import notify_step_limit_reached
|
|
from .plan_mode import PlanModeMiddleware
|
|
from .refresh_github_proxy import refresh_github_proxy_before_model
|
|
from .refresh_slack_status import SlackAssistantStatusMiddleware
|
|
from .repair_orphaned_tool_calls import RepairOrphanedToolCallsMiddleware
|
|
from .sandbox_circuit_breaker import SandboxCircuitBreakerMiddleware
|
|
from .sanitize_fireworks_messages import SanitizeFireworksMessagesMiddleware
|
|
from .sanitize_openai_responses import SanitizeOpenAIResponsesMiddleware
|
|
from .sanitize_thinking_blocks import SanitizeThinkingBlocksMiddleware
|
|
from .sanitize_tool_inputs import SanitizeToolInputsMiddleware
|
|
from .settle_review_check import settle_review_check_on_exit
|
|
from .subdir_agents import SubdirAgentsReadMiddleware
|
|
from .task_retry import task_on_failure, task_retry_on
|
|
from .timeout_wrapup import TimeoutWrapupMiddleware
|
|
from .tool_artifact import ToolArtifactMiddleware
|
|
from .tool_error_handler import ToolErrorMiddleware
|
|
from .workflow_push_guard import WorkflowPushGuardMiddleware
|
|
|
|
|
|
def _load_export(name: str) -> Any:
|
|
module_name = _MIDDLEWARE_MODULES.get(name)
|
|
if module_name is None:
|
|
raise AttributeError(f"module {__name__!r} has no attribute {name!r}")
|
|
from importlib import import_module
|
|
|
|
value = getattr(import_module(module_name, __name__), name)
|
|
globals()[name] = value
|
|
return value
|
|
|
|
|
|
class _LazyMiddlewareModule(ModuleType):
|
|
def __getattribute__(self, name: str) -> Any:
|
|
module_map = ModuleType.__getattribute__(self, "__dict__").get("_MIDDLEWARE_MODULES", {})
|
|
if name in module_map:
|
|
return _load_export(name)
|
|
return ModuleType.__getattribute__(self, name)
|
|
|
|
|
|
sys.modules[__name__].__class__ = _LazyMiddlewareModule
|