mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 13:53:15 +00:00
0212a60f10
* feat(open-swe): cap reviewer suggestions at 4 lines Long suggestion blocks read as the reviewer rewriting the code rather than flagging an issue, which clutters PR comments. Steer the reviewer toward description-only findings for non-trivial fixes, and enforce the cap in `add_finding` / `update_finding` so suggestions over 4 lines are dropped (the finding itself still publishes). * fix(open-swe): don't clobber prior suggestion on over-cap update `update_finding` was setting `suggestion=None` whenever clip_suggestion dropped the input, which silently wiped any existing suggestion on the finding. Distinguish the three cases: empty string clears, valid value sets, over-cap value is rejected without touching the stored field.
110 lines
4.1 KiB
Python
110 lines
4.1 KiB
Python
"""Tool: ``update_finding``. Mutate an existing finding by id."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from typing import Any
|
|
|
|
from langgraph.config import get_config
|
|
|
|
from ..reviewer_findings import (
|
|
MAX_SUGGESTION_LINES,
|
|
clip_suggestion,
|
|
get_thread_id_from_runtime,
|
|
update_finding_fields,
|
|
)
|
|
|
|
|
|
def update_finding(
|
|
finding_id: str,
|
|
status: str | None = None,
|
|
severity: str | None = None,
|
|
description: str | None = None,
|
|
suggestion: str | None = None,
|
|
note: str | None = None,
|
|
) -> dict[str, Any]:
|
|
"""Update fields on an existing finding.
|
|
|
|
Use this on a re-review run to mark an existing finding as resolved or
|
|
dismissed, or to revise its severity/description/suggestion if the new
|
|
commits changed the situation.
|
|
|
|
Args:
|
|
finding_id: The id returned by ``add_finding`` (or shown in the
|
|
``Existing findings`` block of the re-review user message).
|
|
status: New status (``open``, ``resolved``, ``dismissed``).
|
|
Use ``resolved`` when the new commits address the issue.
|
|
severity: New severity, if reassessing.
|
|
description: New description body, if revising.
|
|
suggestion: New replacement text. Pass an empty string to clear it.
|
|
Capped at 4 lines — longer values are dropped (the finding keeps
|
|
its description). Only set this for small, obvious fixes.
|
|
note: Optional free-form note explaining the change. Persisted on the
|
|
finding under ``last_update_note``.
|
|
|
|
Returns:
|
|
Dictionary with ``success`` and (on success) the updated ``finding``.
|
|
"""
|
|
if status is not None and status not in {"open", "resolved", "dismissed"}:
|
|
return {"success": False, "error": f"Invalid status: {status}"}
|
|
if severity is not None and severity not in {
|
|
"informational",
|
|
"low",
|
|
"medium",
|
|
"high",
|
|
"critical",
|
|
}:
|
|
return {"success": False, "error": f"Invalid severity: {severity}"}
|
|
|
|
updates: dict[str, Any] = {}
|
|
suggestion_dropped = False
|
|
if status is not None:
|
|
updates["status"] = status
|
|
if severity is not None:
|
|
updates["severity"] = severity
|
|
if description is not None:
|
|
updates["description"] = description
|
|
if suggestion is not None:
|
|
if suggestion == "":
|
|
updates["suggestion"] = None
|
|
else:
|
|
clipped, suggestion_dropped = clip_suggestion(suggestion)
|
|
if not suggestion_dropped:
|
|
updates["suggestion"] = clipped
|
|
if note is not None:
|
|
updates["last_update_note"] = note
|
|
|
|
config = get_config()
|
|
configurable = config.get("configurable", {}) if isinstance(config, dict) else {}
|
|
head_sha = configurable.get("head_sha", "") if isinstance(configurable, dict) else ""
|
|
if status == "open" and isinstance(head_sha, str) and head_sha:
|
|
updates["last_confirmed_sha"] = head_sha
|
|
|
|
if not updates:
|
|
if suggestion_dropped:
|
|
return {
|
|
"success": False,
|
|
"suggestion_dropped": True,
|
|
"error": (
|
|
f"Suggestion exceeded the {MAX_SUGGESTION_LINES}-line cap "
|
|
"and was rejected; no other fields were provided, so "
|
|
"nothing was updated. Only include `suggestion` for "
|
|
"small, obvious fixes."
|
|
),
|
|
}
|
|
return {"success": False, "error": "No fields provided to update"}
|
|
|
|
thread_id = get_thread_id_from_runtime()
|
|
updated = asyncio.run(update_finding_fields(thread_id, finding_id, updates))
|
|
if updated is None:
|
|
return {"success": False, "error": f"No finding found with id {finding_id}"}
|
|
result: dict[str, Any] = {"success": True, "finding": updated}
|
|
if suggestion_dropped:
|
|
result["suggestion_dropped"] = True
|
|
result["warning"] = (
|
|
f"Suggestion exceeded the {MAX_SUGGESTION_LINES}-line cap and was "
|
|
"rejected — the finding's prior `suggestion` was left unchanged "
|
|
"and other fields were updated normally. Only include "
|
|
"`suggestion` for small, obvious fixes."
|
|
)
|
|
return result
|