mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 18:33:15 +00:00
3f9dbb6597
* feat: add Slack reaction feedback to LangSmith Record Slack reaction feedback against explicitly mapped LangGraph runs so user ratings are idempotent and tied to the message they reacted to. * Address review feedback on Slack reaction → LangSmith feedback - langsmith.py: drop lru_cache on _build_langsmith_feedback_clients so rotated keys / late env hydration are picked up; dedupe by (key, url) tuple instead of key alone so the same key pointing at different endpoints (cloud + self-hosted) builds both clients. - langsmith.py: treat LangSmithNotFoundError on delete_feedback as success — out-of-order or redelivered reaction_removed events would otherwise loop forever on Slack's retry policy. - slack_feedback.py: include channel_id in _feedback_key so the same message_ts in two channels can't collide on the same feedback id. - slack_feedback.py: treat conflicting +/- reactions from one user as ambiguous (clear feedback) instead of averaging to a misleading 0.5. - slack_feedback.py + slack.py + webapp.py: gate reaction handling to the user who triggered the run (stored in the slack_run_map mapping alongside run_id). Prevents bystanders in shared channels from polluting eval feedback.
61 lines
2.4 KiB
Python
61 lines
2.4 KiB
Python
import asyncio
|
|
import os
|
|
from typing import Any
|
|
|
|
from langgraph.config import get_config
|
|
from langgraph_sdk import get_client
|
|
|
|
from ..utils.slack import (
|
|
convert_mentions_to_slack_format,
|
|
post_slack_thread_reply_with_ts,
|
|
store_slack_message_run_mapping,
|
|
)
|
|
|
|
LANGGRAPH_URL = os.environ.get("LANGGRAPH_URL") or os.environ.get(
|
|
"LANGGRAPH_URL_PROD", "http://localhost:2024"
|
|
)
|
|
|
|
|
|
def slack_thread_reply(message: str) -> dict[str, Any]:
|
|
"""Post a message to the current Slack thread.
|
|
|
|
Use this for clarifying questions, mid-run progress updates, and the final
|
|
summary. You can call this multiple times during a run — if you're about to
|
|
do long-running work (cloning, large refactors, big test runs) consider
|
|
posting a brief status update first so the user knows what's happening.
|
|
Always end the run with a final reply summarizing what you did.
|
|
|
|
Format messages using Slack's mrkdwn format, NOT standard Markdown.
|
|
Key differences: *bold*, _italic_, ~strikethrough~, <url|link text>,
|
|
bullet lists with "• ", ```code blocks```, > blockquotes.
|
|
Do NOT use **bold**, [link](url), or other standard Markdown syntax.
|
|
|
|
To mention/tag a user, use Slack's mention format: <@USER_ID>.
|
|
You can find user IDs in the conversation context (e.g. @Name(U06KD8BFY95)).
|
|
Example: <@U06KD8BFY95> will tag that user in the message."""
|
|
config = get_config()
|
|
configurable = config.get("configurable", {})
|
|
slack_thread = configurable.get("slack_thread", {})
|
|
|
|
channel_id = slack_thread.get("channel_id")
|
|
thread_ts = slack_thread.get("thread_ts")
|
|
if not channel_id or not thread_ts:
|
|
return {
|
|
"success": False,
|
|
"error": "Missing slack_thread.channel_id or slack_thread.thread_ts in config",
|
|
}
|
|
|
|
if not message.strip():
|
|
return {"success": False, "error": "Message cannot be empty"}
|
|
|
|
message = convert_mentions_to_slack_format(message)
|
|
message_ts = asyncio.run(_post_and_store_mapping(channel_id, thread_ts, message))
|
|
return {"success": message_ts is not None}
|
|
|
|
|
|
async def _post_and_store_mapping(channel_id: str, thread_ts: str, message: str) -> str | None:
|
|
message_ts = await post_slack_thread_reply_with_ts(channel_id, thread_ts, message)
|
|
if message_ts:
|
|
langgraph_client = get_client(url=LANGGRAPH_URL)
|
|
await store_slack_message_run_mapping(langgraph_client, channel_id, thread_ts, message_ts)
|
|
return message_ts
|