mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 17:23:15 +00:00
* chore: bake sfw binary into sandbox image (#1611) sfw only ships a launcher that fetches its real binary at first run and does a daily update check against api.github.com/repos/SocketDev/sfw-free. Both fail in the sandbox (restricted egress; the proxy injects the GitHub App installation token, which lacks access to that repo), so `sfw yarn install` errors with "could not fetch its binary". Pin sfw 2.0.6, warm + verify the binary cache at build, and set SFW_SKIP_UPDATE_CHECK=1 so runs use the baked binary offline. * feat: editable plan mode + fix review-plan banner overlap (#1610) * feat: editable plan mode + fix review-plan banner overlap Lets the thread owner edit the plan markdown by hand from the plan-review page (Edit -> textarea -> Save) via a new PUT /dashboard/api/plan/{id} endpoint that re-publishes the plan and mirrors it into the sandbox plan.md, so approve hands the edited plan to the agent as the source of truth. Also fixes the collapsed git-panel's floating expand button covering the "Review plan ->" banner by reserving space for it. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: abort plan approval when the published plan read fails get_plan_content() swallowed store errors and returned None, so a transient failure during approve would still mark the plan approved and dispatch the generic fallback text — silently dropping an owner's edited plan. Read the plan strictly (raise_on_error=True) so approval aborts instead, matching the comment read. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: show message timestamps (#1609) * feat: show message timestamps Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: suppress fallback message timestamps Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: stable message + tool-call hover timestamps Stamp a stable client-side arrival time per message and tool call (keyed by id, persisted to localStorage). Messages render the timestamp inline; tool rows reveal a dim timestamp chip on hover. Real backend created_at still takes precedence when present. * fix: hide client-stamped message timestamps Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add PR trace resolution (#1612) * feat: add PR trace resolution Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: inject reviewer trace context as JSON Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: address review on PR trace resolution Use the documented LangSmith metadata filter syntax (and(eq(metadata_key,...), eq(metadata_value,...))) instead of has(metadata, '{...}'), which does not match runs — _list_thread_runs was silently returning nothing. Bound full-text searches to a 90-day window so they don't hit LangSmith's large-window rate limit. Also folds in the best-effort branch->head-sha resolver (dropping the weighted scoring/threshold + repo/file evidence + GitHub hydration), sandbox JSON injection, and the admin "Resolve trace" dry-run endpoint. The IDOR findings are moot: resolve_pr_to_threads/summarize_agent_session were removed; resolution now runs deterministically from the trusted run config with no model-controlled pr_url or thread_id. * fix: scope branch trace search to the repo Branch names like fix-tests aren't unique across repos (or older PRs) in a shared tracing project, so an unscoped branch hit could resolve to an unrelated thread and write its runs into the reviewer sandbox. Require the repo slug to co-occur with the branch in matched runs; the full head SHA stays unscoped since it is globally unique. Addresses open-swe review on PR #1612. --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: include plan links in PR descriptions (#1613) Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: gate workflow pushes with approval (#1614) * feat: gate workflow pushes with approval Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: preserve proxy refresh test compatibility Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: bind workflow approvals to pushed ref Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: recover thread work as patch (#1615) * feat: recover thread work as patch Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: search sandbox cwd for recovery patches Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: omit plan link in PR description when no plan exists (#1618) Plan links in PR descriptions were always built from the thread id, so runs that never produced a plan linked to an empty plan-review page. Now the plan content store is consulted first; the link is only added when a plan with non-empty markdown actually exists. A transient store failure degrades gracefully (no link) rather than blocking PR creation. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add filter & grouping menu to agents threads sidebar (#1617) Add a Cursor-style control to the agents sidebar that groups (None/Date/ Status/Project), filters (ownership, status, source, pull request, model, repo, include-resolved), and compacts the threads list. All client-side over already-fetched sidebar threads; preferences persist in localStorage. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: update langsmith sdk to 0.9.3 (#1616) Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: clickable shared PR header in git panel and reviews (#1620) * feat: clickable shared PR header in git panel and reviews Replace the standalone "View PR" button in the agent git panel with a clickable PR title, matching the reviews view. Extract a shared PrHeader component reused by both the git panel and the review main body. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * refactor: drop PrHeader wrapper, use shared component directly The review-side PrHeader was just a thin adapter mapping detail -> the shared component's props. Inline it at the call site and use the shared PrHeader directly so there's a single component. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * refactor: durable interrupt dispatch + completion webhook (#1621) * wip(rebuild): core reliability spine - remove PR-babysitting (ci_autofix + ci_monitor graph + webhook wiring) - dispatch core: agent/dispatch.py with multitask_strategy=interrupt + durability=sync + completion webhook; reroute all webhook + plan triggers; drop the racy in-process lock + is_thread_active busy-check - completion webhook: agent/completion.py + /webhooks/run-complete loopback route for failure/timeout replies (idempotent) Co-authored-by: open-swe[bot] * feat(rebuild): async tools, reconcile, shared http timeouts, assembly tuning Parallel batch on top of the reliability spine: - async-ify all 24 tools (drop asyncio.run; requests->httpx); re-implement the http_request/fetch_url SSRF + DNS-rebinding defense httpx-natively and harden the IP check to 'not is_global' (+ IPv4-mapped unwrap) - reconcile.py: stale pending-run sweep (threads.search -> per-thread runs.list -> cancel_many), wired into the scheduler graph via task='reconcile' - shared DEFAULT_HTTP_TIMEOUT (agent/utils/http.py) on every bare httpx.AsyncClient() across utils/dashboard/webapp/middleware - run budget: MODEL_CALL_RECURSION_LIMIT 5000->250 - fix stale OpenAI->Anthropic fallback id (claude-opus-4-5 -> 4-8) - drop redundant custom repair middleware (deepagents auto-adds PatchToolCalls) - confirm tool-result eviction + summarization auto-wired via backend - slim system prompt ~8% (full harness-profile rewrite deferred) Co-authored-by: open-swe[bot] * feat(rebuild): harness-profile prompt + split webhooks out of webapp - prompt.py: own the system prompt via a registered harness profile (OPEN_SWE_SHARED_BASE, kept neutral so the read-only reviewer/analyzer that share it stay safe), registered across all 4 providers; per-thread values stay in construct_system_prompt. Assembled main-agent prompt ~6.8k -> ~3.1k tokens (~55% smaller); de-duped PR/commit/suite/force-push guidance; dropped ALL-CAPS markers. - webapp.py 3325 -> 1890 LOC: moved 14 per-source handlers into agent/webhooks/{linear,slack,github}.py; webapp re-exports them for the routes + tests; moved handlers reach shared helpers via the webapp namespace to preserve the test suite's monkeypatch targets. Full suite: 1168 passing, lint clean. Co-authored-by: open-swe[bot] * Restore MODEL_CALL_RECURSION_LIMIT to 5000 for long-running tasks Reverts the 250 cap from the run-budget change — long-running tasks legitimately need many model calls. The notify_step_limit_reached safety net still fires if a run does hit the cap, so runs end with a signal either way. Co-authored-by: open-swe[bot] * fix: address PR review (auth, SSRF, interrupted status, redirect headers) - completion.py: drop `interrupted` from failure statuses — with multitask_strategy=interrupt a follow-up ends the prior run as interrupted, which is healthy, not a failure to report. [open-swe] - /webhooks/run-complete: shared-secret auth — dispatch appends ?token= when RUN_COMPLETE_WEBHOOK_SECRET is set; route verifies via hmac.compare_digest. [corridor-security] - SSRF: extract the URL validator to agent/utils/url_safety.py and apply it before server-side image fetches in multimodal.fetch_image_block. [corridor-security] - http_request: preserve caller headers/extensions across redirect hops instead of dropping them on the first hop. [open-swe] Co-authored-by: open-swe[bot] * chore: remove REBUILD_PLAN.md (planning doc, not needed in the repo) Co-authored-by: open-swe[bot] * fix: fail closed on run-complete webhook auth when secret unset Corridor follow-up: verify_run_complete_token returns False (not True) when RUN_COMPLETE_WEBHOOK_SECRET is unset, so the public route is never unauthenticated. Logs a startup warning when the secret is absent, and dispatch skips registering the webhook when there's no secret (no rejected callbacks). Co-authored-by: open-swe[bot] --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: restore forced tool call to prevent premature run stops (#1622) Restore the ensure_no_empty_msg middleware and the always-call-a-tool system-prompt instruction that #1535 removed. When the model emits a message with no tool call (and hasn't already messaged the user or confirmed completion), the middleware re-injects a no_op / confirming_completion tool call so the run continues instead of ending mid-task. Shipping to test whether it fixes runs that stop halfway through. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore(deps): bump langgraph-checkpoint from 4.1.0 to 4.1.1 (#1619) Bumps [langgraph-checkpoint](https://github.com/langchain-ai/langgraph) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/langchain-ai/langgraph/releases) - [Commits](https://github.com/langchain-ai/langgraph/compare/checkpoint==4.1.0...checkpoint==4.1.1) --- updated-dependencies: - dependency-name: langgraph-checkpoint dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: post reviewer resolution notes verbatim (#1624) * fix: post reviewer resolution notes verbatim Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: stabilize dashboard follow-up e2e Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: preserve dashboard attribution in e2e Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: make e2e attribution marker durable Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: only echo found e2e attribution Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: check live dashboard attribution in e2e Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * hotfix: stop prompting agent/reviewer to wrap installs in sfw (#1625) Installs hung when prefixed with sfw inside the sandbox (trace 019f0608 stalled on a pending `sfw npm install` execute, never returned). Strip the Socket Firewall guidance from the agent and reviewer prompts so installs run through the project's package manager directly. sfw stays in the Docker image; nothing invokes it now. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: make plan view mobile friendly (#1636) Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: fall back to vision model for image threads (#1626) Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: surface Slack thread errors (#1627) * fix: surface Slack thread errors Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: don't set failure_reply_posted on Slack preprocessing errors The preprocessing error handler was setting failure_reply_posted=True, the same idempotency flag handle_run_completion checks to suppress duplicate run-failure replies. Since preprocessing failures happen before any run exists but the flag persists on the thread, a subsequent run failure on the same thread would be silently ignored. The preprocessing handler already posts its own Slack reply, so the run-completion idempotency flag should not be set here. --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: avoid recapping Slack replies (#1629) * chore: avoid recapping Slack replies Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: simplify Slack reply prompt wording Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: update Slack trace reply on web handoff (#1630) * fix: update Slack trace reply on web handoff Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: trigger web handoff on dashboard starts Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: format web handoff as contextual fragment Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: preserve trace_message_ts when overwriting Slack run mapping When store_slack_run_mapping is called without trace_message_ts (e.g. on follow-up Slack mentions), it was unconditionally overwriting the thread-level mapping and clobbering the timestamp captured from the initial trace reply. After that, _notify_slack_web_handoff could not find the original message, so a subsequent move to Web silently skipped the Slack trace update. Now, when trace_message_ts is not passed, the existing thread mapping is read first and its trace_message_ts is preserved. * style: ruff format --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Johannes du Plessis <51395795+johannes117@users.noreply.github.com> Co-authored-by: Johannes du Plessis <johannes@langchain.dev> * fix: pre-bundle shiki/@pierre deps to stop dev dynamic-import failures (#1643) * fix(ui): pre-bundle shiki/@pierre deps to stop dev dynamic-import failures shiki lazy-imports a grammar per language and these libs only live inside lazy route components, so Vite's startup scanner never sees them. They get discovered on first thread navigation, triggering a dep re-optimize + force-reload that aborts the in-flight route-chunk import, surfacing as "Failed to fetch dynamically imported module: .../$threadId.tsx". Pre-bundle them (and the github themes + common code-block languages) via optimizeDeps.include so the optimize happens once at startup. Dev-only; production bundles are unaffected. * fix: pre-bundle canonical shiki docker/make langs instead of aliases --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: show queued dashboard follow-ups (#1631) * feat: show queued dashboard follow-ups Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: de-dupe queued follow-ups while streaming --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Johannes du Plessis <johannes@langchain.dev> * feat: notify Slack on plan approval (#1632) * feat: notify Slack on plan approval Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: post Slack approval notice after successful dispatch Move the _maybe_post_plan_approved_to_slack call until after _dispatch_followup succeeds so the Slack thread is not told implementation is beginning before the LangGraph run is created. Addresses PR review comment. --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Johannes du Plessis <johannes@langchain.dev> * feat: include Slack channel context in prompts (#1633) Add cached Slack channel metadata enrichment for Slack-triggered runs so prompts can include channel names and descriptions without duplicate conversations.info calls.\n\nCo-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> * chore: keep plan guidance high-level (#1634) Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: publish plans from sandbox files (#1635) * feat: publish plans from sandbox files Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: avoid fixed plan filenames Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: virtualize local sandbox file paths Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: preserve plan_file_path across set_plan_status set_plan_status was rewriting the content record with only markdown and status, dropping plan_file_path. After a reject, the owner's dashboard edit would mirror to a different file than the agent's original, and the next save_plan could republish the stale file. Preserve plan_file_path when updating status. --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: return to thread after plan approval (#1637) Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add Slack breakout thread tool (#1638) * feat: add Slack breakout thread tool Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: make fake LLM scripts declarative Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: exclude slack_start_new_thread from plan mode The breakout tool can dispatch a fresh agent run that starts outside the current plan-mode state, bypassing the approval flow. Add it to PLAN_MODE_EXCLUDED_TOOLS so it's hidden alongside the other mutating tools while planning. --------- Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: require bun for ui agent work (#1639) Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: request actions read for sandbox logs (#1642) * fix: request actions read for sandbox logs Request optional Actions read permission for sandbox proxy tokens, with fallback for installations that have not approved it yet. Update setup docs and prompt guidance for safe GitHub Actions log usage. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: restore actions:read scope after workflow push After an approved workflow push, the guard was restoring the proxy with BASE_RUNTIME_PROXY_TOKEN_PERMISSIONS, which excludes the actions: read scope this PR adds. Restore with RUNTIME_PROXY_TOKEN_PERMISSIONS (which includes actions: read) and fall back to BASE if the install hasn't granted Actions read — mirroring the pattern in _create_sandbox_with_proxy. Addresses review comment on PR #1642. --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: widen split review diffs (#1647) Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: install missing deps before verification (#1646) Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: switch ui to pnpm (#1645) * chore: require pnpm for ui agent work Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: switch ui to pnpm Replace Bun and Yarn lockfiles with pnpm lockfile and update UI/Vercel commands to use pnpm. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * ci: use corepack for ui pnpm e2e build Run pnpm through Corepack in the E2E global setup so CI can use the pinned package manager without a separate pnpm install step. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add Sonnet 5 to model picker (#1651) * chore: update Sonnet examples to Sonnet 5 Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: add Sonnet 5 to model picker Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * Remove dead breakout-thread e2e scenario after dropping the tool The merge resolution deferred upstream's Slack breakout-thread tool (slack_start_new_thread, #1638) since it depends on the #1621 dispatch module, but the e2e harness still scripted it. Removing the tool name from fake_llm.py's _tool_step call left a malformed scenario, crashing the langgraph-dev web server at import (TypeError: _tool_step() missing 'call_id') and failing Playwright E2E. Drop the "breakout" script scenario, its _is_breakout_request helper + ScriptRule, and the corresponding full_flow.spec.ts test. * Revert upstream pnpm switch; keep bun for the UI build The merge auto-adopted upstream's pnpm switch (#1645) in tests/e2e/ global-setup.ts and ui/package.json, but our fork builds the UI with bun (vercel.json + the E2E workflow's setup-bun). That left the Playwright globalSetup running `corepack pnpm install --frozen-lockfile` with no pnpm-lock.yaml, failing E2E at UI build time. Revert global-setup.ts and ui/package.json to the dev (bun) baseline, drop the merge-added ui/pnpm-lock.yaml, and remove the re-added ui/AGENTS.md (our fork had deleted it). * Align plan-review e2e + UI with the HEAD (pre-#1635) backend The merge left a split plan vertical: the backend save_plan/plan_api are HEAD (we deferred the editable-plan/sandbox-publish features #1610/#1635/ #1637 per #80), but the plan UI and e2e harness were upstream's. The fake_llm scenario called save_plan(plan_file_path=...) — upstream's file-based #1635 contract — while HEAD save_plan takes plan_markdown, so the plan never saved and PlanReview never rendered (E2E failure on the plan-review locator). Pass plan_markdown to save_plan, and revert PlanReview.tsx / plan.ts / $threadId_.plan.tsx / plan_review.spec.ts to the dev baseline so the whole plan flow (save -> render -> approve -> implement) is consistent with the HEAD backend. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Johannes du Plessis <johannes@langchain.dev> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Ramon Nogueira <ramon.nogueira@langchain.dev> Co-authored-by: Ramon Nogueira <270434257+ramon-langchain@users.noreply.github.com> Co-authored-by: Caroline di Vittorio <43390382+carolinedivittorio@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Johannes du Plessis <51395795+johannes117@users.noreply.github.com> Co-authored-by: Ankush Gola <9536492+agola11@users.noreply.github.com> Co-authored-by: Mukil Loganathan <mukil@langchain.dev>
545 lines
19 KiB
Python
545 lines
19 KiB
Python
"""HTTP app for the full-flow E2E (served as langgraph dev's http.app).
|
||
|
||
Mounts, on top of the REAL ``agent.webapp`` app:
|
||
- fake GitHub REST API (/fake-gh/...) the real open_pull_request hits this
|
||
- fake Slack API (/fake-slack/...) the real slack code hits this
|
||
- mock UIs (/mock/slack, /mock/github) what the user/Playwright sees
|
||
- control + compose (/control/*, /mock/slack/send) the test driver
|
||
|
||
Nothing here touches agent logic — it only stands in for the SaaS boundaries
|
||
and renders their state back as a user-facing UI.
|
||
"""
|
||
|
||
from __future__ import annotations
|
||
|
||
import hashlib
|
||
import hmac
|
||
import json
|
||
import os
|
||
import sys
|
||
import time
|
||
from pathlib import Path
|
||
from typing import Any
|
||
|
||
sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
|
||
|
||
import e2e_env # noqa: E402
|
||
import patches # noqa: E402
|
||
|
||
patches.apply()
|
||
|
||
import fakes # noqa: E402
|
||
import httpx # noqa: E402
|
||
from e2e_env import ( # noqa: E402
|
||
BASE_URL,
|
||
BOT_USER_ID,
|
||
DEMO_CHANNEL,
|
||
HUMAN_USER,
|
||
REPO_ROOT,
|
||
TEST_USERS,
|
||
)
|
||
from fastapi import HTTPException, Request # noqa: E402
|
||
from fastapi.responses import ( # noqa: E402
|
||
FileResponse,
|
||
HTMLResponse,
|
||
JSONResponse,
|
||
RedirectResponse,
|
||
Response,
|
||
)
|
||
|
||
# Slack-user directory the fake ``users.info`` resolves: the default sender used
|
||
# by the automated tests plus the named manual-test users.
|
||
_SLACK_USERS: dict[str, dict[str, str]] = {
|
||
HUMAN_USER: {"name": "devuser", "real_name": "Dev User", "email": "dev@example.com"},
|
||
**{
|
||
u["slack_id"]: {"name": u["login"], "real_name": u["name"], "email": u["email"]}
|
||
for u in TEST_USERS
|
||
},
|
||
}
|
||
|
||
from agent.dashboard.oauth import COOKIE_NAME, issue_session # noqa: E402
|
||
from agent.webapp import app, generate_thread_id_from_slack_thread # noqa: E402
|
||
|
||
GITHUB_WEBHOOK_SECRET = os.environ["GITHUB_WEBHOOK_SECRET"]
|
||
SLACK_SIGNING_SECRET = os.environ["SLACK_SIGNING_SECRET"]
|
||
STATIC_DIR = Path(__file__).parent / "static"
|
||
|
||
CURRENT_THREAD: dict[str, str | None] = {"channel": DEMO_CHANNEL, "thread_ts": None}
|
||
|
||
fakes.seed_bare_remote()
|
||
|
||
|
||
# --- control + Slack compose (the test driver) -----------------------------
|
||
@app.post("/control/reset")
|
||
async def control_reset() -> JSONResponse:
|
||
fakes.reset()
|
||
CURRENT_THREAD["thread_ts"] = None
|
||
return JSONResponse({"ok": True})
|
||
|
||
|
||
@app.get("/control/state")
|
||
async def control_state() -> JSONResponse:
|
||
return JSONResponse(
|
||
{"channel": CURRENT_THREAD["channel"], "thread_ts": CURRENT_THREAD["thread_ts"]}
|
||
)
|
||
|
||
|
||
@app.post("/mock/slack/send")
|
||
async def slack_send(request: Request) -> JSONResponse:
|
||
"""Simulate a user posting in Slack: store the message, then deliver the
|
||
signed Events-API webhook to the real /webhooks/slack route."""
|
||
form = await request.json()
|
||
text = str(form.get("text", ""))
|
||
mention_bot = bool(form.get("mention_bot", True))
|
||
# Sender defaults to the first test user (Alice) — the canonical owner the
|
||
# automated tests log in as; the mock UI passes the chosen test user.
|
||
user_id = str(form.get("user") or TEST_USERS[0]["slack_id"])
|
||
channel = DEMO_CHANNEL
|
||
|
||
ts = fakes.new_thread_ts()
|
||
CURRENT_THREAD["thread_ts"] = ts
|
||
fakes.add_slack_message(channel, ts, user=user_id, text=text, is_bot=False)
|
||
|
||
payload = {
|
||
"type": "event_callback",
|
||
"event_id": f"Ev{ts}",
|
||
"authorizations": [{"user_id": BOT_USER_ID}],
|
||
"event": {
|
||
"type": "app_mention" if mention_bot else "message",
|
||
"channel": channel,
|
||
"user": user_id,
|
||
"text": text,
|
||
"ts": ts,
|
||
"thread_ts": ts,
|
||
},
|
||
}
|
||
raw = json.dumps(payload).encode()
|
||
req_ts = str(int(time.time()))
|
||
base = f"v0:{req_ts}:{raw.decode()}".encode()
|
||
sig = "v0=" + hmac.new(SLACK_SIGNING_SECRET.encode(), base, hashlib.sha256).hexdigest()
|
||
|
||
transport = httpx.ASGITransport(app=app)
|
||
async with httpx.AsyncClient(transport=transport, base_url="http://harness") as client:
|
||
resp = await client.post(
|
||
"/webhooks/slack",
|
||
content=raw,
|
||
headers={
|
||
"X-Slack-Signature": sig,
|
||
"X-Slack-Request-Timestamp": req_ts,
|
||
"Content-Type": "application/json",
|
||
},
|
||
)
|
||
return JSONResponse(
|
||
{
|
||
"thread_ts": ts,
|
||
"thread_id": generate_thread_id_from_slack_thread(channel, ts),
|
||
"webhook_status": resp.status_code,
|
||
"webhook": resp.json(),
|
||
}
|
||
)
|
||
|
||
|
||
@app.post("/control/login")
|
||
async def control_login(request: Request) -> JSONResponse:
|
||
"""Simulate a signed-in dashboard user by minting the real session cookie."""
|
||
form = await request.json()
|
||
login = str(form.get("login", "dev-user"))
|
||
email = str(form.get("email", "dev@example.com"))
|
||
token = issue_session(login=login, email=email, avatar_url=None)
|
||
resp = JSONResponse({"ok": True, "login": login, "email": email})
|
||
resp.set_cookie(COOKIE_NAME, token, httponly=True, samesite="lax", secure=False, path="/")
|
||
return resp
|
||
|
||
|
||
@app.get("/control/login")
|
||
async def control_login_get(login: str = "", email: str = "", next_url: str = "") -> Response:
|
||
"""Browser login. With no ``login``, render a dropdown of the test users;
|
||
with ``?login=<u>`` (email resolved from the registry, or pass ``&email=``),
|
||
mint the session cookie and redirect into the dashboard. Use a separate
|
||
browser/profile per user — each has its own cookie jar."""
|
||
# Land on the dashboard origin (DASHBOARD_BASE_URL — the Vite HMR server in
|
||
# dev:mock), not this harness, so the cookie + the hot-reloading UI line up.
|
||
ui = os.environ.get("DASHBOARD_BASE_URL", "").rstrip("/")
|
||
dest = next_url or (f"{ui}/agents" if ui else "/agents")
|
||
if not login:
|
||
options = "".join(f'<option value="{u["login"]}">{u["name"]}</option>' for u in TEST_USERS)
|
||
return HTMLResponse(
|
||
f"""<!doctype html><meta charset=utf-8><title>Mock login</title>
|
||
<body style="font-family:system-ui;max-width:420px;margin:3rem auto;padding:0 1rem">
|
||
<h1 style="font-size:1.1rem">Sign in (mock)</h1>
|
||
<form method=get action=/control/login>
|
||
<select name=login style="font:inherit;padding:0.4rem">{options}</select>
|
||
<button style="font:inherit;padding:0.45rem 0.9rem;cursor:pointer">Sign in</button>
|
||
</form>
|
||
<p style="color:#888;font-size:0.85rem">Tip: use a separate browser or profile per
|
||
user so their sessions don't overwrite each other.</p>
|
||
</body>"""
|
||
)
|
||
if not email:
|
||
match = next((u for u in TEST_USERS if u["login"] == login), None)
|
||
email = match["email"] if match else f"{login}@example.com"
|
||
token = issue_session(login=login, email=email, avatar_url=None)
|
||
resp = RedirectResponse(url=dest, status_code=303)
|
||
resp.set_cookie(COOKIE_NAME, token, httponly=True, samesite="lax", secure=False, path="/")
|
||
return resp
|
||
|
||
|
||
@app.get("/dashboard/api/auth/login")
|
||
async def mock_github_login(redirect_to: str = "", login: str = "") -> Response:
|
||
"""Mock stand-in for GitHub OAuth: the dashboard's "Continue with GitHub"
|
||
button lands here. With no ``login``, render a picker of the fake GitHub
|
||
test users; once one is chosen, mint the real session cookie and redirect
|
||
back into the dashboard (``redirect_to``)."""
|
||
ui = os.environ.get("DASHBOARD_BASE_URL", "").rstrip("/")
|
||
dest = redirect_to or (f"{ui}/agents" if ui else "/agents")
|
||
if not login:
|
||
options = "".join(
|
||
f'<option value="{u["login"]}">{u["name"]} (@{u["login"]})</option>' for u in TEST_USERS
|
||
)
|
||
return HTMLResponse(
|
||
f"""<!doctype html><meta charset=utf-8><title>Continue with GitHub (mock)</title>
|
||
<body style="font-family:system-ui;max-width:420px;margin:3rem auto;padding:0 1rem">
|
||
<h1 style="font-size:1.1rem">Continue with GitHub (mock)</h1>
|
||
<p style="color:#888;font-size:0.9rem">Pick a fake GitHub account to sign in as.</p>
|
||
<form method=get action=/dashboard/api/auth/login>
|
||
<input type=hidden name=redirect_to value="{dest}">
|
||
<select name=login style="font:inherit;padding:0.4rem">{options}</select>
|
||
<button style="font:inherit;padding:0.45rem 0.9rem;cursor:pointer">Continue</button>
|
||
</form>
|
||
<p style="color:#888;font-size:0.85rem">Tip: use a separate browser or profile per
|
||
user so their sessions don't overwrite each other.</p>
|
||
</body>"""
|
||
)
|
||
match = next((u for u in TEST_USERS if u["login"] == login), None)
|
||
email = match["email"] if match else f"{login}@example.com"
|
||
token = issue_session(login=login, email=email, avatar_url=None)
|
||
resp = RedirectResponse(url=dest, status_code=303)
|
||
resp.set_cookie(COOKIE_NAME, token, httponly=True, samesite="lax", secure=False, path="/")
|
||
return resp
|
||
|
||
|
||
# The real dashboard registered /dashboard/api/auth/login first (via
|
||
# include_router), so Starlette would match it before ours. Move ours to the
|
||
# front of the table so the mock picker shadows the real OAuth redirect.
|
||
for _i, _route in enumerate(app.router.routes):
|
||
if getattr(_route, "endpoint", None) is mock_github_login:
|
||
app.router.routes.insert(0, app.router.routes.pop(_i))
|
||
break
|
||
|
||
|
||
@app.post("/control/logout")
|
||
async def control_logout() -> JSONResponse:
|
||
resp = JSONResponse({"ok": True})
|
||
resp.delete_cookie(COOKIE_NAME, path="/")
|
||
return resp
|
||
|
||
|
||
# --- serve the REAL built ui/ SPA, same-origin so the session cookie works ----
|
||
# The "Open in Web" link (DASHBOARD_BASE_URL/agents/{id}) lands on the real app;
|
||
# it calls /dashboard/api/* (same origin) and streams via the dashboard proxy.
|
||
UI_PUBLIC = REPO_ROOT / "ui" / ".output" / "public"
|
||
_ASSETS_ROOT = (UI_PUBLIC / "assets").resolve()
|
||
|
||
|
||
def _ui_file(name: str) -> FileResponse:
|
||
path = UI_PUBLIC / name
|
||
if not path.is_file():
|
||
raise HTTPException(404, f"{name} not built — run `bun run build` in ui/")
|
||
return FileResponse(path)
|
||
|
||
|
||
@app.get("/assets/{asset_path:path}")
|
||
async def ui_asset(asset_path: str) -> FileResponse:
|
||
# Explicit route, not app.mount(StaticFiles): LangGraph's custom-app loader
|
||
# serves APIRoutes but drops sub-app Mounts, so a mount 404s under it.
|
||
target = (_ASSETS_ROOT / asset_path).resolve()
|
||
if not str(target).startswith(str(_ASSETS_ROOT)) or not target.is_file():
|
||
raise HTTPException(404, "asset not found")
|
||
return FileResponse(target)
|
||
|
||
|
||
@app.get("/_shell.html", response_class=HTMLResponse)
|
||
async def ui_shell() -> FileResponse:
|
||
return _ui_file("_shell.html")
|
||
|
||
|
||
@app.get("/manifest.webmanifest")
|
||
async def ui_manifest() -> FileResponse:
|
||
return _ui_file("manifest.webmanifest")
|
||
|
||
|
||
@app.get("/favicon.png")
|
||
async def ui_favicon() -> FileResponse:
|
||
return _ui_file("favicon.png")
|
||
|
||
|
||
@app.get("/apple-touch-icon.png")
|
||
async def ui_apple_icon() -> FileResponse:
|
||
return _ui_file("apple-touch-icon.png")
|
||
|
||
|
||
@app.get("/logo-mark.png")
|
||
async def ui_logo_mark() -> FileResponse:
|
||
return _ui_file("logo-mark.png")
|
||
|
||
|
||
# Client routes used by the handoff tests: serve the SPA shell; the client
|
||
# router boots at the current URL. Kept explicit (no catch-all) so LangGraph's
|
||
# own root routes — which the dashboard proxy calls server-side — are untouched.
|
||
@app.get("/agents/{thread_id}", response_class=HTMLResponse)
|
||
async def ui_agents_thread(thread_id: str) -> FileResponse: # noqa: ARG001
|
||
return _ui_file("_shell.html")
|
||
|
||
|
||
@app.get("/agents/{thread_id}/plan", response_class=HTMLResponse)
|
||
async def ui_agents_plan(thread_id: str) -> FileResponse: # noqa: ARG001
|
||
return _ui_file("_shell.html")
|
||
|
||
|
||
@app.get("/login", response_class=HTMLResponse)
|
||
async def ui_login() -> FileResponse:
|
||
return _ui_file("_shell.html")
|
||
|
||
|
||
@app.get("/mock/users")
|
||
async def mock_users() -> JSONResponse:
|
||
"""The named test users that drive the Slack sender + login dropdowns."""
|
||
return JSONResponse(TEST_USERS)
|
||
|
||
|
||
@app.get("/mock/slack/messages")
|
||
async def slack_messages() -> JSONResponse:
|
||
msgs = fakes.slack_messages(CURRENT_THREAD["channel"])
|
||
return JSONResponse(
|
||
[
|
||
{
|
||
"user": m["user"],
|
||
"text": m["text"],
|
||
"is_bot": m["is_bot"],
|
||
"ts": m["ts"],
|
||
"thread_ts": m["thread_ts"],
|
||
}
|
||
for m in msgs
|
||
]
|
||
)
|
||
|
||
|
||
# --- mock UIs --------------------------------------------------------------
|
||
@app.get("/mock/slack", response_class=HTMLResponse)
|
||
async def mock_slack_page() -> str:
|
||
return (STATIC_DIR / "slack.html").read_text()
|
||
|
||
|
||
@app.get("/mock/github", response_class=HTMLResponse)
|
||
async def mock_github_page() -> str:
|
||
return (STATIC_DIR / "github.html").read_text()
|
||
|
||
|
||
def _pr_html_url(pr: dict[str, Any]) -> str:
|
||
return f"{BASE_URL}/mock/github/{pr['owner']}/{pr['repo']}/pull/{pr['number']}"
|
||
|
||
|
||
@app.get("/mock/github/data")
|
||
async def mock_github_data() -> JSONResponse:
|
||
return JSONResponse(
|
||
[
|
||
{
|
||
"number": p["number"],
|
||
"title": p["title"],
|
||
"head": p["head"],
|
||
"base": p["base"],
|
||
"state": p["state"],
|
||
"draft": p["draft"],
|
||
"author": p["author"],
|
||
"body": p["body"],
|
||
"files": p["files"],
|
||
"url": _pr_html_url(p),
|
||
}
|
||
for p in fakes.PULLS
|
||
]
|
||
)
|
||
|
||
|
||
@app.get("/mock/github/{owner}/{repo}/pull/{number}", response_class=HTMLResponse)
|
||
async def mock_github_pr(owner: str, repo: str, number: int) -> HTMLResponse: # noqa: ARG001
|
||
pr = fakes.find_pull(number)
|
||
if pr is None:
|
||
return HTMLResponse(f"<h1>PR #{number} not found</h1>", status_code=404)
|
||
files = "".join(
|
||
f'<li data-file="{f["filename"]}">{f["filename"]} '
|
||
f"<span class='stat'>+{f['additions']} −{f['deletions']}</span></li>"
|
||
for f in pr["files"]
|
||
)
|
||
draft = " (draft)" if pr["draft"] else ""
|
||
return HTMLResponse(
|
||
f"""<!doctype html><meta charset=utf-8>
|
||
<title>PR #{pr["number"]} — {pr["owner"]}/{pr["repo"]}</title>
|
||
<body style="font-family:system-ui;max-width:720px;margin:2rem auto">
|
||
<p><a href="/mock/github">← all pull requests</a></p>
|
||
<h1 id="pr-title">{pr["title"]}{draft}</h1>
|
||
<p>#{pr["number"]} · <span id="pr-state">{pr["state"]}</span> ·
|
||
<code id="pr-head">{pr["head"]}</code> → <code>{pr["base"]}</code> ·
|
||
by <span id="pr-author">{pr["author"]}</span></p>
|
||
<h3>Description</h3><pre id="pr-body">{pr["body"]}</pre>
|
||
<h3>Files changed ({len(pr["files"])})</h3>
|
||
<ul id="pr-files">{files}</ul>
|
||
</body>"""
|
||
)
|
||
|
||
|
||
# --- fake GitHub REST API (open_pull_request hits this) --------------------
|
||
def _gh_pr_json(pr: dict[str, Any]) -> dict[str, Any]:
|
||
return {
|
||
"number": pr["number"],
|
||
"html_url": _pr_html_url(pr),
|
||
"state": pr["state"],
|
||
"draft": pr["draft"],
|
||
"merged": pr["merged"],
|
||
"title": pr["title"],
|
||
"body": pr["body"],
|
||
"user": {"login": pr["author"]},
|
||
"head": {"ref": pr["head"]},
|
||
"base": {"ref": pr["base"]},
|
||
"additions": pr["additions"],
|
||
"deletions": pr["deletions"],
|
||
"changed_files": len(pr["files"]),
|
||
}
|
||
|
||
|
||
@app.get("/fake-gh/repos/{owner}/{repo}")
|
||
async def gh_get_repo(owner: str, repo: str) -> JSONResponse:
|
||
return JSONResponse({"full_name": f"{owner}/{repo}", "private": False})
|
||
|
||
|
||
@app.get("/fake-gh/repos/{owner}/{repo}/pulls")
|
||
async def gh_list_pulls(owner: str, repo: str) -> JSONResponse: # noqa: ARG001
|
||
return JSONResponse([])
|
||
|
||
|
||
@app.post("/fake-gh/repos/{owner}/{repo}/pulls")
|
||
async def gh_create_pull(owner: str, repo: str, request: Request) -> JSONResponse:
|
||
body = await request.json()
|
||
pr = fakes.create_pull(
|
||
owner,
|
||
repo,
|
||
head=body.get("head", ""),
|
||
base=body.get("base", "main"),
|
||
title=body.get("title", ""),
|
||
body=body.get("body", ""),
|
||
draft=bool(body.get("draft", True)),
|
||
)
|
||
return JSONResponse(_gh_pr_json(pr), status_code=201)
|
||
|
||
|
||
@app.get("/fake-gh/repos/{owner}/{repo}/pulls/{number}")
|
||
async def gh_get_pull(owner: str, repo: str, number: int) -> JSONResponse: # noqa: ARG001
|
||
pr = fakes.find_pull(number)
|
||
if pr is None:
|
||
return JSONResponse({"message": "Not Found"}, status_code=404)
|
||
return JSONResponse(_gh_pr_json(pr))
|
||
|
||
|
||
# --- fake Slack API (real slack code hits this) ----------------------------
|
||
def _ok(extra: dict[str, Any] | None = None) -> JSONResponse:
|
||
return JSONResponse({"ok": True, **(extra or {})})
|
||
|
||
|
||
@app.post("/fake-slack/chat.postMessage")
|
||
async def slack_post_message(request: Request) -> JSONResponse:
|
||
body = await request.json()
|
||
ts = fakes.add_slack_message(
|
||
body.get("channel", ""),
|
||
body.get("thread_ts", ""),
|
||
user=BOT_USER_ID,
|
||
text=body.get("text", ""),
|
||
blocks=body.get("blocks"),
|
||
is_bot=True,
|
||
)
|
||
return _ok({"ts": ts, "message": {"ts": ts}})
|
||
|
||
|
||
@app.post("/fake-slack/chat.postEphemeral")
|
||
async def slack_post_ephemeral(request: Request) -> JSONResponse:
|
||
await request.body()
|
||
return _ok({"message_ts": fakes.next_slack_ts()})
|
||
|
||
|
||
@app.post("/fake-slack/assistant.threads.setStatus")
|
||
async def slack_set_status(request: Request) -> JSONResponse:
|
||
await request.body()
|
||
return _ok()
|
||
|
||
|
||
@app.post("/fake-slack/reactions.add")
|
||
async def slack_reactions_add(request: Request) -> JSONResponse:
|
||
await request.body()
|
||
return _ok()
|
||
|
||
|
||
@app.get("/fake-slack/users.info")
|
||
async def slack_users_info(user: str = "") -> JSONResponse:
|
||
info = _SLACK_USERS.get(
|
||
user, {"name": "devuser", "real_name": "Dev User", "email": "dev@example.com"}
|
||
)
|
||
return _ok(
|
||
{
|
||
"user": {
|
||
"id": user,
|
||
"name": info["name"],
|
||
"real_name": info["real_name"],
|
||
"profile": {
|
||
"email": info["email"],
|
||
"display_name": info["real_name"],
|
||
"real_name": info["real_name"],
|
||
},
|
||
}
|
||
}
|
||
)
|
||
|
||
|
||
@app.get("/fake-slack/conversations.info")
|
||
async def slack_conversations_info(channel: str = "") -> JSONResponse:
|
||
return _ok(
|
||
{
|
||
"channel": {
|
||
"id": channel,
|
||
"name": "demo",
|
||
"name_normalized": "demo",
|
||
"topic": {"value": "Demo channel topic"},
|
||
"purpose": {"value": "Demo channel purpose"},
|
||
}
|
||
}
|
||
)
|
||
|
||
|
||
@app.get("/fake-slack/conversations.replies")
|
||
async def slack_conversations_replies(channel: str = "", ts: str = "") -> JSONResponse:
|
||
msgs = fakes.slack_thread(channel, ts)
|
||
return _ok(
|
||
{
|
||
"messages": [
|
||
{
|
||
"type": "message",
|
||
"user": m["user"],
|
||
"text": m["text"],
|
||
"ts": m["ts"],
|
||
"thread_ts": m["thread_ts"],
|
||
}
|
||
for m in msgs
|
||
]
|
||
}
|
||
)
|
||
|
||
|
||
@app.get("/fake-slack/conversations.history")
|
||
async def slack_conversations_history(channel: str = "") -> JSONResponse: # noqa: ARG001
|
||
return _ok({"messages": []})
|
||
|
||
|
||
@app.get("/fake-slack/chat.getPermalink")
|
||
async def slack_get_permalink(channel: str = "", message_ts: str = "") -> JSONResponse: # noqa: ARG001
|
||
return _ok({"permalink": f"{BASE_URL}/mock/slack"})
|
||
|
||
|
||
# Quietly reference imports used only for env side effects.
|
||
_ = (e2e_env, HUMAN_USER)
|