open-swe/ui/src/components/ReviewStylesPanel.tsx
Johannes du Plessis faa27479c3
fix: review style prompts UX, stale runs, and OAuth refresh (#1321)
* fix(dashboard): review style prompts UX, stale runs, and OAuth refresh

Reconcile stuck "running" analysis state, add cancel/remove for style
profiles, stack the review styles UI vertically, and auto-refresh expiring
GitHub user tokens with proactive and 401-triggered rotation.

* fix(dashboard): address review feedback on style prompts PR

Restore GitHub repo access checks on create/save with token refresh,
and preserve running status when LangGraph sync fails transiently.

---------

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
2026-05-21 17:44:04 +00:00

354 lines
12 KiB
TypeScript

import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import { useEffect, useState } from "react";
import type { ReviewStyle } from "@/lib/api";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import {
Combobox,
ComboboxContent,
ComboboxEmpty,
ComboboxInput,
ComboboxItem,
ComboboxList,
} from "@/components/ui/combobox";
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
import { Skeleton } from "@/components/ui/skeleton";
import { Textarea } from "@/components/ui/textarea";
import { ApiError, api, isGithubReauthError, loginUrl } from "@/lib/api";
import { normalizeRepoFullName } from "@/lib/repo";
function formatMutationError(e: Error): string {
return isGithubReauthError(e)
? "GitHub token expired — sign in again using the link above."
: e.message;
}
function statusVariant(status: ReviewStyle["status"]) {
switch (status) {
case "completed":
return "default" as const;
case "running":
return "secondary" as const;
case "failed":
return "destructive" as const;
default:
return "outline" as const;
}
}
export function ReviewStylesPanel() {
const qc = useQueryClient();
const [error, setError] = useState<string | null>(null);
const [addRepo, setAddRepo] = useState("");
const [selected, setSelected] = useState<string | null>(null);
const [draftPrompt, setDraftPrompt] = useState("");
const styles = useQuery({
queryKey: ["reviewStyles"],
queryFn: api.listReviewStyles,
refetchInterval: (q) => {
const hasRunning = (q.state.data ?? []).some((r) => r.status === "running");
return hasRunning ? 4000 : false;
},
});
const repos = useQuery({
queryKey: ["repos"],
queryFn: async () => {
try {
return await api.repos();
} catch (e) {
if (e instanceof ApiError && e.status === 401)
return { installations: [], repositories: [] };
throw e;
}
},
});
const detail = useQuery({
queryKey: ["reviewStyle", selected],
queryFn: () => api.getReviewStyle(selected!),
enabled: !!selected,
refetchInterval: (q) => (q.state.data?.status === "running" ? 4000 : false),
});
useEffect(() => {
if (detail.data?.custom_prompt != null) {
setDraftPrompt(detail.data.custom_prompt);
} else if (detail.data) {
setDraftPrompt("");
}
}, [detail.data?.custom_prompt, detail.data?.full_name]);
const createStyle = useMutation({
mutationFn: (full_name: string) => api.createReviewStyle(full_name),
onSuccess: (record) => {
void qc.invalidateQueries({ queryKey: ["reviewStyles"] });
setSelected(record.full_name);
setError(null);
},
onError: (e: Error) => setError(formatMutationError(e)),
});
const analyze = useMutation({
mutationFn: (full_name: string) => api.analyzeReviewStyle(full_name),
onSuccess: () => {
void qc.invalidateQueries({ queryKey: ["reviewStyles"] });
void qc.invalidateQueries({ queryKey: ["reviewStyle", selected] });
setError(null);
},
onError: (e: Error) => setError(formatMutationError(e)),
});
const savePrompt = useMutation({
mutationFn: ({ full_name, custom_prompt }: { full_name: string; custom_prompt: string }) =>
api.saveReviewStylePrompt(full_name, custom_prompt),
onSuccess: () => {
void qc.invalidateQueries({ queryKey: ["reviewStyles"] });
void qc.invalidateQueries({ queryKey: ["reviewStyle", selected] });
setError(null);
},
onError: (e: Error) => setError(formatMutationError(e)),
});
const cancelAnalysis = useMutation({
mutationFn: (full_name: string) => api.cancelReviewStyle(full_name),
onSuccess: () => {
void qc.invalidateQueries({ queryKey: ["reviewStyles"] });
void qc.invalidateQueries({ queryKey: ["reviewStyle", selected] });
setError(null);
},
onError: (e: Error) => setError(formatMutationError(e)),
});
const removeStyle = useMutation({
mutationFn: (full_name: string) => api.deleteReviewStyle(full_name),
onSuccess: (_data, full_name) => {
void qc.invalidateQueries({ queryKey: ["reviewStyles"] });
if (selected === full_name) {
setSelected(null);
setDraftPrompt("");
}
setError(null);
},
onError: (e: Error) => setError(formatMutationError(e)),
});
if (styles.isLoading) {
return <Skeleton className="h-40" />;
}
const configured = new Set((styles.data ?? []).map((s) => s.full_name));
const suggestedRepos = (repos.data?.repositories ?? []).filter(
(r) => !configured.has(r.full_name),
);
const normalizedAddRepo = normalizeRepoFullName(addRepo);
const canAdd = normalizedAddRepo !== null && !configured.has(normalizedAddRepo);
const active = detail.data ?? styles.data?.find((s) => s.full_name === selected) ?? null;
const handleAdd = () => {
if (!normalizedAddRepo || !canAdd) return;
void createStyle
.mutateAsync(normalizedAddRepo)
.then(() => setAddRepo(""))
.catch(() => undefined);
};
const githubReauth =
(repos.isError && isGithubReauthError(repos.error)) ||
(error !== null && /github token|re-login required/i.test(error));
return (
<div className="flex flex-col gap-6 p-4">
{githubReauth && (
<div className="rounded-md border border-destructive/40 bg-destructive/5 px-3 py-2 text-xs text-destructive">
Your GitHub connection expired.{" "}
<a href={loginUrl()} className="font-medium underline underline-offset-2">
Sign in with GitHub again
</a>{" "}
to list installed repos and run style analysis.
</div>
)}
<section className="space-y-4">
<div className="space-y-2">
<Label htmlFor="add-repo">Add repository</Label>
<div className="flex flex-col gap-2 sm:flex-row sm:items-end">
<Input
id="add-repo"
placeholder="owner/repo"
value={addRepo}
onChange={(e) => setAddRepo(e.target.value)}
onKeyDown={(e) => {
if (e.key === "Enter") {
e.preventDefault();
handleAdd();
}
}}
className="sm:flex-1"
/>
<Button
size="sm"
className="shrink-0 sm:w-auto"
disabled={!canAdd || createStyle.isPending}
onClick={handleAdd}
>
Add
</Button>
</div>
{suggestedRepos.length > 0 && (
<Combobox
items={suggestedRepos.map((r) => r.full_name)}
value={addRepo}
onValueChange={(v) => setAddRepo(typeof v === "string" ? v : "")}
>
<ComboboxInput
placeholder="Search installed repos…"
showClear
className="w-full"
/>
<ComboboxContent className="min-w-[var(--anchor-width)]">
<ComboboxList className="max-h-48">
<ComboboxEmpty>No matches</ComboboxEmpty>
{suggestedRepos.map((r) => (
<ComboboxItem key={r.full_name} value={r.full_name}>
<span className="truncate">{r.full_name}</span>
{r.private && (
<span className="ml-auto text-[10px] text-muted-foreground">
private
</span>
)}
</ComboboxItem>
))}
</ComboboxList>
</ComboboxContent>
</Combobox>
)}
</div>
<div className="space-y-2">
<p className="text-xs font-medium text-foreground">Repositories</p>
{(styles.data ?? []).length === 0 ? (
<p className="text-xs text-muted-foreground">No repositories yet.</p>
) : (
<ul className="flex flex-wrap gap-2">
{(styles.data ?? []).map((s) => (
<li key={s.full_name}>
<button
type="button"
className={`inline-flex max-w-full items-center gap-2 rounded-md border px-2.5 py-1.5 text-left text-xs transition-colors hover:bg-muted ${
selected === s.full_name
? "border-primary bg-muted font-medium"
: "border-border"
}`}
onClick={() => setSelected(s.full_name)}
>
<span className="truncate">{s.full_name}</span>
<Badge variant={statusVariant(s.status)} className="shrink-0">
{s.status}
</Badge>
</button>
</li>
))}
</ul>
)}
</div>
</section>
<div className="border-t border-border" />
<section className="space-y-3">
{!selected || !active ? (
<p className="text-xs text-muted-foreground">
Select a repository above to view or edit its review style prompt.
</p>
) : (
<>
<p className="text-sm font-medium text-foreground">{active.full_name}</p>
<div className="flex flex-wrap items-center gap-2 text-xs">
<Badge variant={statusVariant(active.status)}>{active.status}</Badge>
{active.top_reviewers.length > 0 && (
<span className="text-muted-foreground">
Reviewers: {active.top_reviewers.join(", ")}
</span>
)}
{active.prs_sampled > 0 && (
<span className="text-muted-foreground">
{active.prs_sampled} PRs · {active.reviews_sampled} reviews sampled
</span>
)}
</div>
{active.analysis_summary && (
<p className="text-xs text-muted-foreground">{active.analysis_summary}</p>
)}
{active.error && <p className="text-xs text-destructive">{active.error}</p>}
<div className="flex flex-wrap gap-2">
<Button
size="sm"
variant="secondary"
disabled={active.status === "running" || analyze.isPending}
onClick={() => {
void analyze.mutateAsync(active.full_name).catch(() => undefined);
}}
>
{active.status === "running" ? "Analyzing…" : "Run analysis"}
</Button>
{active.status === "running" && (
<Button
size="sm"
variant="outline"
disabled={cancelAnalysis.isPending}
onClick={() => void cancelAnalysis.mutateAsync(active.full_name)}
>
Cancel
</Button>
)}
<Button
size="sm"
disabled={!draftPrompt.trim() || savePrompt.isPending}
onClick={() =>
void savePrompt.mutateAsync({
full_name: active.full_name,
custom_prompt: draftPrompt,
})
}
>
Save prompt
</Button>
<Button
size="sm"
variant="destructive"
disabled={removeStyle.isPending}
onClick={() => {
if (
!window.confirm(
`Remove ${active.full_name} from review style prompts? This cannot be undone.`,
)
) {
return;
}
void removeStyle.mutateAsync(active.full_name);
}}
>
Remove
</Button>
</div>
<Textarea
className="min-h-[320px] w-full font-mono text-xs"
value={draftPrompt}
onChange={(e) => setDraftPrompt(e.target.value)}
placeholder={
active.status === "running"
? "Analysis in progress…"
: "Run analysis or write a custom prompt for this repository."
}
disabled={active.status === "running"}
/>
</>
)}
{error && <p className="text-xs text-destructive">{error}</p>}
</section>
</div>
);
}