mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 09:13:14 +00:00
b5ed2a6b8b
* fix: safety net middleware always skipped due to key-existence check
The open_pr_if_needed after-agent middleware checked `if 'success' in pr_payload`
which evaluates True for BOTH success and failure responses from commit_and_open_pr
(all responses include the 'success' key). This meant the safety net never fired.
Fix: use `pr_payload.get('success')` to check the VALUE instead of key existence.
Evidence: 6+ production traces in last 24h where commit_and_open_pr returned
success=False but the safety net silently skipped (non-fast-forward push failures,
missing GitHub token, workflow permission errors, API 500 errors).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* update
---------
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Palash Shah <palash@langchain.dev>
|
||
|---|---|---|
| .. | ||
| test_auth_sources.py | ||
| test_ensure_no_empty_msg.py | ||
| test_get_pr_review_comments.py | ||
| test_github_comment_prompts.py | ||
| test_github_issue_webhook.py | ||
| test_github_pr_label.py | ||
| test_github_review.py | ||
| test_github_security.py | ||
| test_http_security.py | ||
| test_multimodal.py | ||
| test_open_pr_middleware.py | ||
| test_proxy_auth.py | ||
| test_recent_comments.py | ||
| test_repo_extraction.py | ||
| test_sandbox_paths.py | ||
| test_slack_context.py | ||