open-swe/tests/test_sanitize_fireworks_messages.py
seahaven-openswe[bot] c2bc7720cd
Some checks are pending
CI / Lint (push) Waiting to run
CI / Format check (push) Waiting to run
CI / Unit tests (push) Waiting to run
CI / Playwright E2E (push) Waiting to run
CI / Docker build smoke (push) Waiting to run
CI / Triage ledger up to date (push) Waiting to run
CI / ui bun.lock in sync (push) Waiting to run
feat: port LangSmith LLM Gateway routing from upstream (#1671, #1673, #1674, #1678) (#155)
* feat: port LangSmith LLM Gateway routing from upstream (#1671, #1673, #1674, #1678)

Ports four upstream commits that add opt-in LLM call routing through the
LangSmith Gateway, preserving fork conventions (Bedrock/Fireworks model IDs,
no-agent-attribution, bun toolchain).

- #1671 (e9dc6e01): opt-in gateway routing — new gateway.py, team-settings
  toggle, admin UI section, wired into make_model for all graph entrypoints
- #1673 (702ef908): dedicated LANGSMITH_GATEWAY_API_KEY precedence over
  platform LANGSMITH_API_KEY
- #1674 (5f7c2f46): fix Fireworks gateway base URL to /fireworks (bare host,
  SDK appends /v1/chat/completions) + SanitizeFireworksMessagesMiddleware
- #1678 (73b7d1c0): fix OpenAI Responses reasoning replay —
  SanitizeOpenAIResponsesMiddleware, store/include config for encrypted
  reasoning content, reasoning_effort coercion for Chat Completions fallback

Refs #134

* fix: downgrade gateway not-routed log to debug, add Bedrock UI note, add sanitizer parity

- Downgrade logger.warning to logger.debug in gateway_overrides for
  not-routed providers and missing API key (Bedrock is the default
  provider in this fork, so these are expected steady states)
- Add Bedrock to the LLMGatewaySection route-toggle description so
  admins know it is not routed through the gateway
- Add SanitizeOpenAIResponsesMiddleware to chat.py for parity with
  server.py and reviewer.py
- Restore the Bedrock region comment in model.py that explains the
  AWS_REGION / AWS_DEFAULT_REGION precedence

Refs #138

---------

Co-authored-by: amoussa1229 <166072409+amoussa1229@users.noreply.github.com>
2026-07-09 14:44:15 -04:00

118 lines
4.5 KiB
Python

from __future__ import annotations
from unittest.mock import MagicMock
import pytest
from langchain_core.messages import AIMessage, HumanMessage, ToolMessage
from agent.middleware.sanitize_fireworks_messages import SanitizeFireworksMessagesMiddleware
def _make_request(messages: list[object], model: object | None = None) -> MagicMock:
request = MagicMock()
request.model = model
request.messages = messages
return request
def _fireworks_model() -> MagicMock:
"""A mock that satisfies ``_is_chat_fireworks`` via spec'd ``ChatFireworks``."""
try:
from langchain_fireworks.chat_models import ChatFireworks
except ImportError: # pragma: no cover
pytest.skip("langchain-fireworks not installed")
return MagicMock(spec=ChatFireworks)
class TestSanitizeFireworksMessagesMiddleware:
def test_drops_legacy_function_call(self) -> None:
message = AIMessage(
content="",
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
)
request = _make_request([message], model=_fireworks_model())
response = MagicMock()
def handler(req: object) -> object:
assert req is request
return response
result = SanitizeFireworksMessagesMiddleware().wrap_model_call(request, handler)
assert result is response
assert "function_call" not in message.additional_kwargs
# tool_calls are untouched
assert len(message.tool_calls) == 1
def test_preserves_message_without_function_call(self) -> None:
message = AIMessage(
content="ok",
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
)
request = _make_request([message], model=_fireworks_model())
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
assert "function_call" not in message.additional_kwargs
assert len(message.tool_calls) == 1
def test_drops_function_call_with_no_tool_calls(self) -> None:
message = AIMessage(
content="",
additional_kwargs={"function_call": {"name": "search", "arguments": "{}"}},
)
request = _make_request([message], model=_fireworks_model())
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
assert "function_call" not in message.additional_kwargs
@pytest.mark.asyncio
async def test_async_drops_legacy_function_call(self) -> None:
tool_result = ToolMessage(content="result", tool_call_id="tc1")
message = AIMessage(
content="",
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
)
request = _make_request(
[HumanMessage(content="hi"), message, tool_result],
model=_fireworks_model(),
)
response = MagicMock()
async def handler(req: object) -> object:
assert req is request
return response
result = await SanitizeFireworksMessagesMiddleware().awrap_model_call(request, handler)
assert result is response
assert "function_call" not in message.additional_kwargs
def test_ignores_non_fireworks_models(self) -> None:
message = AIMessage(
content="",
tool_calls=[{"name": "read_file", "args": {"file_path": "/x"}, "id": "tc1"}],
additional_kwargs={"function_call": {"name": "read_file", "arguments": "{}"}},
)
# Non-Fireworks model (plain MagicMock, no ChatFireworks in its spec chain)
request = _make_request([message], model=MagicMock())
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
# function_call preserved for non-Fireworks providers
assert "function_call" in message.additional_kwargs
def test_skips_non_ai_messages(self) -> None:
messages = [
HumanMessage(content="hi"),
ToolMessage(content="result", tool_call_id="tc1"),
]
request = _make_request(messages, model=_fireworks_model())
SanitizeFireworksMessagesMiddleware().wrap_model_call(request, lambda req: MagicMock())
# No AIMessages to mutate — handler still called
assert all(not isinstance(m, AIMessage) for m in messages)