mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-10-07 16:19:09 +00:00
Adam Moussa
2028208237
INJ-01 (high): fetch_image_block used follow_redirects=True with no per-hop revalidation and discarded the resolved-IP pin, so an attacker-authored Slack/ Linear image URL could 302-redirect the fetch to an internal host / cloud metadata endpoint (blind SSRF), and DNS-rebinding could bypass the one-shot is_url_safe check. Route image fetches through the same per-hop resolve+pin+ revalidate loop the http_request tool uses, lifted into url_safety as the shared request_with_safe_redirects. Also strip the per-host Slack/Linear bearer token on redirect so it can't be replayed to a redirect target. SC-1 (low): linear.py logged full image URLs (which can carry signed tokens) at DEBUG; multimodal logged them at INFO on every fetch. Log host-only. Sink lived in multimodal.py (unchanged by the feature work) but PR #128 widened its reach by no longer dropping images for text-only models. Fixing on the base branch so #130/#129 inherit it on rebase. Adds fetch_image_block SSRF regression tests (redirect-to-internal blocked; auth stripped on redirect). |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| add_finding.py | ||
| enter_plan_mode.py | ||
| fetch_url.py | ||
| http_request.py | ||
| linear_comment.py | ||
| linear_create_issue.py | ||
| linear_delete_issue.py | ||
| linear_get_issue.py | ||
| linear_get_issue_comments.py | ||
| linear_list_teams.py | ||
| linear_update_issue.py | ||
| list_findings.py | ||
| list_review_findings.py | ||
| open_pull_request.py | ||
| publish_review.py | ||
| read_finding_outcomes.py | ||
| read_repo_file.py | ||
| reply_to_finding_thread.py | ||
| request_pr_review.py | ||
| resolve_finding_thread.py | ||
| save_plan.py | ||
| save_review_style.py | ||
| schedule_thread_wakeup.py | ||
| search_repo_code.py | ||
| slack_add_reaction.py | ||
| slack_read_thread_messages.py | ||
| slack_start_new_thread.py | ||
| slack_thread_reply.py | ||
| update_finding.py | ||
| web_search.py | ||