mirror of
https://github.com/Sea-Haven-Industries/open-swe.git
synced 2026-09-30 06:53:14 +00:00
722279e277
The viewed-marker feature (#1441) reintroduced an owner-only gate on thread reads, regressing #1425 which made all threads readable by any org user. Reads no longer assert ownership; viewed markers are only written for the thread owner. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
140 lines
4.5 KiB
Python
140 lines
4.5 KiB
Python
from typing import Any
|
|
|
|
from agent.dashboard import thread_api
|
|
|
|
|
|
class FakeThreads:
|
|
def __init__(self, metadata: dict[str, Any], *, status: str = "idle") -> None:
|
|
self.thread = {"thread_id": "tid", "status": status, "metadata": metadata.copy()}
|
|
self.updates: list[dict[str, Any]] = []
|
|
|
|
async def get(self, thread_id: str) -> dict[str, Any]:
|
|
assert thread_id == "tid"
|
|
return self.thread
|
|
|
|
async def get_state(self, thread_id: str) -> dict[str, Any]:
|
|
assert thread_id == "tid"
|
|
return {"values": {"messages": []}}
|
|
|
|
async def update(self, *, thread_id: str, metadata: dict[str, Any]) -> None:
|
|
assert thread_id == "tid"
|
|
self.updates.append(metadata)
|
|
self.thread["metadata"] = {**self.thread["metadata"], **metadata}
|
|
|
|
async def search(self, **kwargs: Any) -> list[dict[str, Any]]:
|
|
return [self.thread]
|
|
|
|
|
|
class FakeRuns:
|
|
def __init__(self, status: str, run_id: str = "run-1") -> None:
|
|
self.status = status
|
|
self.run_id = run_id
|
|
|
|
async def list(self, thread_id: str, limit: int = 1) -> list[dict[str, str]]:
|
|
assert thread_id == "tid"
|
|
assert limit == 1
|
|
return [{"run_id": self.run_id, "status": self.status}]
|
|
|
|
|
|
class FakeClient:
|
|
def __init__(
|
|
self, metadata: dict[str, Any], run_status: str, *, thread_status: str = "idle"
|
|
) -> None:
|
|
self.threads = FakeThreads(metadata, status=thread_status)
|
|
self.runs = FakeRuns(run_status)
|
|
|
|
|
|
async def test_list_dashboard_threads_refreshes_finished_run_status(monkeypatch) -> None:
|
|
client = FakeClient(
|
|
{
|
|
"source": "dashboard",
|
|
"github_login": "octocat",
|
|
"latest_run_id": "run-1",
|
|
"latest_run_status": "pending",
|
|
},
|
|
"success",
|
|
)
|
|
monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
|
|
|
|
results = await thread_api.list_dashboard_threads("octocat")
|
|
|
|
assert results[0]["status"] == "finished"
|
|
assert results[0]["viewed"] is False
|
|
assert client.threads.thread["metadata"]["latest_run_status"] == "success"
|
|
|
|
|
|
async def test_get_dashboard_thread_marks_finished_thread_viewed(monkeypatch) -> None:
|
|
client = FakeClient(
|
|
{
|
|
"source": "dashboard",
|
|
"github_login": "octocat",
|
|
"latest_run_id": "run-1",
|
|
"latest_run_status": "success",
|
|
},
|
|
"success",
|
|
)
|
|
monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
|
|
|
|
result = await thread_api.get_dashboard_thread("tid", "octocat")
|
|
|
|
assert result["status"] == "finished"
|
|
assert result["viewed"] is True
|
|
assert isinstance(result["viewedAt"], int)
|
|
assert client.threads.thread["metadata"]["last_viewed_run_id"] == "run-1"
|
|
|
|
|
|
async def test_get_dashboard_thread_readable_by_non_owner(monkeypatch) -> None:
|
|
client = FakeClient(
|
|
{
|
|
"source": "slack",
|
|
"github_login": "octocat",
|
|
"latest_run_id": "run-1",
|
|
"latest_run_status": "success",
|
|
},
|
|
"success",
|
|
)
|
|
monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
|
|
|
|
result = await thread_api.get_dashboard_thread("tid", "someone-else")
|
|
|
|
assert result["status"] == "finished"
|
|
assert "last_viewed_run_id" not in client.threads.thread["metadata"]
|
|
|
|
|
|
async def test_get_dashboard_thread_skips_mark_viewed_when_disabled(monkeypatch) -> None:
|
|
client = FakeClient(
|
|
{
|
|
"source": "dashboard",
|
|
"github_login": "octocat",
|
|
"latest_run_id": "run-1",
|
|
"latest_run_status": "success",
|
|
},
|
|
"success",
|
|
)
|
|
monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
|
|
|
|
result = await thread_api.get_dashboard_thread("tid", "octocat", mark_viewed=False)
|
|
|
|
assert result["status"] == "finished"
|
|
assert result["viewed"] is False
|
|
assert "last_viewed_run_id" not in client.threads.thread["metadata"]
|
|
|
|
|
|
async def test_get_dashboard_thread_does_not_mark_running_thread_viewed(monkeypatch) -> None:
|
|
client = FakeClient(
|
|
{
|
|
"source": "dashboard",
|
|
"github_login": "octocat",
|
|
"latest_run_id": "run-1",
|
|
"latest_run_status": "running",
|
|
},
|
|
"running",
|
|
thread_status="busy",
|
|
)
|
|
monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
|
|
|
|
result = await thread_api.get_dashboard_thread("tid", "octocat")
|
|
|
|
assert result["status"] == "running"
|
|
assert result["viewed"] is False
|
|
assert "last_viewed_run_id" not in client.threads.thread["metadata"]
|