Compare commits

..

1 commit

Author SHA1 Message Date
3af8f844b1
Adopt Sea Haven agent conventions, no attribution
Codify the box-only #4 customizations into Git so the AWS deployment
(which deploys from this repo) actually applies them — previously only
the retired sh-openswe box had them.

- prompt.py: branch names feature|bug|hotfix/<kebab> (optional <KEY->);
  imperative PR titles with no conventional-commit type: prefix; PR body
  Summary/Validation/Tests/Notes; handbook commit format. Rewrite the
  collaboration template from an attribution MANDATE to a PROHIBITION —
  no Co-authored-by bot trailer, no "Made by [Open SWE]" footer, no
  agent/AI notes on any artifact.
- github_comments.py: add @seahaven-openswe (the deployed App slug) to
  the mention triggers.
- authorship.py: remove the now-unused attribution helpers
  (build_pr_attribution_footer, add_bot_coauthor_trailer,
  add_pr_collaboration_note, PR_ATTRIBUTION_*). Keep OPEN_SWE_BOT_* —
  server.py still uses them for the sandbox git identity.
- Flip the attribution unit tests to assert the no-attribution behavior;
  drop tests for the removed helpers.

Commits stay authored as the triggering user for now — flipping
authorship to the bot account depends on the Vercel preview-deploy
constraint and is deferred to #11.

Refs: #4 #11

Claude-Session: https://claude.ai/code/session_01DMhLf4G5V8MStJQyAW95hi
2026-06-27 21:26:59 -04:00
12 changed files with 26 additions and 54 deletions

View file

@ -4,7 +4,7 @@
# Reads check-runs on stdin — one
# name<US>status<US>conclusion<US>details_url
# per line, fields separated by ASCII Unit Separator (0x1F) — so it is unit-testable
# WITHOUT GitHub. promote-dev-to-prod.yml pipes the live `gh api .../check-runs`
# WITHOUT GitHub. promote_dev_to_prod.yml pipes the live `gh api .../check-runs`
# output in. 0x1F (not TAB) is used deliberately: TAB is IFS-whitespace, so an empty
# conclusion (every in_progress check has a null conclusion) would collapse and shift
# the columns — which would make the promote run fail to exclude itself. 0x1F is
@ -26,12 +26,12 @@
set -euo pipefail
EXCLUDE_RUN_ID="${EXCLUDE_RUN_ID:-}"
# Mandatory checks (one per line). Defaults to the CI suite, which runs on
# Mandatory checks (one per line). Defaults to the Agent CI suite, which runs on
# every push to dev (see ci.yml). Keep in sync with those job names; if a name
# drifts the gate blocks (fails safe) until the list is updated.
REQUIRED_CHECKS="${REQUIRED_CHECKS:-Lint
Format check
Unit tests
REQUIRED_CHECKS="${REQUIRED_CHECKS:-Agent lint
Agent format check
Agent unit tests
Playwright E2E}"
declare -A GREEN

View file

@ -62,7 +62,7 @@ jobs:
BUCKET: open-swe-dev-assets
DEPLOY_DOC: open-swe-dev-deploy
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@v2
with:
bun-version: latest
@ -100,7 +100,7 @@ jobs:
BUCKET: open-swe-prod-assets
DEPLOY_DOC: open-swe-prod-deploy
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@v2
with:
bun-version: latest

View file

@ -66,7 +66,7 @@ jobs:
id-token: write
contents: read
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: actions/setup-node@v4
with:
node-version: "24"
@ -102,7 +102,7 @@ jobs:
id-token: write
contents: read
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: actions/setup-node@v4
with:
node-version: "24"

View file

@ -1,6 +1,6 @@
name: Infra CI
# Path-filtered CI for the /infra CDK app (TypeScript). The existing "CI"
# Path-filtered CI for the /infra CDK app (TypeScript). The existing "Agent CI"
# (ci.yml) covers the Python agent; this adds tsc + jest + cdk synth for /infra so
# infra changes are gated on a PR the same way. Runs only when /infra changes.

View file

@ -1,11 +1,11 @@
name: CI
name: Agent CI
permissions:
contents: read
on:
push:
# dev as well as main so every dev HEAD carries the full CI signal that
# dev as well as main so every dev HEAD carries the full Agent CI signal that
# the dev->main promotion gate (check-dev-green.sh) reads. PR checks alone are
# not enough: an admin-merge can land a red PR onto dev.
branches: ["main", "dev"]
@ -18,10 +18,10 @@ concurrency:
jobs:
lint:
name: Lint
name: Agent lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Install dependencies
run: uv sync --locked --extra dev
@ -29,10 +29,10 @@ jobs:
run: make lint
format:
name: Format check
name: Agent format check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Install dependencies
run: uv sync --locked --extra dev
@ -40,10 +40,10 @@ jobs:
run: make format-check
unit-tests:
name: Unit tests
name: Agent unit tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Install dependencies
run: uv sync --locked --extra dev
@ -55,7 +55,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- uses: actions/setup-node@v4
with:

View file

@ -1,15 +0,0 @@
name: Dependency Review
on: pull_request
permissions:
contents: read
jobs:
dependency-review:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/dependency-review-action@v4
with:
fail-on-severity: high

View file

@ -1,13 +0,0 @@
name: Labeler
on:
pull_request:
permissions:
contents: read
pull-requests: write
issues: write
jobs:
labeler:
uses: Sea-Haven-Industries/.github/.github/workflows/callable-labeler.yaml@main

View file

@ -19,7 +19,7 @@ jobs:
contents: write
checks: read
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
with:
ref: dev
fetch-depth: 0

View file

@ -78,7 +78,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 360
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Install dependencies
run: uv sync --locked

View file

@ -50,7 +50,7 @@ jobs:
DEPLOY_DOC: open-swe-dev-deploy
TARGET_SHA: ${{ inputs.sha }}
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: aws-actions/configure-aws-credentials@v6
with:
role-to-assume: ${{ vars.AWS_DEPLOY_ROLE_APP_DEV }}
@ -75,7 +75,7 @@ jobs:
DEPLOY_DOC: open-swe-prod-deploy
TARGET_SHA: ${{ inputs.sha }}
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@v6
- uses: aws-actions/configure-aws-credentials@v6
with:
role-to-assume: ${{ vars.AWS_DEPLOY_ROLE_APP_PROD }}

View file

@ -57,8 +57,8 @@ uv run python -m evals.reviewer.run_eval --limit 3
### From the GitHub Action (recommended for full runs)
Trigger the **Reviewer eval** workflow (`.github/workflows/reviewer-eval.yml`)
from the Actions UI or `gh workflow run reviewer-eval.yml --ref prod -f limit=3`.
Trigger the **Reviewer eval** workflow (`.github/workflows/reviewer_eval.yml`)
from the Actions UI or `gh workflow run reviewer_eval.yml --ref prod -f limit=3`.
Run it on the **prod** branch so the harness/judge match the deployed reviewer it
scores. Running it on a durable runner (instead of inside the serving deployment)
means a deploy or container recycle can't kill a long run.

View file

@ -245,7 +245,7 @@ npm test # jest — naming Aspect
## CI/CD (T18 — `.github/workflows/ci-infra.yml` + `cd-infra.yml`)
Path-filtered, OIDC-only (no static keys). The Python agent keeps its own
`ci.yml` ("CI"); these two add the `/infra` half.
`ci.yml` ("Agent CI"); these two add the `/infra` half.
| Workflow | Trigger | Does |
|---|---|---|