From e024341ddd798ca07efc0ba98ea8d6238b52f7cf Mon Sep 17 00:00:00 2001
From: Brace Sproul <braceasproul@gmail.com>
Date: Fri, 25 Jul 2025 17:58:26 -0700
Subject: [PATCH] fix: Better message when tool call returned empty string
 (#537)

* fix: Better message when tool call returned empty string

* cr
---
 apps/open-swe/src/graphs/planner/nodes/take-action.ts        | 5 ++++-
 apps/open-swe/src/graphs/programmer/nodes/take-action.ts     | 5 ++++-
 .../open-swe/src/graphs/reviewer/nodes/take-review-action.ts | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/apps/open-swe/src/graphs/planner/nodes/take-action.ts b/apps/open-swe/src/graphs/planner/nodes/take-action.ts
index 42f1f953..767fe268 100644
--- a/apps/open-swe/src/graphs/planner/nodes/take-action.ts
+++ b/apps/open-swe/src/graphs/planner/nodes/take-action.ts
@@ -128,7 +128,10 @@ export async function takeActions(
       }
 
       if (!result) {
-        result = toolCallStatus;
+        result =
+          toolCallStatus === "success"
+            ? "Tool call returned no result"
+            : "Tool call failed";
       }
     } catch (e) {
       toolCallStatus = "error";
diff --git a/apps/open-swe/src/graphs/programmer/nodes/take-action.ts b/apps/open-swe/src/graphs/programmer/nodes/take-action.ts
index fc6472b0..6ce641a7 100644
--- a/apps/open-swe/src/graphs/programmer/nodes/take-action.ts
+++ b/apps/open-swe/src/graphs/programmer/nodes/take-action.ts
@@ -124,7 +124,10 @@ export async function takeAction(
       }
 
       if (!result) {
-        result = toolCallStatus;
+        result =
+          toolCallStatus === "success"
+            ? "Tool call returned no result"
+            : "Tool call failed";
       }
     } catch (e) {
       toolCallStatus = "error";
diff --git a/apps/open-swe/src/graphs/reviewer/nodes/take-review-action.ts b/apps/open-swe/src/graphs/reviewer/nodes/take-review-action.ts
index cc6629dc..d0bccc49 100644
--- a/apps/open-swe/src/graphs/reviewer/nodes/take-review-action.ts
+++ b/apps/open-swe/src/graphs/reviewer/nodes/take-review-action.ts
@@ -110,7 +110,10 @@ export async function takeReviewerActions(
       toolCallStatus = toolResult.status;
 
       if (!result) {
-        result = toolCallStatus;
+        result =
+          toolCallStatus === "success"
+            ? "Tool call returned no result"
+            : "Tool call failed";
       }
     } catch (e) {
       toolCallStatus = "error";