fix: process inputs of traceable with circular json (#343)

apps/open-swe/src/graphs/shared/initialize-sandbox.ts

@@ -216,7 +216,8 @@ export async function initializeSandbox(
   try {
     sandbox = await daytonaClient().create(DEFAULT_SANDBOX_CREATE_PARAMS);
     emitStepEvent(baseCreateSandboxAction, "success");
-  } catch {
+  } catch (e) {
+    logger.error("Failed to create sandbox environment", { e });
     emitStepEvent(
       baseCreateSandboxAction,
       "error",

apps/open-swe/src/tools/apply-patch.ts

@@ -31,7 +31,9 @@ export function createApplyPatchTool(state: GraphState) {
       const sandbox = await daytonaClient().get(sandboxSessionId);
 
       const { success: readFileSuccess, output: readFileOutput } =
-        await readFile(sandbox, file_path, {
+        await readFile({
+          sandbox,
+          filePath: file_path,
           workDir,
         });
       if (!readFileSuccess) {
@@ -84,7 +86,10 @@ export function createApplyPatchTool(state: GraphState) {
       }
 
       const { success: writeFileSuccess, output: writeFileOutput } =
-        await writeFile(sandbox, file_path, patchedContent, {
+        await writeFile({
+          sandbox,
+          filePath: file_path,
+          content: patchedContent,
           workDir,
         });
       if (!writeFileSuccess) {

apps/open-swe/src/utils/read-write.ts

@@ -33,20 +33,19 @@ async function handleCreateFile(
   }
 }
 
-async function readFileFunc(
+async function readFileFunc(inputs: {
-  sandbox: Sandbox,
+  sandbox: Sandbox;
-  filePath: string,
+  filePath: string;
-  args?: {
+  workDir?: string;
-    workDir?: string;
+}): Promise<{
-  },
-): Promise<{
   success: boolean;
   output: string;
 }> {
+  const { sandbox, filePath, workDir } = inputs;
   try {
     const readOutput = await sandbox.process.executeCommand(
       `cat "${filePath}"`,
-      args?.workDir,
+      workDir,
     );
 
     if (readOutput.exitCode !== 0) {
@@ -65,7 +64,9 @@ async function readFileFunc(
     };
   } catch (e: any) {
     if (e instanceof Error && e.message.includes("No such file or directory")) {
-      const createOutput = await handleCreateFile(sandbox, filePath, args);
+      const createOutput = await handleCreateFile(sandbox, filePath, {
+        workDir,
+      });
       if (createOutput.exitCode !== 0) {
         return {
           success: false,
@@ -73,7 +74,7 @@ async function readFileFunc(
         };
       } else {
         // If the file was created successfully, try reading it again.
-        return readFile(sandbox, filePath, args);
+        return readFile(inputs);
       }
     }
 
@@ -106,19 +107,22 @@ async function readFileFunc(
 
 export const readFile = traceable(readFileFunc, {
   name: "read_file",
+  processInputs: (inputs) => {
+    const { sandbox: _sandbox, ...rest } = inputs;
+    return rest;
+  },
 });
 
-async function writeFileFunc(
+async function writeFileFunc(inputs: {
-  sandbox: Sandbox,
+  sandbox: Sandbox;
-  filePath: string,
+  filePath: string;
-  content: string,
+  content: string;
-  args?: {
+  workDir?: string;
-    workDir?: string;
+}): Promise<{
-  },
-): Promise<{
   success: boolean;
   output: string;
 }> {
+  const { sandbox, filePath, content, workDir } = inputs;
   try {
     const delimiter = "EOF_" + Date.now() + "_" + Math.random().toString(36);
     const writeCommand = `cat > "${filePath}" << '${delimiter}'
@@ -126,7 +130,7 @@ ${content}
 ${delimiter}`;
     const writeOutput = await sandbox.process.executeCommand(
       writeCommand,
-      args?.workDir,
+      workDir,
     );
 
     if (writeOutput.exitCode !== 0) {
@@ -169,4 +173,8 @@ ${delimiter}`;
 
 export const writeFile = traceable(writeFileFunc, {
   name: "write_file",
+  processInputs: (inputs) => {
+    const { sandbox: _sandbox, ...rest } = inputs;
+    return rest;
+  },
 });