adam/open-swe
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/open-swe.git synced 2026-09-30 10:23:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: remove slack assistants api feature flag (#1295)

Browse source 
The SLACK_ASSISTANTS_API_ENABLED env flag and its gating function
are removed. set_slack_assistant_status now always proceeds when a
bot token and channel/thread are provided.

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Co-authored-by: Johannes du Plessis <51395795+johannes117@users.noreply.github.com>
This commit is contained in:
open-swe[bot] 2026-05-12 00:41:51 +00:00 • committed by GitHub
parent 5c7c78406c
commit d2c62e5fc6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
agent/utils/slack.py
View file

@ -27,14 +27,6 @@ GITHUB_PR_URL_RE = re.compile(r"https?://(?:www\.)?github\.com/[^\s<>|]+/[^\s<>|
URL_RE = re.compile(r"https?://[^\s<>|]+")
def _is_slack_assistants_api_enabled() -> bool:
"""Whether the Slack Assistants API integration is enabled.
Read at call time so tests and runtime can toggle via env without reimports.
"""
return os.environ.get("SLACK_ASSISTANTS_API_ENABLED", "").lower() in {"1", "true", "yes"}
DEFAULT_ASSISTANT_STATUS = "is thinking…"
# Curated rotating loading strings shown by Slack while the indicator is active.
@ -298,13 +290,10 @@ async def set_slack_assistant_status(
`loading_messages` is an optional list (max 10) of strings Slack rotates
through while the indicator is visible.
No-op (returning False) when the assistants feature flag is disabled,
the bot token is missing, or the channel/thread is not provided.
Failures are logged but never raised — the indicator is a UX nicety,
not a correctness requirement.
No-op (returning False) when the bot token is missing or the
channel/thread is not provided. Failures are logged but never raised —
the indicator is a UX nicety, not a correctness requirement.
"""
if not _is_slack_assistants_api_enabled():
return False
if not SLACK_BOT_TOKEN or not channel_id or not thread_ts:
return False

36
tests/test_slack_assistants_status.py
View file

@ -1,4 +1,4 @@
"""Tests for the Slack Assistants API integration (feature-flagged)."""
"""Tests for the Slack Assistants API integration."""
from __future__ import annotations
@ -30,26 +30,10 @@ def _async_client_cm(post_response: MagicMock) -> AsyncMock:
return client_cm
@pytest.mark.asyncio
async def test_set_slack_assistant_status_noop_when_flag_disabled(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.delenv("SLACK_ASSISTANTS_API_ENABLED", raising=False)
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
with patch.object(slack_utils.httpx, "AsyncClient", return_value=client_cm):
ok = await slack_utils.set_slack_assistant_status("C1", "1.0", "thinking…")
assert ok is False
client_cm.post.assert_not_called()
@pytest.mark.asyncio
async def test_set_slack_assistant_status_noop_when_no_token(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "")
client_cm = _async_client_cm(_ok_response())
@ -64,7 +48,6 @@ async def test_set_slack_assistant_status_noop_when_no_token(
async def test_set_slack_assistant_status_calls_correct_endpoint(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
@ -86,7 +69,6 @@ async def test_set_slack_assistant_status_calls_correct_endpoint(
async def test_set_slack_assistant_status_passes_loading_messages(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
@ -103,7 +85,6 @@ async def test_set_slack_assistant_status_passes_loading_messages(
async def test_set_slack_assistant_status_caps_loading_messages_at_10(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
@ -122,7 +103,6 @@ async def test_set_slack_assistant_status_caps_loading_messages_at_10(
async def test_set_slack_assistant_status_omits_loading_messages_when_unset(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
@ -137,7 +117,6 @@ async def test_set_slack_assistant_status_omits_loading_messages_when_unset(
async def test_set_slack_assistant_status_returns_false_on_slack_error(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_err_response("invalid_thread"))
@ -152,7 +131,6 @@ async def test_post_slack_thread_reply_does_not_call_set_status(
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Slack auto-clears the indicator on post; no extra setStatus call needed."""
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", "true")
monkeypatch.setattr(slack_utils, "SLACK_BOT_TOKEN", "xoxb-test")
client_cm = _async_client_cm(_ok_response())
@ -162,15 +140,3 @@ async def test_post_slack_thread_reply_does_not_call_set_status(
assert ok is True
assert client_cm.post.await_count == 1
assert client_cm.post.call_args.args[0].endswith("/chat.postMessage")
def test_is_slack_assistants_api_enabled_truthy_values(
monkeypatch: pytest.MonkeyPatch,
) -> None:
for truthy in ("1", "true", "TRUE", "yes", "Yes"):
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", truthy)
assert slack_utils._is_slack_assistants_api_enabled() is True
for falsy in ("0", "false", "no", "", "off"):
monkeypatch.setenv("SLACK_ASSISTANTS_API_ENABLED", falsy)
assert slack_utils._is_slack_assistants_api_enabled() is False