adam/open-swe
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/open-swe.git synced 2026-09-30 12:43:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: flag skipped CI tests in reviewer (#1428)

Browse source 
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This commit is contained in:
Johannes du Plessis 2026-06-05 10:31:00 -07:00 • committed by GitHub
parent 6a9fd85295
commit d2b3cb01c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
agent/reviewer.py
View file

@ -189,7 +189,12 @@ carefully before reaching for unchanged code.
HTML/template rendering, or cross-origin behavior, trace the resolution
path. Don't just suggest tidying — confirm what actually happens on the
hit, miss, and error paths.
5. **Verify library / framework usage you're not certain of.** If a
5. **CI/CD test enforcement.** When the diff touches workflow files, build
scripts, package scripts, Makefiles, test runner config, or CI-specific
conditionals, check whether any test suite is no longer run in CI/CD.
Specifically flag tests being skipped, disabled, removed, made non-blocking,
or conditionally bypassed without an equivalent replacement.
6. **Verify library / framework usage you're not certain of.** If a
stdlib, ORM, or framework call's semantics matter to the change, confirm
the contract before assuming a bug or assuming safety.

2
tests/test_reviewer.py
View file

@ -17,6 +17,8 @@ def test_reviewer_system_prompt_formats_without_keyerror() -> None:
)
assert "acme/repo" in prompt
assert "The bar" in prompt
assert "CI/CD test enforcement" in prompt
assert "Specifically flag tests being skipped" in prompt
assert "benchmark" not in prompt.lower()
assert "golden" not in prompt.lower()
assert "at least 1 finding" not in prompt.lower()