fix: prevent thread prefetches from marking threads viewed (#1456)

* fix: prevent thread prefetches from marking threads viewed

Sidebar prefetches now request thread details with mark_viewed=false so
loading /agents no longer clears the unread/finished indicator for
threads the user has not opened.

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>

* fix: always refetch active thread on mount to mark viewed

Prefetches cache details fetched with mark_viewed=false under the same
query key as the active thread. Forcing refetchOnMount="always" ensures
opening a thread issues a mark_viewed=true request, so last_viewed_* is
recorded even when prefetched data is still fresh.

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>

---------

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>

agent/dashboard/routes.py

@@ -783,9 +783,15 @@ async def api_create_thread(
 @router.get("/threads/{thread_id}")
 async def api_get_thread(
     thread_id: str,
+    mark_viewed: bool = True,
     session: dict[str, Any] = _SESSION_DEP,
 ) -> dict[str, Any]:
-    return await get_dashboard_thread(thread_id, session["sub"], email=session.get("email"))
+    return await get_dashboard_thread(
+        thread_id,
+        session["sub"],
+        email=session.get("email"),
+        mark_viewed=mark_viewed,
+    )
 
 
 @router.post("/threads/{thread_id}/messages")

agent/dashboard/thread_api.py

@@ -420,7 +420,7 @@ async def _mark_thread_viewed(
 
 
 async def get_dashboard_thread(
-    thread_id: str, login: str, *, email: str | None = None
+    thread_id: str, login: str, *, email: str | None = None, mark_viewed: bool = True
 ) -> dict[str, Any]:
     client = langgraph_client()
     try:
@@ -456,7 +456,7 @@ async def get_dashboard_thread(
             else None
         ),
     )
-    if status != "running":
+    if mark_viewed and status != "running":
         metadata = await _mark_thread_viewed(
             client,
             thread_id,

tests/test_dashboard_thread_api_activity.py

@@ -83,6 +83,25 @@ async def test_get_dashboard_thread_marks_finished_thread_viewed(monkeypatch) ->
     assert client.threads.thread["metadata"]["last_viewed_run_id"] == "run-1"
 
 
+async def test_get_dashboard_thread_skips_mark_viewed_when_disabled(monkeypatch) -> None:
+    client = FakeClient(
+        {
+            "source": "dashboard",
+            "github_login": "octocat",
+            "latest_run_id": "run-1",
+            "latest_run_status": "success",
+        },
+        "success",
+    )
+    monkeypatch.setattr(thread_api, "langgraph_client", lambda: client)
+
+    result = await thread_api.get_dashboard_thread("tid", "octocat", mark_viewed=False)
+
+    assert result["status"] == "finished"
+    assert result["viewed"] is False
+    assert "last_viewed_run_id" not in client.threads.thread["metadata"]
+
+
 async def test_get_dashboard_thread_does_not_mark_running_thread_viewed(monkeypatch) -> None:
     client = FakeClient(
         {

ui/src/lib/agents/api.ts

@@ -93,8 +93,12 @@ export const agentsApi = {
     agentsRequest<void>(`/schedules/${encodeURIComponent(scheduleId)}`, {
       method: "DELETE",
     }),
-  getThread: (threadId: string) =>
-    agentsRequest<AgentThread>(`/threads/${encodeURIComponent(threadId)}`),
+  getThread: (threadId: string, options?: { markViewed?: boolean }) =>
+    agentsRequest<AgentThread>(
+      `/threads/${encodeURIComponent(threadId)}${
+        options?.markViewed === false ? "?mark_viewed=false" : ""
+      }`
+    ),
   createThread: (body: ThreadCreateRequest) =>
     agentsRequest<AgentThread>("/threads", {
       method: "POST",

ui/src/lib/agents/queries.ts

@@ -33,7 +33,7 @@ export function usePrefetchAgentThreadDetails(
     threadIds.forEach((threadId) => {
       void queryClient.prefetchQuery({
         queryKey: agentThreadKeys.detail(threadId),
-        queryFn: () => agentsApi.getThread(threadId),
+        queryFn: () => agentsApi.getThread(threadId, { markViewed: false }),
       })
     })
   }, [activeThreadId, queryClient, threads])
@@ -54,6 +54,7 @@ export function useAgentThread(threadId: string) {
   return useQuery({
     queryKey: agentThreadKeys.detail(threadId),
     queryFn: () => agentsApi.getThread(threadId),
+    refetchOnMount: "always",
     refetchInterval: (query) => {
       const status = query.state.data?.status
       return status === "running" ? 2000 : false