adam/open-swe
1
0
Fork 0
mirror of https://github.com/Sea-Haven-Industries/open-swe.git synced 2026-10-03 02:13:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: settle incomplete review check as neutral, not failure (#1501)

Browse source 
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This commit is contained in:
Johannes du Plessis 2026-06-11 13:03:34 -07:00 • committed by GitHub
parent e0678e8c01
commit 8fa98398fa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
agent/middleware/settle_review_check.py
View file

@ -3,8 +3,8 @@
``publish_review`` normally completes the ``Open SWE Review`` check run and ``publish_review`` normally completes the ``Open SWE Review`` check run and
clears ``review_check_run_id`` from reviewer thread metadata. If the run ends clears ``review_check_run_id`` from reviewer thread metadata. If the run ends
without ever publishing (crash, model-call limit, sandbox failure), the check without ever publishing (crash, model-call limit, sandbox failure), the check
would hang "in progress" on the PR forever. This hook closes it as a failure would hang "in progress" on the PR forever. This hook closes it as neutral —
so the PR's checks section reflects reality. the review not completing is reviewer infrastructure failing, not the PR.
""" """
from __future__ import annotations from __future__ import annotations
@ -63,7 +63,9 @@ async def settle_review_check_on_exit(
title = str(pending.get("title") or "Review completed") title = str(pending.get("title") or "Review completed")
summary = str(pending.get("summary") or "") summary = str(pending.get("summary") or "")
else: else:
conclusion = "failure" # Neutral, not failure: an incomplete review is a reviewer-infra
# problem, and a red X on the PR misreads as a code problem.
conclusion = "neutral"
title = "Review did not complete" title = "Review did not complete"
summary = ( summary = (
"The Open SWE review run ended without publishing a review. " "The Open SWE review run ended without publishing a review. "